arch/arm/include/asm/arch-imxrt/gpio.h: imxrt gpio use commong gpio.h
Subsystems (2)
PATCH 1/1 arch/arm/include/asm/arch-imxrt/gpio.h: imxrt gpio use commong gpio.h
--- arch/arm/include/asm/arch-imxrt/gpio.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
arch/arm/include/asm/arch-imxrt/gpio.h +1 -8
@@ -7,13 +7,6 @@#ifndef __ASM_ARCH_GPIO_H__#define __ASM_ARCH_GPIO_H__ -#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__)) -/* GPIO registers */ -struct gpio_regs { -u32 gpio_dr;/* data */ -u32 gpio_dir;/* direction */ -u32 gpio_psr;/* pad satus */ -}; -#endif +#include <asm/mach-imx/gpio.h> #endif /* __ASM_ARCH_GPIO_H__ */
Signature · 1 line
2.39.5
s/commong/common
can please the committer fix the subject when/if applying?
Thanks in advance
Best regards
Signature · 4 lines
Giulio Benetti CEO&CTO@Benetti Engineering sas https://www.linkedin.com/company/benetti-engineering-sas/ https://www.linkedin.com/in/giulio-benetti-79975951/
Quoted 24 lines · Giulio Benetti
Signed-off-by Giulio Benetti <[email protected]>--- arch/arm/include/asm/arch-imxrt/gpio.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)arch/arm/include/asm/arch-imxrt/gpio.h +1
-8@@ -7,13 +7,6 @@#ifndef __ASM_ARCH_GPIO_H__#define __ASM_ARCH_GPIO_H__ -#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__)) -/* GPIO registers */ -struct gpio_regs { -u32 gpio_dr;/* data */ -u32 gpio_dir;/* direction */ -u32 gpio_psr;/* pad satus */ -}; -#endif +#include <asm/mach-imx/gpio.h> #endif /* __ASM_ARCH_GPIO_H__ */
Fabio Estevam
reviewerHi Giulio,
Quoted 4 lines · Giulio Benetti
s/commong/common
can please the committer fix the subject when/if applying?
Please send a v2 with this fix and include a brief commit log that explains the reason for this change.
Hi Fabio,
Quoted 11 lines · Fabio Estevam
Hi Giulio,
Quoted 4 lines · Giulio Benetti
s/commong/common
can please the committer fix the subject when/if applying?
Please send a v2 with this fix and include a brief commit log that explains the reason for this change.
Ok, thank you for reviewing.
Best regards
Signature · 4 lines
Giulio Benetti CEO&CTO@Benetti Engineering sas https://www.linkedin.com/company/benetti-engineering-sas/ https://www.linkedin.com/in/giulio-benetti-79975951/
PATCH v2 1/1 arch/arm/include/asm/arch-imxrt/gpio.h: imxrt gpio use common gpio.h
In reply to Fabio EstevamThe current file defines a struct gpio_regs identical to the one in <asm/mach-imx/gpio.h>. To eliminate code duplication and align with the approach used for i.MX8M, include the common header instead of redefining the struct.
---V1->V2:
* fix typo on subject and improve commit log as requested by Fabio Estevam
--- arch/arm/include/asm/arch-imxrt/gpio.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
arch/arm/include/asm/arch-imxrt/gpio.h +1 -8
@@ -7,13 +7,6 @@#ifndef __ASM_ARCH_GPIO_H__#define __ASM_ARCH_GPIO_H__ -#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__)) -/* GPIO registers */ -struct gpio_regs { -u32 gpio_dr;/* data */ -u32 gpio_dir;/* direction */ -u32 gpio_psr;/* pad satus */ -}; -#endif +#include <asm/mach-imx/gpio.h> #endif /* __ASM_ARCH_GPIO_H__ */
Signature · 1 line
2.39.5
Fabio Estevam
reviewerRe: [PATCH v2] arch/arm/include/asm/arch-imxrt/gpio.h: imxrt gpio use common gpio.h
Quoted 7 lines · Giulio Benetti
The current file defines a struct
gpio_regsidentical to the one in <asm/mach-imx/gpio.h>. To eliminate code duplication and align with the approach used for i.MX8M, include the common header instead of redefining the struct.Signed-off-by Giulio Benetti <[email protected]>
Applied to u-boot-imx/next, thanks.