Skip to contentSkip to conversation

include/ndisc.h: Audit include list

PATCH In review Tom Rini 1 participant 6 messages Jun 28, 2025 – Jul 8, 2025

Subsystems (3)
lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/5 include/ndisc.h: Audit include list

This file should not include itself, drop that.

---
 include/ndisc.h | 2 --
 1 file changed, 2 deletions(-)
include/ndisc.h +0 -2
index d0fe3acca4aa..7d9e58aa1c21 100644
@@ -10,8 +10,6 @@
 #ifndef __NDISC_H__
 #define __NDISC_H__
 
-#include <ndisc.h>
-
 /* struct nd_msg - ICMPv6 Neighbour Discovery message format */
 struct nd_msg {
 	struct icmp6hdr	icmph;
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 2/5 include/part.h: Audit include list

This file does not need <linker_lists.h> so remove it.

---
 include/part.h | 1 -
 1 file changed, 1 deletion(-)
include/part.h +0 -1
index 7075b2cb1164..c380c21dd4c1 100644
@@ -8,7 +8,6 @@
 
 #include <blk.h>
 #include <u-boot/uuid.h>
-#include <linker_lists.h>
 #include <linux/errno.h>
 #include <linux/list.h>
 
Signature · 1 line
2.43.0
author
#2 lore raw

PATCH 3/5 include/sata.h: Audit include list

In reply to Tom Rini

This file does not need <part.h> so remove it. This file does however need <stdbool.h> so add that in.

---
 include/sata.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/sata.h +2 -1
index 8414e77e42ba..868e89464f03 100644
@@ -1,6 +1,7 @@
 #ifndef __SATA_H__
 #define __SATA_H__
-#include <part.h>
+
+#include <stdbool.h>
 
 int sata_probe(int devnum);
 int sata_remove(int devnum);
Signature · 1 line
2.43.0
author
#3 lore raw

PATCH 4/5 include/spl_gpio.h: Audit include list

In reply to Tom Rini

This file does not need <asm/gpio.h> so remove it. This file does however need <linux/types.h> so add that in. This also shows that arch/arm/mach-rockchip/rk3399/rk3399.c and board/lg/star/star.c were indirectly getting <asm/gpio.h> from here, so add <asm/gpio.h> to them.

---
 arch/arm/mach-rockchip/rk3399/rk3399.c | 1 +
 board/lg/star/star.c                   | 1 +
 include/spl_gpio.h                     | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)
arch/arm/mach-rockchip/rk3399/rk3399.c +1 -0
index 99597076d2ce..43d151708e47 100644
@@ -16,6 +16,7 @@
 #include <asm/arch-rockchip/gpio.h>
 #include <asm/arch-rockchip/grf_rk3399.h>
 #include <asm/arch-rockchip/hardware.h>
+#include <asm/gpio.h>
 #include <linux/bitops.h>
 #include <linux/printk.h>
 #include <power/regulator.h>
board/lg/star/star.c +1 -0
index dc5937541016..0b4a433a5df6 100644
@@ -9,6 +9,7 @@
 #include <fdt_support.h>
 #include <log.h>
 #include <spl_gpio.h>
+#include <asm/gpio.h>
 
 static int star_fix_panel(void *fdt)
 {
include/spl_gpio.h +1 -1
index b33261a6485a..a8aed4d77b96 100644
@@ -9,7 +9,7 @@
 #ifndef __SPL_GPIO_H
 #define __SPL_GPIO_H
 
-#include <asm/gpio.h>
+#include <linux/types.h>
 
 /*
  * The functions listed here should be implemented in the SoC GPIO driver.
Signature · 1 line
2.43.0
author
#4 lore raw

PATCH 5/5 include/vsc9953.h: Audit include list

In reply to Tom Rini

This file does not need <config.h> nor <miiphy.h> so remove them.

---
 include/vsc9953.h | 2 --
 1 file changed, 2 deletions(-)
include/vsc9953.h +0 -2
index fd52c93044b4..1a1455af4f97 100644
@@ -8,8 +8,6 @@
 #ifndef _VSC9953_H_
 #define _VSC9953_H_
 
-#include <config.h>
-#include <miiphy.h>
 #include <asm/types.h>
 #include <linux/bitops.h>
 
Signature · 1 line
2.43.0
author
#5 lore raw
In reply to Tom Rini
Quoted 3 lines · Tom Rini

This file should not include itself, drop that.

Applied to u-boot/master, thanks!

[1/5] include/ndisc.h: Audit include list

      commit: 01feea9ab07c77195de7ab1f8d896b79e00a1985
[2/5] include/part.h: Audit include list
      commit: 643607b3f8ef8d9804f55f110832e17fc1f6c72d
[3/5] include/sata.h: Audit include list
      commit: 7788df3e926186093bdd7710fea2062899cae9c1
[4/5] include/spl_gpio.h: Audit include list
      commit: a591af1123ab280d480ce92cd15871de1e222a51
[5/5] include/vsc9953.h: Audit include list
      commit: e3574b27140973868319a61aa39633fee29d3a7c
Signature · 1 line
Tom