perf test: perf header test fails on s390
Subsystems (2)
PATCH 1/1 perf test: perf header test fails on s390
commit 2d584688643fa ("perf test: Add header shell test") introduced a new test case for perf header. It fails on s390 because call graph option -g is not supported on s390. Also the option --call-graph dwarf is only supported for the event cpu-clock.
Remove this option and the test succeeds.
Output after:
# ./perf test 76 76: perf header tests : Ok
--- tools/perf/tests/shell/header.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/tests/shell/header.sh +2 -2
@@ -51,7 +51,7 @@ check_header_output() { test_file() { echo "Test perf header file" - perf record -o "${perfdata}" -g -- perf test -w noploop + perf record -o "${perfdata}" -- perf test -w noploop perf report --header-only -I -i "${perfdata}" > "${script_output}" check_header_output
@@ -61,7 +61,7 @@ test_file() { test_pipe() { echo "Test perf header pipe" - perf record -o - -g -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}" + perf record -o - -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}" check_header_output echo "Test perf header pipe [Done]"
Signature · 1 line
2.50.0
Quoted 9 lines · Thomas Richter
commit
2d584688643fa("perf test: Add header shell test") introduced a new test case for perf header. It fails on s390 because call graph option -g is not supported on s390. Also the option --call-graph dwarf is only supported for the event cpu-clock.Remove this option and the test succeeds.
Quoted 8 lines
Output after:
# ./perf test 76 76: perf header tests : OkFixes 2d584688643fa ("perf test: Add header shell test")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Ian Rogers <[email protected]>
Thanks Thomas! Given the s390 restriction to require dwarf, should we switch the default "-g" meaning on s390 to mean use dwarf? James Clark proposed this previously. It doesn't affect the change here so:
Thanks,
Ian
Quoted 29 lines
--- tools/perf/tests/shell/header.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/tests/shell/header.sh +2
-3@@ -51,7 +51,7 @@ check_header_output() { test_file() { echo "Test perf header file" - perf record -o "${perfdata}" -g -- perf test -w noploop + perf record -o "${perfdata}" -- perf test -w noploop perf report --header-only -I -i "${perfdata}" > "${script_output}" check_header_output@@ -61,7 +61,7 @@ test_file() { test_pipe() { echo "Test perf header pipe" - perf record -o - -g -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}" + perf record -o - -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}" check_header_output echo "Test perf header pipe [Done]" --2.50.0
Namhyung Kim
maintainerQuoted 19 lines · Ian Rogers
Quoted 9 lines · Thomas Richter
commit
2d584688643fa("perf test: Add header shell test") introduced a new test case for perf header. It fails on s390 because call graph option -g is not supported on s390. Also the option --call-graph dwarf is only supported for the event cpu-clock.Remove this option and the test succeeds.
Quoted 8 lines
Output after:
# ./perf test 76 76: perf header tests : OkFixes 2d584688643fa ("perf test: Add header shell test")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Ian Rogers <[email protected]>
Quoted 5 lines
Thanks Thomas! Given the s390 restriction to require dwarf, should we switch the default "-g" meaning on s390 to mean use dwarf? James Clark proposed this previously. It doesn't affect the change here so:
Reviewed-by Ian Rogers <[email protected]>
Unrelated but I found this test is failing on my machine.
$ ./perf test -v header --- start --- test child forked, pid 42799 Test perf header file [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.182 MB /tmp/__perf_test_header.perf.data.vvFUf (4114 samples) ] Test perf header file [Done] Test perf header pipe Failed to find expect hostname in output Failed to find expect os release in output Failed to find expect arch in output Failed to find expect cpuid in output Failed to find expect nrcpus in output Failed to find expect event in output Failed to find expect cmdline in output Failed to find expect perf version in output Failed to find expect sibling (cores|dies|threads) in output Failed to find expect sibling threads in output Failed to find expect total memory in output Test perf header pipe [Done] ---- end(-1) ---- 83: perf header tests : FAILED!
The pipe mode doesn't have the headers.
$ ./perf record -o- -g -- ./perf test -w noploop | ./perf report -i- -I --header-only # ======== # captured on : Mon Jun 30 09:02:09 2025 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== #
Thanks,
Namhyung
Ian Rogers
reviewerQuoted 54 lines · Namhyung Kim
Quoted 19 lines · Ian Rogers
Quoted 9 lines · Thomas Richter
commit
2d584688643fa("perf test: Add header shell test") introduced a new test case for perf header. It fails on s390 because call graph option -g is not supported on s390. Also the option --call-graph dwarf is only supported for the event cpu-clock.Remove this option and the test succeeds.
Quoted 8 lines
Output after:
# ./perf test 76 76: perf header tests : OkFixes 2d584688643fa ("perf test: Add header shell test")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Ian Rogers <[email protected]>Quoted 5 lines
Thanks Thomas! Given the s390 restriction to require dwarf, should we switch the default "-g" meaning on s390 to mean use dwarf? James Clark proposed this previously. It doesn't affect the change here so:
Reviewed-by Ian Rogers <[email protected]>Unrelated but I found this test is failing on my machine.
$ ./perf test -v header --- start --- test child forked, pid 42799 Test perf header file [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.182 MB /tmp/__perf_test_header.perf.data.vvFUf (4114 samples) ] Test perf header file [Done] Test perf header pipe Failed to find expect hostname in output Failed to find expect os release in output Failed to find expect arch in output Failed to find expect cpuid in output Failed to find expect nrcpus in output Failed to find expect event in output Failed to find expect cmdline in output Failed to find expect perf version in output Failed to find expect sibling (cores|dies|threads) in output Failed to find expect sibling threads in output Failed to find expect total memory in output Test perf header pipe [Done] ---- end(-1) ---- 83: perf header tests : FAILED!The pipe mode doesn't have the headers.
Quoted 9 lines
$ ./perf record -o- -g -- ./perf test -w noploop | ./perf report -i- -I --header-only # ======== # captured on : Mon Jun 30 09:02:09 2025 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== #
Strange, permissions? I see:
``` $ /tmp/perf/perf record -o- -g -- /tmp/perf/perf test -w noploop | /tmp/perf/perf report -i- -I --header-only # ======== # captured on : Mon Jun 30 09:35:21 2025 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== # # hostname : ... # os release : ... # perf version : 6.16.rc3.g8f2bc25ec32d # arch : x86_64 etc. ```
Thanks,
Ian
Quoted 9 lines · Thomas Richter
commit
2d584688643fa("perf test: Add header shell test") introduced a new test case for perf header. It fails on s390 because call graph option -g is not supported on s390. Also the option --call-graph dwarf is only supported for the event cpu-clock.Remove this option and the test succeeds.
[...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung