Skip to contentSkip to conversation

fsi: make fsi_bus_type constant

PATCH In review Greg Kroah-Hartman 2 participants 2 messages Jul 1, 2025 – Jul 8, 2025 FSI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fsi: make fsi_bus_type constant

Now that the driver core can properly handle constant struct bus_type, move the fsi_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime.

---
v2: fix up subject line to be correct

 drivers/fsi/fsi-core.c | 2 +-
 include/linux/fsi.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-core.c +1 -1
index 50e8736039fe..ee39d1699387 100644
@@ -1404,7 +1404,7 @@ void fsi_driver_unregister(struct fsi_driver *fsi_drv)
 }
 EXPORT_SYMBOL_GPL(fsi_driver_unregister);
 
-struct bus_type fsi_bus_type = {
+const struct bus_type fsi_bus_type = {
 	.name		= "fsi",
 	.match		= fsi_bus_match,
 };
include/linux/fsi.h +1 -1
index 8c5eef808788..adea1b432f2d 100644
@@ -68,7 +68,7 @@ extern int fsi_slave_read(struct fsi_slave *slave, uint32_t addr,
 extern int fsi_slave_write(struct fsi_slave *slave, uint32_t addr,
 		const void *val, size_t size);
 
-extern struct bus_type fsi_bus_type;
+extern const struct bus_type fsi_bus_type;
 extern const struct device_type fsi_cdev_type;
 
 enum fsi_dev_type {
Signature · 1 line
2.50.0
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 3 lines · Greg Kroah-Hartman

Now that the driver core can properly handle constant struct bus_type, move the fsi_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime.

Thanks Greg.

Quoted 38 lines

---
v2: fix up subject line to be correct

  drivers/fsi/fsi-core.c | 2 +-
  include/linux/fsi.h    | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-core.c +1 -1
index 50e8736039fe..ee39d1699387 100644
@@ -1404,7 +1404,7 @@ void fsi_driver_unregister(struct fsi_driver *fsi_drv)
  }
  EXPORT_SYMBOL_GPL(fsi_driver_unregister);
 
-struct bus_type fsi_bus_type = {
+const struct bus_type fsi_bus_type = {
  	.name		= "fsi",
  	.match		= fsi_bus_match,
  };
include/linux/fsi.h +1 -1
index 8c5eef808788..adea1b432f2d 100644
@@ -68,7 +68,7 @@ extern int fsi_slave_read(struct fsi_slave *slave, uint32_t addr,
  extern int fsi_slave_write(struct fsi_slave *slave, uint32_t addr,
  		const void *val, size_t size);
 
-extern struct bus_type fsi_bus_type;
+extern const struct bus_type fsi_bus_type;
  extern const struct device_type fsi_cdev_type;
 
  enum fsi_dev_type {