bcachefs: Don't lock exec_update_lock
PATCH 1/1 bcachefs: Don't lock exec_update_lock
exec_update_lock is used to check permissions, no need here.
Signed-off-by Alan Huang <[email protected]>
--- fs/bcachefs/util.c | 5 ----- 1 file changed, 5 deletions(-)
fs/bcachefs/util.c +0 -5
@@ -299,17 +299,12 @@ int bch2_save_backtrace(bch_stacktrace *stack, struct task_struct *task, unsigneif (ret)return ret; -if (!down_read_trylock (&task->signal->exec_update_lock)) -return -1 ; -do { nr_entries =stack_trace_save_tsk (task, stack->data, stack->size, skipnr +1 ); }while (nr_entries == stack->size && !(ret =darray_make_room_gfp (stack, stack->size *2 , gfp))); stack->nr = nr_entries; -up_read (&task->signal->exec_update_lock); -return ret;#else return 0 ;
Signature · 1 line
2.48.1
Quoted 1 line · Alan Huang
exec_update_lockis used to check permissions, no need here.
Can you explain a bit more? How thoroughly did you audit the locking?
Quoted 31 lines
Signed-off-by Alan Huang <[email protected]>--- fs/bcachefs/util.c | 5 ----- 1 file changed, 5 deletions(-)fs/bcachefs/util.c +0
-5@@ -299,17 +299,12 @@ int bch2_save_backtrace(bch_stacktrace *stack, struct task_struct *task, unsigneif (ret)return ret; -if (!down_read_trylock (&task->signal->exec_update_lock)) -return -1 ; -do { nr_entries =stack_trace_save_tsk (task, stack->data, stack->size, skipnr +1 ); }while (nr_entries == stack->size && !(ret =darray_make_room_gfp (stack, stack->size *2 , gfp))); stack->nr = nr_entries; -up_read (&task->signal->exec_update_lock); -return ret;#else return 0 ;Signature · 1 line
2.48.1