Skip to contentSkip to conversation

mfd: axp20x: set explicit ID for regulator cell if no IRQ line is present

PATCH Applied Chen-Yu Tsai 2 participants 2 messages Jul 1, 2025 – Jul 10, 2025

Subsystems (3)
lore
Share & tools
lore

Chen-Yu Tsai

author maintainer
#0 lore raw

PATCH v2 1/1 mfd: axp20x: set explicit ID for regulator cell if no IRQ line is present

From: Chen-Yu Tsai <[email protected]>

Originally an explicit ID for the AXP313/AXP323 regulator was set to avoid a conflict with the primary AXP717 PMIC on Allwinner A523 family boards.

This didn't entirely work since on some or all of these boards, the interrupt line on this secondary PMIC was left unconnected, and thus the driver would fall back to the generic "no interrupt; only regulators" case, which didn't have the explicit ID set, thus undoing the intended fix.

Also set an explicit ID for the regulator cell in the no IRQ generic fall back case. This fixes the conflict for the AXP717 + AXP313/AXP323 case. For the actual single PMIC with no IRQ connected case, the ID does not affect functionality, only the device naming of the regulator cell, and by extension the name and path under sysfs.

Fixes 249abf9b1e25 ("mfd: axp20x: Set explicit ID for AXP313 regulator")

---

This is an alternative to

    mfd: axp20x: Skip PEK on AXP313A/AXP323 if no interrupt line is available

which was deemed too fragile.

---
 drivers/mfd/axp20x.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/mfd/axp20x.c +2 -3
index 25c639b348cd..c5f0ebae327f 100644
@@ -1231,9 +1231,8 @@ static const struct mfd_cell axp15060_cells[] = {
 
 /* For boards that don't have IRQ line connected to SOC. */
 static const struct mfd_cell axp_regulator_only_cells[] = {
-	{
-		.name		= "axp20x-regulator",
-	},
+	/* PMIC without IRQ line may be secondary PMIC */
+	MFD_CELL_BASIC("axp20x-regulator", NULL, NULL, 0, 1),
 };
 
 static int axp20x_power_off(struct sys_off_data *data)
Signature · 1 line
2.39.5
maintainer Applied
#1 lore raw

Re: (subset) [PATCH v2] mfd: axp20x: set explicit ID for regulator cell if no IRQ line is present

Quoted 11 lines · Chen-Yu Tsai

Originally an explicit ID for the AXP313/AXP323 regulator was set to avoid a conflict with the primary AXP717 PMIC on Allwinner A523 family boards.

This didn't entirely work since on some or all of these boards, the interrupt line on this secondary PMIC was left unconnected, and thus the driver would fall back to the generic "no interrupt; only regulators" case, which didn't have the explicit ID set, thus undoing the intended fix.

[...]

Applied, thanks!

[1/1] mfd: axp20x: set explicit ID for regulator cell if no IRQ line is present

      commit: c6c68f08d524ab76cc3cf6449a8cb235b8c3fc06

--
Lee Jones [李琼斯]