Skip to contentSkip to conversation

spdx30: Allow VEX Justification to be configurable

PATCH Superseded Joshua Watt 2 participants 3 messages Jul 1, 2025 – Jul 2, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spdx30: Allow VEX Justification to be configurable

Instead of hard coding the VEX justifications for "Ignored" CVE status, add a map that configures what justification should be used for each status.

This allows other justifications to be easily added, and also ensures that status fields added externally (by downstream) can set an appropriate justification if necessary.

---
 meta/conf/cve-check-map.conf |  4 ++++
 meta/lib/oe/spdx30_tasks.py  | 33 ++++++++++++++++-----------------
 2 files changed, 20 insertions(+), 17 deletions(-)
meta/conf/cve-check-map.conf +4 -0
index ac956379d19..0563bcaf94b 100644
@@ -28,8 +28,12 @@ CVE_CHECK_STATUSMAP[cpe-incorrect] = "Ignored"
 CVE_CHECK_STATUSMAP[disputed] = "Ignored"
 # use when vulnerability depends on build or runtime configuration which is not used
 CVE_CHECK_STATUSMAP[not-applicable-config] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-config] = "vulnerableCodeNotPresent"
+
 # use when vulnerability affects other platform (e.g. Windows or Debian)
 CVE_CHECK_STATUSMAP[not-applicable-platform] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-config] = "vulnerableCodeNotPresent"
+
 # use when upstream acknowledged the vulnerability but does not plan to fix it
 CVE_CHECK_STATUSMAP[upstream-wontfix] = "Ignored"
 
meta/lib/oe/spdx30_tasks.py +16 -17
index 5d9f3168d97..c352dab1520 100644
@@ -724,24 +724,23 @@ def create_spdx(d):
                             impact_statement=description,
                         )
 
-                        if detail in (
-                            "ignored",
-                            "cpe-incorrect",
-                            "disputed",
-                            "upstream-wontfix",
-                        ):
-                            # VEX doesn't have justifications for this
-                            pass
-                        elif detail in (
-                            "not-applicable-config",
-                            "not-applicable-platform",
-                        ):
-                            for v in spdx_vex:
-                                v.security_justificationType = (
-                                    oe.spdx30.security_VexJustificationType.vulnerableCodeNotPresent
+                        vex_just_type = d.getVarFlag(
+                            "CVE_CHECK_VEX_JUSTIFICATION", detail
+                        )
+                        if vex_just_type:
+                            if (
+                                vex_just_type
+                                not in oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS
+                            ):
+                                bb.fatal(
+                                    f"Unknown vex justification '{vex_just_type}', detail '{detail}', for ignored {cve}"
                                 )
-                        else:
-                            bb.fatal(f"Unknown detail '{detail}' for ignored {cve}")
+
+                            for v in spdx_vex:
+                                v.security_justificationType = oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS[
+                                    vex_just_type
+                                ]
+
                     elif status == "Unknown":
                         bb.note(f"Skipping {cve} with status 'Unknown'")
                     else:
Signature · 1 line
2.49.0
#1 lore raw

Joshua Watt via lists.openembedded.org <JPEWhacker= [email protected]> escreveu (terça, 1/07/2025 à(s) 19:04):

Quoted 29 lines

Instead of hard coding the VEX justifications for "Ignored" CVE status, add a map that configures what justification should be used for each status.

This allows other justifications to be easily added, and also ensures that status fields added externally (by downstream) can set an appropriate justification if necessary.

---
 meta/conf/cve-check-map.conf |  4 ++++
 meta/lib/oe/spdx30_tasks.py  | 33 ++++++++++++++++-----------------
 2 files changed, 20 insertions(+), 17 deletions(-)
meta/conf/cve-check-map.conf +0 -0
index ac956379d19..0563bcaf94b 100644
@@ -28,8 +28,12 @@ CVE_CHECK_STATUSMAP[cpe-incorrect] = "Ignored"
 CVE_CHECK_STATUSMAP[disputed] = "Ignored"
 # use when vulnerability depends on build or runtime configuration which

is not used
CVE_CHECK_STATUSMAP[not-applicable-config] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-config] = "vulnerableCodeNotPresent"

meta/conf/cve-check-map.conf +2 -0
+
 # use when vulnerability affects other platform (e.g. Windows or Debian)
 CVE_CHECK_STATUSMAP[not-applicable-platform] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-config] =
Quoted 2 lines

"vulnerableCodeNotPresent"

Looks like this one should be not-applicable-platform instead of not-applicable-config.

Jose

Quoted 70 lines

+

 # use when upstream acknowledged the vulnerability but does not plan to
fix it
 CVE_CHECK_STATUSMAP[upstream-wontfix] = "Ignored"
meta/lib/oe/spdx30_tasks.py +0 -15
index 5d9f3168d97..c352dab1520 100644
@@ -724,24 +724,23 @@ def create_spdx(d):
                             impact_statement=description,
                         )
 
-                        if detail in (
-                            "ignored",
-                            "cpe-incorrect",
-                            "disputed",
-                            "upstream-wontfix",
-                        ):
-                            # VEX doesn't have justifications for this
-                            pass
-                        elif detail in (
-                            "not-applicable-config",
-                            "not-applicable-platform",
-                        ):
-                            for v in spdx_vex:
-                                v.security_justificationType = (
-

oe.spdx30.security_VexJustificationType.vulnerableCodeNotPresent

meta/lib/oe/spdx30_tasks.py +7 -0
+                        vex_just_type = d.getVarFlag(
+                            "CVE_CHECK_VEX_JUSTIFICATION", detail
+                        )
+                        if vex_just_type:
+                            if (
+                                vex_just_type
+                                not in

oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS

meta/lib/oe/spdx30_tasks.py +3 -0
+                            ):
+                                bb.fatal(
+                                    f"Unknown vex justification

'{vex_just_type}', detail '{detail}', for ignored {cve}"

                                 )
meta/lib/oe/spdx30_tasks.py +0 -2
-                        else:
-                            bb.fatal(f"Unknown detail '{detail}' for

ignored {cve}")

meta/lib/oe/spdx30_tasks.py +3 -0
+
+                            for v in spdx_vex:
+                                v.security_justificationType =

oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS[

meta/lib/oe/spdx30_tasks.py +3 -1
+                                    vex_just_type
+                                ]
+
                     elif status == "Unknown":
                         bb.note(f"Skipping {cve} with status 'Unknown'")
                     else:
--

2.49.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#219713):
https://lists.openembedded.org/g/openembedded-core/message/219713
Mute This Topic: https://lists.openembedded.org/mt/113933828/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma
#2 lore raw

PATCH v2 1/1 spdx30: Allow VEX Justification to be configurable

In reply to Joshua Watt

Instead of hard coding the VEX justifications for "Ignored" CVE status, add a map that configures what justification should be used for each status.

This allows other justifications to be easily added, and also ensures that status fields added externally (by downstream) can set an appropriate justification if necessary.

---
 meta/conf/cve-check-map.conf |  4 ++++
 meta/lib/oe/spdx30_tasks.py  | 33 ++++++++++++++++-----------------
 2 files changed, 20 insertions(+), 17 deletions(-)
meta/conf/cve-check-map.conf +4 -0
index ac956379d19..fc49fe0a500 100644
@@ -28,8 +28,12 @@ CVE_CHECK_STATUSMAP[cpe-incorrect] = "Ignored"
 CVE_CHECK_STATUSMAP[disputed] = "Ignored"
 # use when vulnerability depends on build or runtime configuration which is not used
 CVE_CHECK_STATUSMAP[not-applicable-config] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-config] = "vulnerableCodeNotPresent"
+
 # use when vulnerability affects other platform (e.g. Windows or Debian)
 CVE_CHECK_STATUSMAP[not-applicable-platform] = "Ignored"
+CVE_CHECK_VEX_JUSTIFICATION[not-applicable-platform] = "vulnerableCodeNotPresent"
+
 # use when upstream acknowledged the vulnerability but does not plan to fix it
 CVE_CHECK_STATUSMAP[upstream-wontfix] = "Ignored"
 
meta/lib/oe/spdx30_tasks.py +16 -17
index 5d9f3168d97..c352dab1520 100644
@@ -724,24 +724,23 @@ def create_spdx(d):
                             impact_statement=description,
                         )
 
-                        if detail in (
-                            "ignored",
-                            "cpe-incorrect",
-                            "disputed",
-                            "upstream-wontfix",
-                        ):
-                            # VEX doesn't have justifications for this
-                            pass
-                        elif detail in (
-                            "not-applicable-config",
-                            "not-applicable-platform",
-                        ):
-                            for v in spdx_vex:
-                                v.security_justificationType = (
-                                    oe.spdx30.security_VexJustificationType.vulnerableCodeNotPresent
+                        vex_just_type = d.getVarFlag(
+                            "CVE_CHECK_VEX_JUSTIFICATION", detail
+                        )
+                        if vex_just_type:
+                            if (
+                                vex_just_type
+                                not in oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS
+                            ):
+                                bb.fatal(
+                                    f"Unknown vex justification '{vex_just_type}', detail '{detail}', for ignored {cve}"
                                 )
-                        else:
-                            bb.fatal(f"Unknown detail '{detail}' for ignored {cve}")
+
+                            for v in spdx_vex:
+                                v.security_justificationType = oe.spdx30.security_VexJustificationType.NAMED_INDIVIDUALS[
+                                    vex_just_type
+                                ]
+
                     elif status == "Unknown":
                         bb.note(f"Skipping {cve} with status 'Unknown'")
                     else:
Signature · 1 line
2.49.0