mm/memory_hotplug: fixup crash during uevent handling
Subsystems (4)
v2 cover mm/memory_hotplug: fixup crash during uevent handling
From: Hannes Reinecke <[email protected]>
Hi all,
we have some udev rules trying to read the sysfs attribute 'valid_zones' during an memory 'add' event, causing a crash in zone_for_pfn_range(). Debugging found that mem->nid was set to NUMA_NO_NODE, which crashed in NODE_DATA(nid). Further analysis revealed that we're running into a race with udev event
processing: add_memory_resource() has this function calls:
1) __try_online_node()
2) arch_add_memory()
3) create_memory_block_devices()
-> calls device_register() -> memory 'add' event
4) node_set_online()/__register_one_node() -> calls device_register() -> node 'add' event
5) register_memory_blocks_under_node()
-> sets mem->nid
Which, to the uninitated, is ... weird ...
Why do we try to online the node in 1), but only register the node in 4) _after_ we have created the memory blocks in 3) ? And why do we set the 'nid' value in 5), when the uevent (which might need to see the correct 'nid' value) is sent out in 3) ?
There must be a reason, I'm sure ...
So here's a small patchset to fixup uevent ordering. The first patch adds a 'nid' parameter to add_memory_blocks() (to avoid mem->nid being initialized with NUMA_NO_NODE), and the second patch reshuffles the code in add_memory_resource() to fully initialize the node prior to calling create_memory_block_devices() so that the node is valid at that time and uevent processing will see correct values in sysfs.
As usual, comments and reviews are welcome.
Changes to the original submission:
- Add patch to rename memory_block_add_nid()
- Add reviews
Hannes Reinecke (3):
drivers/base/memory: add node id parameter to add_memory_block() mm/memory_hotplug: activate node before adding new memory blocks drivers/base: move memory_block_add_nid() into the caller
drivers/base/memory.c | 53 ++++++++++++++++++------------------------ drivers/base/node.c | 10 ++++---- include/linux/memory.h | 5 ++-- mm/memory_hotplug.c | 32 +++++++++++++------------ 4 files changed, 46 insertions(+), 54 deletions(-)
Signature · 1 line
2.43.0
PATCH v2 1/3 drivers/base/memory: add node id parameter to add_memory_block()
Add a 'nid' parameter to add_memory_block() to initialize the memory block with the correct node id.
--- drivers/base/memory.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/base/memory.c +4 -11
@@ -822,7 +822,7 @@ void memory_block_add_nid(struct memory_block *mem, int nid, }#endif -static int add_memory_block (unsigned long block_id,unsigned long state, +static int add_memory_block (unsigned long block_id,int nid,unsigned long state,struct vmem_altmap *altmap,struct memory_group *group) {
@@ -840,7 +840,7 @@ static int add_memory_block(unsigned long block_id, unsigned long state, mem->start_section_nr = block_id * sections_per_block; mem->state = state; - mem->nid =NUMA_NO_NODE ; + mem->nid = nid; mem->altmap = altmap;INIT_LIST_HEAD (&mem->group_next);
@@ -867,13 +867,6 @@ static int add_memory_block(unsigned long block_id, unsigned long state,return 0 ; } -static int add_hotplug_memory_block (unsigned long block_id, -struct vmem_altmap *altmap, -struct memory_group *group) -{ -return add_memory_block (block_id,MEM_OFFLINE , altmap, group); -} -static void remove_memory_block (struct memory_block *memory) {if (WARN_ON_ONCE (memory->dev.bus != &memory_subsys))
@@ -913,7 +906,7 @@ int create_memory_block_devices(unsigned long start, unsigned long size,return -EINVAL ;for (block_id = start_block_id; block_id != end_block_id; block_id++) { - ret =add_hotplug_memory_block (block_id, altmap, group); + ret =add_memory_block (block_id,NUMA_NO_NODE ,MEM_OFFLINE , altmap, group);if (ret)break ; }
@@ -1018,7 +1011,7 @@ void __init memory_dev_init(void)continue ; block_id =memory_block_id (nr); - ret =add_memory_block (block_id,MEM_ONLINE ,NULL ,NULL ); + ret =add_memory_block (block_id,NUMA_NO_NODE ,MEM_ONLINE ,NULL ,NULL );if (ret) {panic ("%s() failed to add memory block: %d\n" , __func__, ret);
Signature · 1 line
2.43.0
PATCH v2 2/3 mm/memory_hotplug: activate node before adding new memory blocks
In reply to Hannes ReineckeThe sysfs attributes for memory blocks require the node ID to be set and initialized, so move the node activation before adding new memory blocks. This also has the nice side effect that the BUG_ON() can be converted into a WARN_ON() as we now can handle registration errors.
--- drivers/base/memory.c | 19 +++++++++---------- include/linux/memory.h | 2 +- mm/memory_hotplug.c | 32 +++++++++++++++++--------------- 3 files changed, 27 insertions(+), 26 deletions(-)
drivers/base/memory.c +9 -10
@@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, mem->zone =early_node_zone_for_memory_block (mem, nid); else mem->zone = NULL; +/* +* If this memory block spans multiple nodes, we only indicate +* the last processed node. If we span multiple nodes (not applicable +* to hotplugged memory), zone == NULL will prohibit memory offlining +* and consequently unplug. +*/ + mem->nid = nid; } - -/* -* If this memory block spans multiple nodes, we only indicate -* the last processed node. If we span multiple nodes (not applicable -* to hotplugged memory), zone == NULL will prohibit memory offlining -* and consequently unplug. -*/ - mem->nid = nid; }#endif
@@ -892,7 +891,7 @@ static void remove_memory_block(struct memory_block *memory)* Called under device_hotplug_lock. */ int create_memory_block_devices (unsigned long start,unsigned long size, -struct vmem_altmap *altmap, +int nid,struct vmem_altmap *altmap,struct memory_group *group) {const unsigned long start_block_id =pfn_to_block_id (PFN_DOWN (start));
@@ -906,7 +905,7 @@ int create_memory_block_devices(unsigned long start, unsigned long size,return -EINVAL ;for (block_id = start_block_id; block_id != end_block_id; block_id++) { - ret =add_memory_block (block_id,NUMA_NO_NODE ,MEM_OFFLINE , altmap, group); + ret =add_memory_block (block_id, nid,MEM_OFFLINE , altmap, group);if (ret)break ; }
include/linux/memory.h +1 -1
@@ -161,7 +161,7 @@ static inline unsigned long memory_block_advised_max_size(void)extern int register_memory_notifier (struct notifier_block *nb);extern void unregister_memory_notifier (struct notifier_block *nb);int create_memory_block_devices (unsigned long start,unsigned long size, -struct vmem_altmap *altmap, +int nid,struct vmem_altmap *altmap,struct memory_group *group);void remove_memory_block_devices (unsigned long start,unsigned long size);extern void memory_dev_init (void );
mm/memory_hotplug.c +17 -15
@@ -1478,7 +1478,7 @@ static int create_altmaps_and_memory_blocks(int nid, struct memory_group *group, }/* create memory block devices after memory was added */ - ret =create_memory_block_devices (cur_start, memblock_size, + ret =create_memory_block_devices (cur_start, memblock_size, nid, params.altmap, group);if (ret) {arch_remove_memory (cur_start, memblock_size,NULL );
@@ -1540,8 +1540,16 @@ int add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) ret =__try_online_node (nid, false);if (ret <0 ) - goto error; - new_node = ret; + goto error_memblock_remove; +if (ret) { +node_set_online (nid); + ret =__register_one_node (nid); +if (WARN_ON (ret)) { +node_set_offline (nid); + goto error_memblock_remove; + } + new_node = true; + }/* * Self hosted memmap array
@@ -1557,24 +1565,13 @@ int add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) goto error;/* create memory block devices after memory was added */ - ret =create_memory_block_devices (start, size,NULL , group); + ret =create_memory_block_devices (start, size, nid,NULL , group);if (ret) {arch_remove_memory (start, size, params.altmap); goto error; } } -if (new_node) { -/* If sysfs file of new node can't be created, cpu on the node -* can't be hot-added. There is no rollback way now. -* So, check by BUG_ON() to catch it reluctantly.. -* We online node here. We can't roll back from here. -*/ -node_set_online (nid); - ret =__register_one_node (nid); -BUG_ON (ret); - } -register_memory_blocks_under_node (nid,PFN_DOWN (start),PFN_UP (start + size -1 ),MEMINIT_HOTPLUG );
@@ -1599,6 +1596,11 @@ int add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags)return ret; error: +if (new_node) { +node_set_offline (nid); +unregister_one_node (nid); + } +error_memblock_remove:if (IS_ENABLED (CONFIG_ARCH_KEEP_MEMBLOCK ))memblock_remove (start, size); error_mem_hotplug_end:
Signature · 1 line
2.43.0
PATCH v2 3/3 drivers/base: move memory_block_add_nid() into the caller
In reply to Hannes ReineckeNow the node id only needs to be set for early memory, so move memory_block_add_nid() into the caller and rename it into memory_block_add_nid_early(). This allows us to further simplify the code by dropping the 'context' argument to do_register_memory_block_under_node().
--- drivers/base/memory.c | 21 +++++++++++---------- drivers/base/node.c | 10 ++++------ include/linux/memory.h | 3 +-- 3 files changed, 16 insertions(+), 18 deletions(-)
drivers/base/memory.c +11 -10
@@ -782,21 +782,22 @@ static struct zone *early_node_zone_for_memory_block(struct memory_block *mem,#ifdef CONFIG_NUMA /** -* memory_block_add_nid() - Indicate that system RAM falling into this memory -* block device (partially) belongs to the given node. +* memory_block_add_nid_early() - Indicate that early system RAM falling into +* this memory block device (partially) belongs +* to the given node. * @mem: The memory block device. * @nid: The node id. -* @context: The memory initialization context. * -* Indicate that system RAM falling into this memory block (partially) belongs -* to the given node. If the context indicates ("early") that we are adding the -* node during node device subsystem initialization, this will also properly -* set/adjust mem->zone based on the zone ranges of the given node. +* Indicate that early system RAM falling into this memory block (partially) +* belongs to the given node. This will also properly set/adjust mem->zone based +* on the zone ranges of the given node. +* +* Memory hotplug handles this on memory block creation, where we can only have +* a single nid span a memory block. */ -void memory_block_add_nid (struct memory_block *mem,int nid, -enum meminit_context context) +void memory_block_add_nid_early (struct memory_block *mem,int nid) { -if (context ==MEMINIT_EARLY && mem->nid != nid) { +if (mem->nid != nid) {/* * For early memory we have to determine the zone when setting * the node id and handle multiple nodes spanning a single
drivers/base/node.c +4 -6
@@ -766,13 +766,10 @@ static int __ref get_nid_for_pfn(unsigned long pfn) }static void do_register_memory_block_under_node (int nid, -struct memory_block *mem_blk, -enum meminit_context context) +struct memory_block *mem_blk) {int ret; -memory_block_add_nid (mem_blk, nid, context); - ret =sysfs_create_link_nowarn (&node_devices[nid]->dev.kobj, &mem_blk->dev.kobj,kobject_name (&mem_blk->dev.kobj));
@@ -824,7 +821,8 @@ static int register_mem_block_under_node_early(struct memory_block *mem_blk,if (page_nid != nid)continue ; -do_register_memory_block_under_node (nid, mem_blk,MEMINIT_EARLY ); +memory_block_add_nid_early (mem_blk, nid); +do_register_memory_block_under_node (nid, mem_blk);return 0 ; }/* mem section does not span the specified node */
@@ -840,7 +838,7 @@ static int register_mem_block_under_node_hotplug(struct memory_block *mem_blk, {int nid = *(int *)arg; -do_register_memory_block_under_node (nid, mem_blk,MEMINIT_HOTPLUG ); +do_register_memory_block_under_node (nid, mem_blk);return 0 ; }
include/linux/memory.h +1 -2
@@ -186,8 +186,7 @@ int walk_dynamic_memory_groups(int nid, walk_memory_groups_func_t func, })#ifdef CONFIG_NUMA -void memory_block_add_nid (struct memory_block *mem,int nid, -enum meminit_context context); +void memory_block_add_nid_early (struct memory_block *mem,int nid);#endif /* CONFIG_NUMA */ int memory_block_advise_max_size (unsigned long size);unsigned long memory_block_advised_max_size (void );
Signature · 1 line
2.43.0
Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks
In reply to Hannes ReineckeQuoted 7 lines · Hannes Reinecke
The sysfs attributes for memory blocks require the node ID to be set and initialized, so move the node activation before adding new memory blocks. This also has the nice side effect that the
BUG_ON()can be converted into aWARN_ON()as we now can handle registration errors.Fixes b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use __try_online_node")
We should CC stable.
Quoted 21 lines
Signed-off-by Hannes Reinecke <[email protected]>--- drivers/base/memory.c | 19 +++++++++---------- include/linux/memory.h | 2 +- mm/memory_hotplug.c | 32 +++++++++++++++++--------------- 3 files changed, 27 insertions(+), 26 deletions(-)drivers/base/memory.c +6
-0@@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, mem->zone =early_node_zone_for_memory_block (mem, nid); else mem->zone = NULL; +/* +* If this memory block spans multiple nodes, we only indicate +* the last processed node. If we span multiple nodes (not applicable +* to hotplugged memory), zone == NULL will prohibit memory offlining +* and consequently unplug. +*/
drivers/base/memory.c void memory_block_add_nid(struct memory_block *mem, int nid, · line 821
Quoted 10 lines
drivers/base/memory.c +1
-8+ mem->nid = nid; } - -/* -* If this memory block spans multiple nodes, we only indicate -* the last processed node. If we span multiple nodes (not applicable -* to hotplugged memory), zone == NULL will prohibit memory offlining -* and consequently unplug. -*/ - mem->nid = nid;
I would not perform this change in this patch. It's not required here, right? We're simply re-setting the nid. Patch #3 can clean that up.
Apart from that
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks
Quoted 11 lines · David Hildenbrand
Quoted 7 lines · Hannes Reinecke
The sysfs attributes for memory blocks require the node ID to be set and initialized, so move the node activation before adding new memory blocks. This also has the nice side effect that the
BUG_ON()can be converted into aWARN_ON()as we now can handle registration errors.Fixes b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use __try_online_node")We should CC stable.
Yeah, that's probably not a bad idea.
Quoted 30 lines
Quoted 30 lines
Signed-off-by Hannes Reinecke <[email protected]>---
drivers/base/memory.c | 19 +++++++++----------include/linux/memory.h| 2 +-
mm/memory_hotplug.c | 32 +++++++++++++++++---------------3 files changed, 27 insertions(+), 26 deletions(-)drivers/base/memory.c +0
-0@@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, mem->zone = early_node_zone_for_memory_block(mem, nid);else
mem->zone= NULL;
+ /*
+ * If this memory block spans multiple nodes, we only indicate + * the last processed node. If we span multiple nodes (not applicable
+ * to hotplugged memory), zone == NULL will prohibit memory offlining
+ * and consequently unplug.
+ */
+mem->nid= nid;
}
-
- /*
- * If this memory block spans multiple nodes, we only indicate - * the last processed node. If we span multiple nodes (not
Quoted 9 lines
Quoted 6 lines
applicable
- * to hotplugged memory), zone == NULL will prohibit memory offlining
- * and consequently unplug.
- */
-mem->nid= nid;I would not perform this change in this patch. It's not required here, right? We're simply re-setting the nid. Patch #3 can clean that up.
Well. You tell me :-)
Thing is, we already have a 'nid' value as argument to add_memory_resource().
So I would _think_ that it should be the same value which we end up with in memory_block_add_nid().
But if that's the case we could've set it during memblock initialization, which we don't. So I thought there must be a reason for that, and the only reason I could think of is that 'nid' is not known during memblock initialization, ie that the 'nid' value in add_memory_resource() is a different 'nid' value from the one used in memory_block_add_nid().
If so then we cannot leave out.
If not, then indeed, we can leave it out.
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Re: [PATCH 1/3] drivers/base/memory: add node id parameter to add_memory_block()
In reply to Hannes ReineckeQuoted 56 lines · Hannes Reinecke
Add a 'nid' parameter to
add_memory_block()to initialize the memory block with the correct node id.Signed-off-by Hannes Reinecke <[email protected]>Acked-by Oscar Salvador <[email protected]>--- drivers/base/memory.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)drivers/base/memory.c +3
-10@@ -822,7 +822,7 @@ void memory_block_add_nid(struct memory_block *mem, int nid, }#endif -static int add_memory_block (unsigned long block_id,unsigned long state, +static int add_memory_block (unsigned long block_id,int nid,unsigned long state,struct vmem_altmap *altmap,struct memory_group *group) {@@ -840,7 +840,7 @@ static int add_memory_block(unsigned long block_id, unsigned long state, mem->start_section_nr = block_id * sections_per_block; mem->state = state; - mem->nid =NUMA_NO_NODE ; + mem->nid = nid; mem->altmap = altmap;INIT_LIST_HEAD (&mem->group_next);@@ -867,13 +867,6 @@ static int add_memory_block(unsigned long block_id, unsigned long state,return 0 ; } -static int add_hotplug_memory_block (unsigned long block_id, -struct vmem_altmap *altmap, -struct memory_group *group) -{ -return add_memory_block (block_id,MEM_OFFLINE , altmap, group); -} -static void remove_memory_block (struct memory_block *memory) {if (WARN_ON_ONCE (memory->dev.bus != &memory_subsys))@@ -913,7 +906,7 @@ int create_memory_block_devices(unsigned long start, unsigned long size,return -EINVAL ;for (block_id = start_block_id; block_id != end_block_id; block_id++) { - ret =add_hotplug_memory_block (block_id, altmap, group); + ret =add_memory_block (block_id,NUMA_NO_NODE ,MEM_OFFLINE , altmap, group);if (ret)break ; }
drivers/base/memory.c void __init memory_dev_init(void) · line 1017
Quoted 8 lines
drivers/base/memory.c +1
-1@@ -1018,7 +1011,7 @@ void __init memory_dev_init(void)continue ; block_id =memory_block_id (nr); - ret =add_memory_block (block_id,MEM_ONLINE ,NULL ,NULL ); + ret =add_memory_block (block_id,NUMA_NO_NODE ,MEM_ONLINE ,NULL ,NULL );if (ret) {panic ("%s() failed to add memory block: %d\n" , __func__, ret);
This looks good to me. Feel free to add
Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks
In reply to Hannes ReineckeQuoted 56 lines · Hannes Reinecke
Quoted 7 lines · David Hildenbrand
Quoted 6 lines · Hannes Reinecke
The sysfs attributes for memory blocks require the node ID to be set and initialized, so move the node activation before adding new memory blocks. This also has the nice side effect that the
BUG_ON()can be converted into aWARN_ON()as we now can handle registration errors.Quoted 5 lines
Quoted 2 lines
Fixes b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resourceuse
__try_online_node")We should CC stable.
Yeah, that's probably not a bad idea.
Quoted 31 lines
Quoted 31 lines
Signed-off-by Hannes Reinecke <[email protected]>--- drivers/base/memory.c | 19 +++++++++---------- include/linux/memory.h | 2 +- mm/memory_hotplug.c | 32 +++++++++++++++++--------------- 3 files changed, 27 insertions(+), 26 deletions(-)drivers/base/memory.c +3
-0@@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, mem->zone = early_node_zone_for_memory_block(mem, nid); else mem->zone = NULL; + /* +* If this memory block spans multiple nodes, we only indicate +* the last processed node. If we span multiple nodes (not applicable
+ * to hotplugged memory), zone == NULL will prohibit memory offlining
+ * and consequently unplug.
+ */
+mem->nid= nid;
}
-
- /*
- * If this memory block spans multiple nodes, we only indicate - * the last processed node. If we span multiple nodes (not applicableQuoted 9 lines
Quoted 5 lines
- * to hotplugged memory), zone == NULL will prohibit memory offlining
- * and consequently unplug.
- */
-mem->nid= nid;I would not perform this change in this patch. It's not required here, right? We're simply re-setting the nid. Patch #3 can clean that up.
Quoted 6 lines
Well. You tell me :-)
Thing is, we already have a 'nid' value as argument to
add_memory_resource().
So I would _think_ that it should be the same value which we end up with inmemory_block_add_nid().
Yes, on the memory hotplug path it should be the same value. Everything else would be really broken.
Quoted 6 lines
But if that's the case we could've set it during memblock initialization, which we don't. So I thought there must be a reason for that, and the only reason I could think of is that 'nid' is not known during memblock initialization, ie that the 'nid' value in
add_memory_resource()is a different 'nid' value from the one used inmemory_block_add_nid().
It must be the same. Only for boot memory, we can have multiple nids. And the current behavior is to set mem->nid to the
So unless I am confused at this point
1) You can avoid changing this function in this patch. We will reset the same value in case of memory hotplug which ...
2) Will be cleaned up by patch #3, where we simply call the function only for early memory.
Makes sense or is the warm weather affecting my reasoning? :)
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH 3/3] drivers/base: move memory_block_add_nid() into the caller
In reply to Hannes ReineckeQuoted 9 lines · Hannes Reinecke
Now the node id only needs to be set for early memory, so move
memory_block_add_nid()into the caller and rename it intomemory_block_add_nid_early(). This allows us to further simplify the code by dropping the 'context' argument todo_register_memory_block_under_node().Suggested-by David Hildenbrand <[email protected]>Signed-off-by Hannes Reinecke <[email protected]>---
Thanks!
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks
In reply to David HildenbrandQuoted 77 lines · David Hildenbrand
Quoted 56 lines · Hannes Reinecke
Quoted 7 lines · David Hildenbrand
Quoted 6 lines · Hannes Reinecke
The sysfs attributes for memory blocks require the node ID to be set and initialized, so move the node activation before adding new memory blocks. This also has the nice side effect that the
BUG_ON()can be converted into aWARN_ON()as we now can handle registration errors.Quoted 5 lines
Quoted 2 lines
Fixes b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resourceuse
__try_online_node")We should CC stable.
Yeah, that's probably not a bad idea.
Quoted 31 lines
Quoted 31 lines
Signed-off-by Hannes Reinecke <[email protected]>---
drivers/base/memory.c | 19 +++++++++----------include/linux/memory.h| 2 +-
mm/memory_hotplug.c | 32 +++++++++++++++++---------------3 files changed, 27 insertions(+), 26 deletions(-)drivers/base/memory.c +0
-0@@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, mem->zone = early_node_zone_for_memory_block(mem, nid);else
mem->zone= NULL;
+ /*
+ * If this memory block spans multiple nodes, we only indicate + * the last processed node. If we span multiple nodes (not applicable
+ * to hotplugged memory), zone == NULL will prohibit memory offlining
+ * and consequently unplug.
+ */
+mem->nid= nid;
}
-
- /*
- * If this memory block spans multiple nodes, we only indicate - * the last processed node. If we span multiple nodes (not applicableQuoted 9 lines
Quoted 5 lines
- * to hotplugged memory), zone == NULL will prohibit memory offlining
- * and consequently unplug.
- */
-mem->nid= nid;I would not perform this change in this patch. It's not required here, right? We're simply re-setting the nid. Patch #3 can clean that up.
Quoted 6 lines
Well. You tell me :-)
Thing is, we already have a 'nid' value as argument to
add_memory_resource().
So I would _think_ that it should be the same value which we end up with inmemory_block_add_nid().Yes, on the memory hotplug path it should be the same value. Everything else would be really broken.
Quoted 6 lines
But if that's the case we could've set it during memblock initialization, which we don't. So I thought there must be a reason for that, and the only reason I could think of is that 'nid' is not known during memblock initialization, ie that the 'nid' value in
add_memory_resource()is a different 'nid' value from the one used inmemory_block_add_nid().It must be the same. Only for boot memory, we can have multiple nids. And the current behavior is to set
mem->nidto theSo unless I am confused at this point
Quoted 8 lines
1) You can avoid changing this function in this patch. We will reset the same value in case of memory hotplug which ...
2) Will be cleaned up by patch #3, where we simply call the function only for early memory.
Makes sense or is the warm weather affecting my reasoning? :)
That was basically what I had been assuming. Just wanted to have some confirmation. Will be changing it with the next round.
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich