Skip to contentSkip to conversation

nvme-tcp: log TLS handshake failures at error level

PATCH Applied Maurizio Lombardi 4 participants 4 messages Jul 2, 2025 – Jul 3, 2025 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nvme-tcp: log TLS handshake failures at error level

Update the nvme_tcp_start_tls() function to use dev_err() instead of dev_dbg() when a TLS error is detected. This ensures that handshake failures are visible by default, aiding in debugging.

---

v2: Hans suggests to print a dev_dbg() message
if handshake is succesfull

 drivers/nvme/host/tcp.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/nvme/host/tcp.c +8 -3
index d924008c3949..9233f088fac8 100644
@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl,
 			qid, ret);
 		tls_handshake_cancel(queue->sock->sk);
 	} else {
-		dev_dbg(nctrl->device,
-			"queue %d: TLS handshake complete, error %d\n",
-			qid, queue->tls_err);
+		if (queue->tls_err) {
+			dev_err(nctrl->device,
+				"queue %d: TLS handshake complete, error %d\n",
+				qid, queue->tls_err);
+		} else {
+			dev_dbg(nctrl->device,
+				"queue %d: TLS handshake complete\n", qid);
+		}
 		ret = queue->tls_err;
 	}
 	return ret;
Signature · 1 line
2.47.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 26 lines · Maurizio Lombardi

Update the nvme_tcp_start_tls() function to use dev_err() instead of dev_dbg() when a TLS error is detected. This ensures that handshake failures are visible by default, aiding in debugging.

---

v2: Hans suggests to print a dev_dbg() message
if handshake is succesfull

  drivers/nvme/host/tcp.c | 11 ++++++++---
  1 file changed, 8 insertions(+), 3 deletions(-)
drivers/nvme/host/tcp.c +1 -3
index d924008c3949..9233f088fac8 100644
@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl,
  			qid, ret);
  		tls_handshake_cancel(queue->sock->sk);
  	} else {
-		dev_dbg(nctrl->device,
-			"queue %d: TLS handshake complete, error %d\n",
-			qid, queue->tls_err);
+		if (queue->tls_err) {

drivers/nvme/host/tcp.c static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl, · line 1758

Quoted 10 lines
drivers/nvme/host/tcp.c +7 -0
+			dev_err(nctrl->device,
+				"queue %d: TLS handshake complete, error %d\n",
+				qid, queue->tls_err);
+		} else {
+			dev_dbg(nctrl->device,
+				"queue %d: TLS handshake complete\n", qid);
+		}
  		ret = queue->tls_err;
  	}
  	return ret;

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Reviewed-by on v2 1/1
#2 lore raw
In reply to Maurizio Lombardi
Quoted 37 lines · Maurizio Lombardi

Update the nvme_tcp_start_tls() function to use dev_err() instead of dev_dbg() when a TLS error is detected. This ensures that handshake failures are visible by default, aiding in debugging.

---

 v2: Hans suggests to print a dev_dbg() message
     if handshake is succesfull

 drivers/nvme/host/tcp.c | 11 ++++++++---

 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/nvme/host/tcp.c +7 -3
index d924008c3949..9233f088fac8 100644
@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl
 *nctrl,
  			qid, ret);
  		tls_handshake_cancel(queue->sock->sk);
  	} else {
-		dev_dbg(nctrl->device,
-			"queue %d: TLS handshake complete, error
 %d\n",
-			qid, queue->tls_err);
+		if (queue->tls_err) {
+			dev_err(nctrl->device,
+				"queue %d: TLS handshake complete,
 error %d\n",
+				qid, queue->tls_err);
+		} else {
+			dev_dbg(nctrl->device,
+				"queue %d: TLS handshake

complete\n", qid);

drivers/nvme/host/tcp.c +1 -0
+		}
Quoted 3 lines

  ret = queue->tls_err;
  }
  return ret;

V2 Looks good to me
If you need another review here it is