Skip to contentSkip to conversation

ACPI: processor: fix acpi_object initialization

PATCH Applied Sebastian Ott 2 participants 2 messages Jul 3, 2025 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: processor: fix acpi_object initialization

Initialization of the local acpi_object in acpi_processor_get_info() only sets the first 4 bytes to zero and is thus incomplete. This is indicated by messages like:

	acpi ACPI0007:be: Invalid PBLK length [166288104]

Fix this by initializing all 16 bytes of the processor member of that union.

---
 drivers/acpi/acpi_processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_processor.c +1 -1
index 7cf6101cb4c7..2a99f5eb6962 100644
@@ -275,7 +275,7 @@ static inline int acpi_processor_hotadd_init(struct acpi_processor *pr,
 
 static int acpi_processor_get_info(struct acpi_device *device)
 {
-	union acpi_object object = { 0 };
+	union acpi_object object = { .processor = { 0 } };
 	struct acpi_buffer buffer = { sizeof(union acpi_object), &object };
 	struct acpi_processor *pr = acpi_driver_data(device);
 	int device_declaration = 0;
Signature · 1 line
2.50.0
maintainer Applied
#1 lore raw
Quoted 19 lines · Sebastian Ott

Initialization of the local acpi_object in acpi_processor_get_info() only sets the first 4 bytes to zero and is thus incomplete. This is indicated by messages like:

        acpi ACPI0007:be: Invalid PBLK length [166288104]

Fix this by initializing all 16 bytes of the processor member of that union.

---
 drivers/acpi/acpi_processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_processor.c +0 -0
index 7cf6101cb4c7..2a99f5eb6962 100644

drivers/acpi/acpi_processor.c static inline int acpi_processor_hotadd_init(struct acpi_processor *pr,

Quoted 9 lines
drivers/acpi/acpi_processor.c +1 -2
@@ -275,7 +275,7 @@ static inline int acpi_processor_hotadd_init(struct acpi_processor *pr,
 
 static int acpi_processor_get_info(struct acpi_device *device)
 {
-       union acpi_object object = { 0 };
+       union acpi_object object = { .processor = { 0 } };
        struct acpi_buffer buffer = { sizeof(union acpi_object), &object };
        struct acpi_processor *pr = acpi_driver_data(device);
        int device_declaration = 0;
--

Applied as 6.17 material, thanks!