Skip to contentSkip to conversation

firmware: tegra: bpmp: Use of_reserved_mem_region_to_resource() for "memory-region"

PATCH Applied Rob Herring (Arm) 3 participants 4 messages Jul 3, 2025 – Jul 29, 2025 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: tegra: bpmp: Use of_reserved_mem_region_to_resource() for "memory-region"

Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties.

---
 drivers/firmware/tegra/bpmp-tegra186.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/firmware/tegra/bpmp-tegra186.c +2 -7
index 6f0d0511b486..7cfc5fdfa49d 100644
@@ -6,7 +6,7 @@
 #include <linux/genalloc.h>
 #include <linux/io.h>
 #include <linux/mailbox_client.h>
-#include <linux/of_address.h>
+#include <linux/of_reserved_mem.h>
 #include <linux/platform_device.h>
 
 #include <soc/tegra/bpmp.h>
@@ -192,16 +192,11 @@ static void tegra186_bpmp_teardown_channels(struct tegra_bpmp *bpmp)
 static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp)
 {
 	struct tegra186_bpmp *priv = bpmp->priv;
-	struct device_node *np;
 	struct resource res;
 	size_t size;
 	int err;
 
-	np = of_parse_phandle(bpmp->dev->of_node, "memory-region", 0);
-	if (!np)
-		return -ENODEV;
-
-	err = of_address_to_resource(np, 0, &res);
+	err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res);
 	if (err < 0) {
 		dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err);
 		return err;
Signature · 1 line
2.47.2
#1 lore raw

From: Thierry Reding <[email protected]>

Quoted 4 lines · Rob Herring (Arm)

Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties.

Applied, thanks!

[1/1] firmware: tegra: bpmp: Use of_reserved_mem_region_to_resource() for "memory-region"

      commit: dbe4efea38d0a79ed58069499368e08b815952c6

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>
maintainer
#2 lore raw
In reply to Rob Herring (Arm)

Hi Rob, Thierry,

Quoted 29 lines · Rob Herring (Arm)

Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties.

---
  drivers/firmware/tegra/bpmp-tegra186.c | 9 ++-------
  1 file changed, 2 insertions(+), 7 deletions(-)
drivers/firmware/tegra/bpmp-tegra186.c +1 -2
index 6f0d0511b486..7cfc5fdfa49d 100644
@@ -6,7 +6,7 @@
  #include <linux/genalloc.h>
  #include <linux/io.h>
  #include <linux/mailbox_client.h>
-#include <linux/of_address.h>
+#include <linux/of_reserved_mem.h>
  #include <linux/platform_device.h>
 
  #include <soc/tegra/bpmp.h>
@@ -192,16 +192,11 @@ static void tegra186_bpmp_teardown_channels(struct tegra_bpmp *bpmp)
  static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp)
  {
  	struct tegra186_bpmp *priv = bpmp->priv;
-	struct device_node *np;
  	struct resource res;
  	size_t size;
  	int err;

drivers/firmware/tegra/bpmp-tegra186.c static void tegra186_bpmp_teardown_channels(struct tegra_bpmp *bpmp) · line 202

Quoted 10 lines
drivers/firmware/tegra/bpmp-tegra186.c +1 -5
 
-	np = of_parse_phandle(bpmp->dev->of_node, "memory-region", 0);
-	if (!np)
-		return -ENODEV;
-
-	err = of_address_to_resource(np, 0, &res);
+	err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res);
  	if (err < 0) {
  		dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err);
  		return err;

This change is now causing the following warning to be observed on Tegra194 Jetson AGX Xavier platform ...

WARNING KERN tegra-bpmp bpmp: failed to parse memory region: -19

Looking at the binding only one of 'memory-region' or 'shmem' is required and for Tegra194 we are using shmem. So I am not sure if it is worth making this change for this driver.

Jon

Signature · 1 line
nvpublic
#3 lore raw
Quoted 45 lines · Jon Hunter

Hi Rob, Thierry,

Quoted 27 lines · Rob Herring (Arm)

Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties.

---
  drivers/firmware/tegra/bpmp-tegra186.c | 9 ++-------
  1 file changed, 2 insertions(+), 7 deletions(-)
drivers/firmware/tegra/bpmp-tegra186.c +1 -2
index 6f0d0511b486..7cfc5fdfa49d 100644
@@ -6,7 +6,7 @@
  #include <linux/genalloc.h>
  #include <linux/io.h>
  #include <linux/mailbox_client.h>
-#include <linux/of_address.h>
+#include <linux/of_reserved_mem.h>
  #include <linux/platform_device.h>
  #include <soc/tegra/bpmp.h>
@@ -192,16 +192,11 @@ static void tegra186_bpmp_teardown_channels(struct tegra_bpmp *bpmp)
  static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp)
  {
  	struct tegra186_bpmp *priv = bpmp->priv;
-	struct device_node *np;
  	struct resource res;
  	size_t size;

drivers/firmware/tegra/bpmp-tegra186.c static void tegra186_bpmp_teardown_channels(struct tegra_bpmp *bpmp) · line 201

Quoted 10 lines
drivers/firmware/tegra/bpmp-tegra186.c +1 -5
  	int err;
-	np = of_parse_phandle(bpmp->dev->of_node, "memory-region", 0);
-	if (!np)
-		return -ENODEV;
-
-	err = of_address_to_resource(np, 0, &res);
+	err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res);
  	if (err < 0) {
  		dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err);
  		return err;

This change is now causing the following warning to be observed on Tegra194 Jetson AGX Xavier platform ...

Quoted 5 lines

WARNING KERN tegra-bpmp bpmp: failed to parse memory region: -19

Looking at the binding only one of 'memory-region' or 'shmem' is required and for Tegra194 we are using shmem. So I am not sure if it is worth making this change for this driver.

I guess the change still makes sense for merging both calls into one but we now need to check for -ENODEV and not warn about it for this to remain really equivalent.

I can patch it up.

Thierry