tcp: update the comment for tcp_process_tlp_ack()
Subsystems (3)
PATCH 1/1 tcp: update the comment for tcp_process_tlp_ack()
As ACK-TLP was published as a standards-track RFC8985, so the comment for tcp_process_tlp_ack() is outdated.
--- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/tcp_input.c +1 -1
@@ -3714,7 +3714,7 @@ static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq) }/* This routine deals with acks during a TLP episode and ends an episode by -* resetting tlp_high_seq. Ref: TLP algorithm in draft-ietf-tcpm-rack +* resetting tlp_high_seq. Ref: TLP algorithm in RFC8985 */ static void tcp_process_tlp_ack (struct sock *sk,u32 ack,int flag) {
Signature · 1 line
2.43.0
Neal Cardwell
maintainerQuoted 2 lines · xin.guo
As ACK-TLP was published as a standards-track RFC8985,
nit: typo: s/ACK-TLP/RACK-TLP/
Quoted 12 lines
so the comment for
tcp_process_tlp_ack()is outdated.Signed-off-by xin.guo <[email protected]>--- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/ipv4/tcp_input.c +0
-0
net/ipv4/tcp_input.c static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq) · line 3717
Quoted 5 lines
net/ipv4/tcp_input.c +1
-1@@ -3714,7 +3714,7 @@ static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq) }/* This routine deals with acks during a TLP episode and ends an episode by -* resetting tlp_high_seq. Ref: TLP algorithm in draft-ietf-tcpm-rack +* resetting tlp_high_seq. Ref: TLP algorithm in RFC8985
Thanks for updating this! This looks good, but in net-next at 6b9fd8857b9fc I see two other outdated references to draft-ietf-tcpm-rack. Can you please fix the other two as well:
git grep -n draft-ietf-tcpm-rack 6b9fd8857b9fc
6b9fd8857b9fc:Documentation/networking/ip-sysctl.rst:434: losses
into fast recovery (draft-ietf-tcpm-rack). Note that
6b9fd8857b9fc:net/ipv4/tcp_input.c:3717: * resetting tlp_high_seq.
Ref: TLP algorithm in draft-ietf-tcpm-rack
6b9fd8857b9fc:net/ipv4/tcp_recovery.c:38:/* RACK loss detection (IETF draft draft-ietf-tcpm-rack-01):
thanks,
neal
thanks neal, I will send v2 to include the other outdated references.
Regards
Guo Xin
Quoted 42 lines · Neal Cardwell
Quoted 2 lines · xin.guo
As ACK-TLP was published as a standards-track RFC8985,
nit: typo: s/ACK-TLP/RACK-TLP/
Quoted 12 lines
so the comment for
tcp_process_tlp_ack()is outdated.Signed-off-by xin.guo <[email protected]>--- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/ipv4/tcp_input.c +0
-0net/ipv4/tcp_input.c static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq) · line 3717
Quoted 5 lines
net/ipv4/tcp_input.c +1
-1@@ -3714,7 +3714,7 @@ static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq) }/* This routine deals with acks during a TLP episode and ends an episode by -* resetting tlp_high_seq. Ref: TLP algorithm in draft-ietf-tcpm-rack +* resetting tlp_high_seq. Ref: TLP algorithm in RFC8985 Thanks for updating this! This looks good, but in net-next at
6b9fd8857b9fcI see two other outdated references to draft-ietf-tcpm-rack. Can you please fix the other two as well:git grep -n draft-ietf-tcpm-rack
6b9fd8857b9fc6b9fd8857b9fc:Documentation/networking/ip-sysctl.rst:434: losses
into fast recovery (draft-ietf-tcpm-rack). Note that6b9fd8857b9fc:net/ipv4/tcp_input.c:3717: * resetting
tlp_high_seq.
Ref: TLP algorithm in draft-ietf-tcpm-rack6b9fd8857b9fc:net/ipv4/tcp_recovery.c:38:/* RACK loss detection (IETF draft draft-ietf-tcpm-rack-01):
thanks,
neal