RDMA/efa: Add Network HW statistics counters
Subsystems (2)
Michael Margolin
maintainerPATCH 1/1 RDMA/efa: Add Network HW statistics counters
From: Basel Nassar <[email protected]>
Update device API and request network counters. Expose newly added counters through ib core counters mechanism.
Reviewed-by David Shoolman <[email protected]>
Reviewed-by Yonatan Nachum <[email protected]>
Signed-off-by Basel Nassar <[email protected]>
Signed-off-by Michael Margolin <[email protected]>
--- .../infiniband/hw/efa/efa_admin_cmds_defs.h | 17 +++++- drivers/infiniband/hw/efa/efa_com_cmd.c | 53 ++++++++++++------- drivers/infiniband/hw/efa/efa_com_cmd.h | 11 +++- drivers/infiniband/hw/efa/efa_verbs.c | 18 +++++++ 4 files changed, 79 insertions(+), 20 deletions(-)
drivers/infiniband/hw/efa/efa_admin_cmds_defs.h +16 -1
@@ -1,6 +1,6 @@/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* -* Copyright 2018-2024 Amazon.com, Inc. or its affiliates. All rights reserved. +* Copyright 2018-2025 Amazon.com, Inc. or its affiliates. All rights reserved. */ #ifndef _EFA_ADMIN_CMDS_H_
@@ -68,6 +68,7 @@ enum efa_admin_get_stats_type {EFA_ADMIN_GET_STATS_TYPE_MESSAGES =1 ,EFA_ADMIN_GET_STATS_TYPE_RDMA_READ =2 ,EFA_ADMIN_GET_STATS_TYPE_RDMA_WRITE =3 , + EFA_ADMIN_GET_STATS_TYPE_NETWORK = 4, }; enum efa_admin_get_stats_scope {
@@ -651,6 +652,18 @@ struct efa_admin_rdma_write_stats {u64 write_recv_bytes; }; +struct efa_admin_network_stats { +u64 retrans_bytes; + +u64 retrans_pkts; + +u64 retrans_timeout_events; + +u64 unresponsive_remote_events; + +u64 impaired_remote_conn_events; +}; +struct efa_admin_acq_get_stats_resp {struct efa_admin_acq_common_desc acq_common_desc;
@@ -662,6 +675,8 @@ struct efa_admin_acq_get_stats_resp {struct efa_admin_rdma_read_stats rdma_read_stats;struct efa_admin_rdma_write_stats rdma_write_stats; + +struct efa_admin_network_stats network_stats; } u; };
drivers/infiniband/hw/efa/efa_com_cmd.c +35 -18
76 lines not on this page · raw message
drivers/infiniband/hw/efa/efa_com_cmd.h +10 -1
@@ -1,6 +1,6 @@/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* -* Copyright 2018-2024 Amazon.com, Inc. or its affiliates. All rights reserved. +* Copyright 2018-2025 Amazon.com, Inc. or its affiliates. All rights reserved. */ #ifndef _EFA_COM_CMD_H_
@@ -283,11 +283,20 @@ struct efa_com_rdma_write_stats {u64 write_recv_bytes; }; +struct efa_com_network_stats { +u64 retrans_bytes; +u64 retrans_pkts; +u64 retrans_timeout_events; +u64 unresponsive_remote_events; +u64 impaired_remote_conn_events; +}; +union efa_com_get_stats_result {struct efa_com_basic_stats basic_stats;struct efa_com_messages_stats messages_stats;struct efa_com_rdma_read_stats rdma_read_stats;struct efa_com_rdma_write_stats rdma_write_stats; +struct efa_com_network_stats network_stats; }; int efa_com_create_qp(struct efa_com_dev *edev,
drivers/infiniband/hw/efa/efa_verbs.c +18 -0
@@ -64,6 +64,11 @@ struct efa_user_mmap_entry { op(EFA_RDMA_WRITE_BYTES, "rdma_write_bytes") \ op(EFA_RDMA_WRITE_WR_ERR, "rdma_write_wr_err") \ op(EFA_RDMA_WRITE_RECV_BYTES, "rdma_write_recv_bytes") \ + op(EFA_RETRANS_BYTES, "retrans_bytes") \ + op(EFA_RETRANS_PKTS, "retrans_pkts") \ + op(EFA_RETRANS_TIMEOUT_EVENS, "retrans_timeout_events") \ + op(EFA_UNRESPONSIVE_REMOTE_EVENTS, "unresponsive_remote_events") \ + op(EFA_IMPAIRED_REMOTE_CONN_EVENTS, "impaired_remote_conn_events") \#define EFA_STATS_ENUM (ename, name) ename,#define EFA_STATS_STR (ename, nam) \
@@ -2186,6 +2191,7 @@ static int efa_fill_port_stats(struct efa_dev *dev, struct rdma_hw_stats *stats,struct efa_com_rdma_write_stats *rws;struct efa_com_rdma_read_stats *rrs;struct efa_com_messages_stats *ms; +struct efa_com_network_stats *ns;struct efa_com_basic_stats *bs;int err;
@@ -2238,6 +2244,18 @@ static int efa_fill_port_stats(struct efa_dev *dev, struct rdma_hw_stats *stats, stats->value[EFA_RDMA_WRITE_RECV_BYTES ] = rws->write_recv_bytes; } + params.type =EFA_ADMIN_GET_STATS_TYPE_NETWORK ; + err =efa_com_get_stats (&dev->edev, ¶ms, &result); +if (err) +return err; + + ns = &result.network_stats; + stats->value[EFA_RETRANS_BYTES ] = ns->retrans_bytes; + stats->value[EFA_RETRANS_PKTS ] = ns->retrans_pkts; + stats->value[EFA_RETRANS_TIMEOUT_EVENS ] = ns->retrans_timeout_events; + stats->value[EFA_UNRESPONSIVE_REMOTE_EVENTS ] = ns->unresponsive_remote_events; + stats->value[EFA_IMPAIRED_REMOTE_CONN_EVENTS ] = ns->impaired_remote_conn_events; +return ARRAY_SIZE (efa_port_stats_descs); }
Signature · 1 line
2.47.1
Leon Romanovsky
AppliedQuoted 4 lines · Michael Margolin
Update device API and request network counters. Expose newly added counters through ib core counters mechanism.
Applied, thanks!
[1/1] RDMA/efa: Add Network HW statistics counters
https://git.kernel.org/rdma/rdma/c/475ac071bade37
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>