Skip to contentSkip to conversation

x86/sev: Replace memset(0) and kfree() with kfree_sensitive()

PATCH In review Thorsten Blum 2 participants 2 messages Jul 6, 2025 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/sev: Replace memset(0) and kfree() with kfree_sensitive()

Replace memset(0) followed by kfree() with kfree_sensitive() to improve snp_msg_free() and silence the following Coccinelle/coccicheck warning reported by kfree_sensitive.cocci:

WARNING opportunity for kfree_sensitive/kvfree_sensitive

No functional changes intended.

---
 arch/x86/coco/sev/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/x86/coco/sev/core.c +1 -2
index b6db4e0b936b..4bc8423cfd79 100644
@@ -1768,8 +1768,7 @@ void snp_msg_free(struct snp_msg_desc *mdesc)
 	free_shared_pages(mdesc->request, sizeof(struct snp_guest_msg));
 	iounmap((__force void __iomem *)mdesc->secrets);
 
-	memset(mdesc, 0, sizeof(*mdesc));
-	kfree(mdesc);
+	kfree_sensitive(mdesc);
 }
 EXPORT_SYMBOL_GPL(snp_msg_free);
 
Signature · 1 line
2.50.0
maintainer
#1 lore raw
Quoted 2 lines · Thorsten Blum

Replace memset(0) followed by kfree() with kfree_sensitive() to improve snp_msg_free()

Improve how?

Quoted 2 lines

and silence the following Coccinelle/coccicheck warning reported by kfree_sensitive.cocci:

We don't do patches just to silence tools.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette