ASPEED OTP QEMU model: block backend, machine alias, SoC integration
Subsystems (2)
v4 cover ASPEED OTP QEMU model: block backend, machine alias, SoC integration
From: Kane-Chen-AS <[email protected]>
This patch series extends the QEMU model for the ASPEED OTP (One-Time Programmable) memory device with block backend support and tighter integration with the SoC and machine configuration.
The OTP model simulates a simple fuse array, used in ASPEED SoCs for secure boot and configuration purposes. The updated model now supports loading initial OTP content from a file via the QEMU CLI.
Example usage:
./qemu-system-arm \
-machine ast2600-evb,otpmem=otp \
-blockdev driver=file,filename=otpmem.img,node-name=otp \
-global aspeed-otp.drive=otp \
...ChangeLog
---------
v4:
- Add a 'drive' property to allow backing OTP data with a block device
- Expose a machine parameter (-machine otpmem=XXX) for convenient aliasing of the OTP drive via QOM path
v3:
- Switched to object_property_set_int() for setting "size"
- Simplified qdev_realize() error handling by passing errp directly
- Added "drive" property to OTP model for future extensibility
v2:
- Rename device from 'aspeed_otpmem' to 'aspeed_otp' and move it to hw/nvram/
- Move OTP device realization from instance_init to the realize function
- Improve error logging with qemu_log_mask() and remove unused error propagation
v1:
- Initial version
---
Kane-Chen-AS (5):
hw/misc/aspeed_otp: Add ASPEED OTP memory device model hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs hw/misc/aspeed_otp: Add 'drive' property to support block backend hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive property
include/hw/misc/aspeed_sbc.h | 5 ++ include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/arm/aspeed.c | 20 ++++++ hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 121 ++++++++++++++++++++++++++++++++++ hw/nvram/aspeed_otp.c | 113 +++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ hw/nvram/meson.build | 4 ++ 8 files changed, 302 insertions(+), 1 deletion(-) create mode 100644 include/hw/nvram/aspeed_otp.h create mode 100644 hw/nvram/aspeed_otp.c
Signature · 1 line
2.43.0
PATCH v4 1/5 hw/misc/aspeed_otp: Add ASPEED OTP memory device model
From: Kane-Chen-AS <[email protected]>
Introduce a QEMU device model for ASPEED's One-Time Programmable (OTP) memory.
This model simulates a word-addressable OTP region used for secure fuse storage. The OTP memory can operate with an internal memory buffer.
The OTP model provides a memory-like interface through a dedicated AddressSpace, allowing other device models (e.g., SBC) to issue transactions as if accessing a memory-mapped region.
--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++++ hw/nvram/aspeed_otp.c | 99 +++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 136 insertions(+) create mode 100644 include/hw/nvram/aspeed_otp.h create mode 100644 hw/nvram/aspeed_otp.c
include/hw/nvram/aspeed_otp.h new file +33 -0
@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed-otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */
hw/nvram/aspeed_otp.c new file +99 -0
99 lines not on this page · raw message
hw/nvram/meson.build +4 -0
@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
Signature · 1 line
2.43.0
Re: [SPAM] [PATCH v4 1/5] hw/misc/aspeed_otp: Add ASPEED OTP memory device model
Quoted 9 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
Introduce a QEMU device model for ASPEED's One-Time Programmable (OTP) memory.
This model simulates a word-addressable OTP region used for secure fuse storage. The OTP memory can operate with an internal memory buffer.
Quoted 5 lines
The OTP model provides a memory-like interface through a dedicated AddressSpace, allowing other device models (e.g., SBC) to issue transactions as if accessing a memory-mapped region.
Signed-off-by Kane-Chen-AS <[email protected]>
Thanks,
C.
Quoted 165 lines
--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++++ hw/nvram/aspeed_otp.c | 99 +++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 136 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.cinclude/hw/nvram/aspeed_otp.h new file +33
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed-otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file +99
-0@@ -0,0 +1,99 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-io.h" +#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned size) +{ +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) +{ +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); +} + +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; + + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) +{ +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); +} + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +}; + +static void aspeed_otp_class_init (ObjectClass *klass,const void *data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); +} + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) +{ +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build +4
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
Re: [SPAM] [PATCH v4 1/5] hw/misc/aspeed_otp: Add ASPEED OTP memory device model
In reply to Kane Chen viaQuoted 69 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
Introduce a QEMU device model for ASPEED's One-Time Programmable (OTP) memory.
This model simulates a word-addressable OTP region used for secure fuse storage. The OTP memory can operate with an internal memory buffer.
The OTP model provides a memory-like interface through a dedicated AddressSpace, allowing other device models (e.g., SBC) to issue transactions as if accessing a memory-mapped region.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++++ hw/nvram/aspeed_otp.c | 99 +++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 136 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.cinclude/hw/nvram/aspeed_otp.h new file +33
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed-otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file +2
-0@@ -0,0 +1,99 @@ +/* +* ASPEED OTP (One-Time Programmable) memory
hw/nvram/aspeed_otp.c line 12
Quoted 10 lines
hw/nvram/aspeed_otp.c new file +10
-0+* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-io.h"
Please replace with :
#include "system/block-backend.h"
Thanks,
C.
Quoted 100 lines
hw/nvram/aspeed_otp.c new file +87
-0+#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned size) +{ +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) +{ +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); +} + +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; + + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) +{ +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); +} + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +}; + +static void aspeed_otp_class_init (ObjectClass *klass,const void *data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); +} + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) +{ +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build +4
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
RE: [SPAM] [PATCH v4 1/5] hw/misc/aspeed_otp: Add ASPEED OTP memory device model
Hi Cédric,
Thanks for the feedback.
I will update the code accordingly in the next version of the patch series.
Best Regards,
Kane
Quoted 200 lines
-----Original Message-----
From: Cédric Le Goater <[email protected]>
Sent: Tuesday, July 22, 2025 5:55 PM
To: Kane Chen <[email protected]>; Peter Maydell <[email protected]>; Steven Lee <[email protected]>; Troy Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew Jeffery <[email protected]>; Joel Stanley <[email protected]>; open list:ASPEED BMCs <[email protected]>; open list:All patches CC here <[email protected]>
Cc: Troy Lee <[email protected]>
Subject: Re: [SPAM] [PATCH v4 1/5] hw/misc/aspeed_otp: Add ASPEED OTP memory device modelQuoted 3 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
Introduce a QEMU device model for ASPEED's One-Time Programmable
(OTP)
Quoted 6 lines
memory.
This model simulates a word-addressable OTP region used for secure fuse storage. The OTP memory can operate with an internal memory buffer.
Quoted 8 lines
The OTP model provides a memory-like interface through a dedicated AddressSpace, allowing other device models (e.g., SBC) to issue transactions as if accessing a memory-mapped region.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++++ hw/nvram/aspeed_otp.c | 99+++++++++++++++++++++++++++++++++++
Quoted 49 lines
hw/nvram/meson.build | 4 ++ 3 files changed, 136 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.c(quoted diff) +0
-0
b/include/hw/nvram/aspeed_otp.hnew file mode 100644 index 0000000000..3752353860include/hw/nvram/aspeed_otp.h new file +32
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed-otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file renamed from hw/nvram/aspeed_otp.c +0
-0mode 100644 index 0000000000..e41481d9bb
hw/nvram/aspeed_otp.c new file +1
-0@@ -0,0 +1,99 @@ +/* hw/nvram/aspeed_otp.c line 11
Quoted 10 lines
hw/nvram/aspeed_otp.c new file +10
-0+* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-io.h" Please replace with :
#include "
system/block-backend.h"Thanks,
C.
hw/nvram/meson.build system_ss.add(when: 'CONFIG_XLNX_BBRAM',
Quoted 85 lines
hw/nvram/aspeed_otp.c new file +80
-0+#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned +size) { +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) { +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); } + +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; + + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) { +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); } + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), }; + +static void aspeed_otp_class_init (ObjectClass *klass,const void +*data) { +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); } + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) { +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build index renamed from hw/nvram/meson.build +0
-0
10f3639db6..b66f23605b100644hw/nvram/meson.build +0
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM',
if_true:Quoted 10 lines
hw/nvram/meson.build +0
-0files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true:
files('fw_cfg-acpi.c'))hw/nvram/meson.build +4
-0+ +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
PATCH v4 2/5 hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
This patch connects the aspeed.otp device to the ASPEED Secure Boot Controller (SBC) model. It implements OTP memory access via the SBC's command interface and enables emulation of secure fuse programming flows.
The following OTP commands are supported:
- READ: reads a 32-bit word from OTP memory into internal registers
- PROG: programs a 32-bit word value to the specified OTP address
Trace events are added to observe read/program operations and command handling flow.
--- include/hw/misc/aspeed_sbc.h | 5 ++ hw/misc/aspeed_sbc.c | 111 +++++++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ 3 files changed, 121 insertions(+)
include/hw/misc/aspeed_sbc.h +5 -0
@@ -10,6 +10,7 @@#define ASPEED_SBC_H #include "hw/sysbus.h" +#include "hw/nvram/aspeed_otp.h" #define TYPE_ASPEED_SBC "aspeed.sbc"#define TYPE_ASPEED_AST2600_SBC TYPE_ASPEED_SBC "-ast2600"
@@ -36,10 +37,14 @@ struct AspeedSBCState {MemoryRegion iomem;uint32_t regs[ASPEED_SBC_NR_REGS ]; + + AspeedOTPState otp; };struct AspeedSBCClass {SysBusDeviceClass parent_class; + +bool has_otp; };#endif /* ASPEED_SBC_H */
hw/misc/aspeed_sbc.c +111 -0
154 lines not on this page · raw message
hw/misc/trace-events +5 -0
@@ -90,6 +90,11 @@ slavio_sysctrl_mem_readl(uint32_t ret) "Read system control 0x%08x" slavio_led_mem_writew(uint32_t val) "Write diagnostic LED 0x%04x" slavio_led_mem_readw(uint32_t ret) "Read diagnostic LED 0x%04x" +# aspeed_sbc.c +aspeed_sbc_handle_cmd(uint32_t cmd, uint32_t addr, bool ret) "Handling command 0x%" PRIx32 " for OTP addr 0x%" PRIx32 " Result: %d" +aspeed_sbc_otp_read(uint32_t addr, uint32_t value) "OTP Memory read: addr 0x%" PRIx32 " value 0x%" PRIx32 +aspeed_sbc_otp_prog(uint32_t addr, uint32_t value) "OTP Memory write: addr 0x%" PRIx32 " value 0x%" PRIx32 + # aspeed_scu.c aspeed_scu_write(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32 aspeed_scu_read(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32
Signature · 1 line
2.43.0
PATCH v4 3/5 hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
The has_otpmem attribute is enabled in the SBC subclasses for AST2600 to control the presence of OTP support per SoC type.
--- hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
hw/arm/aspeed_ast2600.c +1 -1
@@ -261,7 +261,7 @@ static void aspeed_soc_ast2600_init(Object *obj)object_initialize_child (obj,"i3c" , &s->i3c,TYPE_ASPEED_I3C ); -object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_SBC ); +object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_AST2600_SBC );object_initialize_child (obj,"iomem" , &s->iomem,TYPE_UNIMPLEMENTED_DEVICE );object_initialize_child (obj,"video" , &s->video,TYPE_UNIMPLEMENTED_DEVICE );
hw/misc/aspeed_sbc.c +2 -0
@@ -273,8 +273,10 @@ static const TypeInfo aspeed_sbc_info = {static void aspeed_ast2600_sbc_class_init (ObjectClass *klass,const void *data) {DeviceClass *dc =DEVICE_CLASS (klass); +AspeedSBCClass *sc =ASPEED_SBC_CLASS (klass); dc->desc ="AST2600 Secure Boot Controller" ; + sc->has_otp = true; }static const TypeInfo aspeed_ast2600_sbc_info = {
Signature · 1 line
2.43.0
PATCH v4 4/5 hw/misc/aspeed_otp: Add 'drive' property to support block backend
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
This patch introduces a 'drive' property to the Aspeed OTP device, allowing it to be backed by a block device. Users can now preload OTP data via QEMU CLI using a block backend.
Example usage:
./qemu-system-arm \
-blockdev driver=file,filename=otpmem.img,node-name=otp \
-global aspeed-otp.drive=otp \
...If the drive is provided, its content will be loaded as the initial OTP state. Otherwise, an internal memory buffer will be used.
--- hw/nvram/aspeed_otp.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
hw/nvram/aspeed_otp.c +15 -1
@@ -9,6 +9,7 @@#include "qemu/osdep.h" #include "qemu/log.h" #include "qapi/error.h" +#include "system/block-backend-global-state.h" #include "system/block-backend-io.h" #include "hw/qdev-properties.h" #include "hw/nvram/aspeed_otp.h"
@@ -35,13 +36,25 @@ static bool aspeed_otp_init_storage(AspeedOTPState *s, Error **errp) {uint32_t *p;int i, num; +uint64_t perm; +if (s->blk) { + perm =BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm (s->blk) ?BLK_PERM_WRITE :0 ); +if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { num = s->size /sizeof (uint32_t ); p = (uint32_t *)s->storage;for (i =0 ; i < num; i++) { p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; } - + }return true; }
@@ -75,6 +88,7 @@ static void aspeed_otp_realize(DeviceState *dev, Error **errp)static const Property aspeed_otp_properties[] = {DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), };static void aspeed_otp_class_init (ObjectClass *klass,const void *data)
Signature · 1 line
2.43.0
Re: [SPAM] [PATCH v4 4/5] hw/misc/aspeed_otp: Add 'drive' property to support block backend
Quoted 12 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a 'drive' property to the Aspeed OTP device, allowing it to be backed by a block device. Users can now preload OTP data via QEMU CLI using a block backend.
Example usage:
./qemu-system-arm \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...
Quoted 4 lines
If the drive is provided, its content will be loaded as the initial OTP state. Otherwise, an internal memory buffer will be used.
Signed-off-by Kane-Chen-AS <[email protected]>
Thanks,
C.
Quoted 51 lines
--- hw/nvram/aspeed_otp.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)hw/nvram/aspeed_otp.c +15
-1@@ -9,6 +9,7 @@#include "qemu/osdep.h" #include "qemu/log.h" #include "qapi/error.h" +#include "system/block-backend-global-state.h" #include "system/block-backend-io.h" #include "hw/qdev-properties.h" #include "hw/nvram/aspeed_otp.h" @@ -35,13 +36,25 @@ static bool aspeed_otp_init_storage(AspeedOTPState *s, Error **errp) {uint32_t *p;int i, num; +uint64_t perm; +if (s->blk) { + perm =BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm (s->blk) ?BLK_PERM_WRITE :0 ); +if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { num = s->size /sizeof (uint32_t ); p = (uint32_t *)s->storage;for (i =0 ; i < num; i++) { p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; } - + }return true; }@@ -75,6 +88,7 @@ static void aspeed_otp_realize(DeviceState *dev, Error **errp)static const Property aspeed_otp_properties[] = {DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), };static void aspeed_otp_class_init (ObjectClass *klass,const void *data)
Re: [SPAM] [PATCH v4 4/5] hw/misc/aspeed_otp: Add 'drive' property to support block backend
Quoted 16 lines · Cédric Le Goater
Quoted 5 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a 'drive' property to the Aspeed OTP device, allowing it to be backed by a block device. Users can now preload OTP data via QEMU CLI using a block backend.
Example usage:Quoted 8 lines
./qemu-system-arm \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...If the drive is provided, its content will be loaded as the initial OTP state.
Otherwise, an internal memory buffer will be used.Signed-off-by Kane-Chen-AS <[email protected]>
Quoted 1 line
Reviewed-by Cédric Le Goater <[email protected]>
Erm where is this email getting tagged as SPAM? The headers seem to indicate its clear:
X-Spam_score_int: -39
X-Spam_score: -4.0
X-Spam_bar: ----
X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9,
HEADER_FROM_DIFFERENT_DOMAINS=0.157, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: [email protected]
X-Mailman-Version: 2.1.29
Quoted 54 lines
Thanks,
C.
Quoted 48 lines
--- hw/nvram/aspeed_otp.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)hw/nvram/aspeed_otp.c +13
-1@@ -9,6 +9,7 @@#include "qemu/osdep.h" #include "qemu/log.h" #include "qapi/error.h" +#include "system/block-backend-global-state.h" #include "system/block-backend-io.h" #include "hw/qdev-properties.h" #include "hw/nvram/aspeed_otp.h" @@ -35,13 +36,25 @@ static bool aspeed_otp_init_storage(AspeedOTPState *s, Error **errp) {uint32_t *p;int i, num; +uint64_t perm; + if (s->blk) { + perm =BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm (s->blk) ?BLK_PERM_WRITE :0 ); +if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + } else { num = s->size /sizeof (uint32_t ); p = (uint32_t *)s->storage;for (i =0 ; i < num; i++) { p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; } - + }return true; } @@ -75,6 +88,7 @@ static void aspeed_otp_realize(DeviceState *dev,Error **errp)
static const Property aspeed_otp_properties[] = {
DEFINE_PROP_UINT64("size", AspeedOTPState, size, 0),
+DEFINE_PROP_DRIVE("drive", AspeedOTPState, blk),
};
static void aspeed_otp_class_init(ObjectClass *klass, const void
*data)
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
Re: [SPAM] [PATCH v4 4/5] hw/misc/aspeed_otp: Add 'drive' property to support block backend
Quoted 23 lines · Alex Bennée
Quoted 16 lines · Cédric Le Goater
Quoted 5 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a 'drive' property to the Aspeed OTP device, allowing it to be backed by a block device. Users can now preload OTP data via QEMU CLI using a block backend.
Example usage:Quoted 8 lines
./qemu-system-arm \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...If the drive is provided, its content will be loaded as the initial OTP state.
Otherwise, an internal memory buffer will be used.Signed-off-by Kane-Chen-AS <[email protected]>Quoted 1 line
Reviewed-by Cédric Le Goater <[email protected]>Erm where is this email getting tagged as SPAM? The headers seem to indicate its clear:
Quoted 9 lines
X-Spam_score_int: -39
X-Spam_score: -4.0
X-Spam_bar: ----
X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9,
HEADER_FROM_DIFFERENT_DOMAINS=0.157, RCVD_IN_DNSWL_MED=-2.3,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: [email protected]
X-Mailman-Version: 2.1.29I guess it's my provider (OVH). See below what I received.
C.
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Received: from DAG8EX1.mxp5.local (172.16.2.71) by DAG8EX2.mxp5.local
(172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44 via Mailbox Transport; Tue, 8 Jul 2025 07:58:23 +0200
Received: from DAG9EX2.mxp5.local (172.16.2.82) by DAG8EX1.mxp5.local
(172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 8 Jul 2025 07:58:23 +0200
Received: from output47.mail.ovh.net (164.132.34.47) by mxplan5.mail.ovh.net
(172.16.2.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44 via Frontend Transport; Tue, 8 Jul 2025 07:58:23 +0200
Received: from vr27.mail.ovh.net (unknown [10.101.8.27])
by out47.mail.ovh.net (Postfix) with ESMTP id 4bbr4v1fkDz1K9FR for <[email protected]>; Tue, 8 Jul 2025 05:58:23 +0000 (UTC) Received: from in79.mail.ovh.net (unknown [10.101.4.79]) by vr27.mail.ovh.net (Postfix) with ESMTP id 4bbr4t0F45zFpd7 for <[email protected]>; Tue, 8 Jul 2025 05:58:22 +0000 (UTC) Received: from TWMBX01.aspeed.com (mail.aspeedtech.com [211.20.114.72]) by in79.mail.ovh.net (Postfix) with ESMTPS id 4bbr4s4RcFz6dtBC for <[email protected]>; Tue, 8 Jul 2025 05:58:21 +0000 (UTC) Authentication-Results: mx.mail.ovh.net; arc=none (no signatures found); dkim=none (no signatures found); dmarc=pass policy.published-domain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=aspeedtech.com; spf=pass [email protected] smtp.helo=TWMBX01.aspeed.com; x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256
Received-SPF: Fail (DAG8EX1.mxp5.local: domain of [email protected]
does not designate 164.132.34.47 as permitted sender) receiver=DAG8EX1.mxp5.local; client-ip=164.132.34.47; helo=output47.mail.ovh.net;
Received-SPF: pass
(aspeedtech.com: 211.20.114.72 is authorized to use '[email protected]' in 'mfrom' identity (mechanism 'ip4:211.20.114.72' matched)) receiver=in79.mail.ovh.net; identity=mailfrom; envelope-from="[email protected]"; helo=TWMBX01.aspeed.com; client-ip=211.20.114.72
Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com
(192.168.0.62) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Tue, 8 Jul
2025 13:58:10 +0800
Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com
(192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend
Transport; Tue, 8 Jul 2025 13:58:10 +0800
From: Kane Chen <[email protected]>
To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <[email protected]>, Peter Maydell
<[email protected]>, Steven Lee <[email protected]>, Troy Lee
<[email protected]>, Jamin Lin <[email protected]>, Andrew Jeffery
<[email protected]>, Joel Stanley <[email protected]>, "open
list:ASPEED BMCs" <[email protected]>, "open list:All patches CC here"
<[email protected]>
CC: <[email protected]>, Kane-Chen-AS <[email protected]>
Subject: [SPAM] [PATCH v4 0/5] ASPEED OTP QEMU model: block backend, machine alias, SoC integration
Date: Tue, 8 Jul 2025 13:57:52 +0800
Message-ID: <[email protected]>
X-Mailer: git-send-email 2.43.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-OVH-Remote: 211.20.114.72 (mail.aspeedtech.com)
X-Ovh-Tracer-Id: 12933493708818734458
X-VR-SPAMSTATE: SPAM
X-VR-SPAMSCORE: 200
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeffeeklecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftddtmdenucfjughrpefhvfevufffkffoggfgtgesthekredtredttdenucfhrhhomhepmfgrnhgvucevhhgvnhcuoehkrghnvggptghhvghnsegrshhpvggvughtvggthhdrtghomheqnecuggftrfgrthhtvghrnhepgeeggfdvuddtgfegkefhudetjefftdefkefhhedtkeekffegveehgfeiheevvefhnecukfhppedvuddurddvtddruddugedrjedvnecuufhprghmkfhppedvuddurddvtddruddugedrjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdduuddrvddtrdduudegrdejvddphhgvlhhopehtfihmsgigtddurdgrshhpvggvugdrtghomhdpmhgrihhlfhhrohhmpehkrghnvggptghhvghnsegrshhpvggvughtvggthhdrtghomhdpnhgspghrtghpthhtohepuddprhgtphhtthhopegtlhhgsehkrghougdrohhrghdpoffvtefjohhsthepvhhrvdejmgdpughkihhmpehnohhnvggmpdhsphhfpehprghsshgmpdgumhgrrhgtpehprghsshgmpdhrvghvkffrpehmrghilhdrrghsphgvvgguthgvtghhrdgtohhmmgdpghgvohfkrfepvfgh
X-Ovh-Spam-Status: SPAM
X-Ovh-Spam-Reason: vr: SPAM; dkim: disabled; spf: disabled
X-Ovh-Message-Type: SPAM
X-Ovh-Exchange-Junk: True
X-Spam-Tag: YES
Return-Path: [email protected]
X-MS-Exchange-Organization-Network-Message-Id: 126a28f3-a563-4c49-b5da-08ddbde472e1
X-MS-Exchange-Organization-PRD: aspeedtech.com
X-MS-Exchange-Organization-SenderIdResult: Fail
X-MS-Exchange-Organization-AVStamp-Enterprise: 1.0
X-MS-Exchange-ABP-GUID: bd2a0b77-ce4f-4d81-a151-b15427a5e809
X-Ovh-Tracer-GUID: 51d3ce0b-f2d1-4f5a-a08a-a00eb1ad14da
X-MS-Exchange-Organization-SCL: 9
X-MS-Exchange-Organization-AuthSource: DAG9EX2.mxp5.local
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Transport-EndToEndLatency: 00:00:00.5736284
X-MS-Exchange-Processed-By-BccFoldering: 15.01.2507.044
MIME-Version: 1.0
From: Kane-Chen-AS <[email protected]>
PATCH v4 5/5 hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive property
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
This patch adds a new machine parameter otpmem which creates a QOM property alias on the aspeed_sbc device for the OTP drive.
Example usage:
./qemu-system-arm \
-machine ast2600-evb,otpmem=otp-drive \
-blockdev driver=file,filename=otpmem.img,node-name=otp \
-global aspeed-otp.drive=otp \
...With this change, the specified alias name (e.g. "otp-drive") becomes available on the QOM path /machine/soc/sbc/otp-drive.
--- hw/arm/aspeed.c | 20 ++++++++++++++++++++ hw/misc/aspeed_sbc.c | 8 ++++++++ 2 files changed, 28 insertions(+)
hw/arm/aspeed.c +20 -0
@@ -48,6 +48,7 @@ struct AspeedMachineState {uint32_t uart_chosen;char *fmc_model;char *spi_model; +char *otpmem;uint32_t hw_strap1; };
@@ -1424,6 +1425,21 @@ static void aspeed_set_bmc_console(Object *obj, const char *value, Error **errp) bmc->uart_chosen = val +ASPEED_DEV_UART0 ; } +static char *aspeed_get_otpmem (Object *obj,Error **errp) +{ +AspeedMachineState *bmc =ASPEED_MACHINE (obj); + +return g_strdup (bmc->otpmem); +} + +static void aspeed_set_otpmem (Object *obj,const char *value,Error **errp) +{ +AspeedMachineState *bmc =ASPEED_MACHINE (obj); + +g_free (bmc->otpmem); + bmc->otpmem =g_strdup (value); +} +static void aspeed_machine_class_props_init (ObjectClass *oc) { object_class_property_add_bool(oc, "execute-in-place",
@@ -1445,6 +1461,10 @@ static void aspeed_machine_class_props_init(ObjectClass *oc) aspeed_set_spi_model);object_class_property_set_description (oc,"spi-model" ,"Change the SPI Flash model" ); +object_class_property_add_str (oc,"otpmem" , aspeed_get_otpmem, + aspeed_set_otpmem); +object_class_property_set_description (oc,"otpmem" , +"Set OTP Memory type" ); }static void aspeed_machine_class_init_cpus_defaults (MachineClass *mc)
hw/misc/aspeed_sbc.c +8 -0
@@ -209,10 +209,18 @@ static void aspeed_sbc_instance_init(Object *obj) {AspeedSBCClass *sc =ASPEED_SBC_GET_CLASS (obj);AspeedSBCState *s =ASPEED_SBC (obj); +char *otpname;if (sc->has_otp) {object_initialize_child (OBJECT (s),"otp" , &s->otp,TYPE_ASPEED_OTP ); + otpname =object_property_get_str (qdev_get_machine (), +"otpmem" , + &error_abort); +if (strlen (otpname)) { +object_property_add_alias (obj, otpname, +OBJECT (&s->otp),"drive" ); + } } }
Signature · 1 line
2.43.0
Re: [SPAM] [PATCH v4 5/5] hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive property
Quoted 72 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch adds a new machine parameter
otpmemwhich creates a QOM property alias on theaspeed_sbcdevice for the OTP drive.Example usage:
./qemu-system-arm \ -machine ast2600-evb,otpmem=otp-drive \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...With this change, the specified alias name (e.g. "otp-drive") becomes available on the QOM path
/machine/soc/sbc/otp-drive.Signed-off-by Kane-Chen-AS <[email protected]>--- hw/arm/aspeed.c | 20 ++++++++++++++++++++ hw/misc/aspeed_sbc.c | 8 ++++++++ 2 files changed, 28 insertions(+)hw/arm/aspeed.c +20
-0@@ -48,6 +48,7 @@ struct AspeedMachineState {uint32_t uart_chosen;char *fmc_model;char *spi_model; +char *otpmem;uint32_t hw_strap1; };@@ -1424,6 +1425,21 @@ static void aspeed_set_bmc_console(Object *obj, const char *value, Error **errp) bmc->uart_chosen = val +ASPEED_DEV_UART0 ; } +static char *aspeed_get_otpmem (Object *obj,Error **errp) +{ +AspeedMachineState *bmc =ASPEED_MACHINE (obj); + +return g_strdup (bmc->otpmem); +} + +static void aspeed_set_otpmem (Object *obj,const char *value,Error **errp) +{ +AspeedMachineState *bmc =ASPEED_MACHINE (obj); + +g_free (bmc->otpmem); + bmc->otpmem =g_strdup (value); +} +static void aspeed_machine_class_props_init (ObjectClass *oc) { object_class_property_add_bool(oc, "execute-in-place",@@ -1445,6 +1461,10 @@ static void aspeed_machine_class_props_init(ObjectClass *oc) aspeed_set_spi_model);object_class_property_set_description (oc,"spi-model" ,"Change the SPI Flash model" ); +object_class_property_add_str (oc,"otpmem" , aspeed_get_otpmem, + aspeed_set_otpmem); +object_class_property_set_description (oc,"otpmem" , +"Set OTP Memory type" ); }static void aspeed_machine_class_init_cpus_defaults (MachineClass *mc)hw/misc/aspeed_sbc.c +0
-0
hw/misc/aspeed_sbc.c static void aspeed_sbc_instance_init(Object *obj) · line 218
Quoted 10 lines
hw/misc/aspeed_sbc.c +3
-0@@ -209,10 +209,18 @@ static void aspeed_sbc_instance_init(Object *obj) {AspeedSBCClass *sc =ASPEED_SBC_GET_CLASS (obj);AspeedSBCState *s =ASPEED_SBC (obj); +char *otpname;if (sc->has_otp) {object_initialize_child (OBJECT (s),"otp" , &s->otp,TYPE_ASPEED_OTP ); + otpname =object_property_get_str (qdev_get_machine (), + "otpmem",> + &error_abort);
This is a hack and I would prefer to prevent device models from accessing directly the machine.
It would have been nice to have a machine option, but since the user can specify a file for the OTP backend from the command line, let's leave it as is.
Thanks,
C.
Quoted 7 lines
hw/misc/aspeed_sbc.c +4
-0+if (strlen (otpname)) { +object_property_add_alias (obj, otpname, +OBJECT (&s->otp),"drive" ); + } } }
Quoted 17 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch series extends the QEMU model for the ASPEED OTP (One-Time Programmable) memory device with block backend support and tighter integration with the SoC and machine configuration.
The OTP model simulates a simple fuse array, used in ASPEED SoCs for secure boot and configuration purposes. The updated model now supports loading initial OTP content from a file via the QEMU CLI.
Example usage:
./qemu-system-arm \ -machine ast2600-evb,otpmem=otp \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...
Quoted 6 lines
ChangeLog
---------
v4:
- Add a 'drive' property to allow backing OTP data with a block device
- Expose a machine parameter (-machine otpmem=XXX) for convenient aliasing of the OTP drive via QOM path
Patch 1-4 are fine. Patch 5 is too complex to address and its value is limited as explained.
Could you please send a documentation update :
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/system/arm/aspeed.rst ?
An extra section after "Other booting options" explaining the OTP backend for the AST2600 SoC would be welcome.
Please make sure --enable-docs is configured.
Thanks,
C.
Quoted 35 lines
v3:
- Switched toobject_property_set_int()for setting "size"
- Simplifiedqdev_realize()error handling by passing errp directly
- Added "drive" property to OTP model for future extensibilityv2:
- Rename device from 'aspeed_otpmem' to 'aspeed_otp' and move it to hw/nvram/
- Move OTP device realization frominstance_initto the realize function
- Improve error logging withqemu_log_mask()and remove unused error propagationv1:
- Initial version---
Kane-Chen-AS (5):
hw/misc/aspeed_otp: Add ASPEED OTP memory device model hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs hw/misc/aspeed_otp: Add 'drive' property to support block backend hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive propertyinclude/hw/misc/aspeed_sbc.h | 5 ++ include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/arm/aspeed.c | 20 ++++++ hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 121 ++++++++++++++++++++++++++++++++++ hw/nvram/aspeed_otp.c | 113 +++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ hw/nvram/meson.build | 4 ++ 8 files changed, 302 insertions(+), 1 deletion(-)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.c
Hi Cédric,
Thanks for your review.
I will drop patch 5 and include a documentation update in the next version.
Best Regards,
Kane
Quoted 101 lines
-----Original Message-----
From: Cédric Le Goater <[email protected]>
Sent: Tuesday, July 22, 2025 5:41 PM
To: Kane Chen <[email protected]>; Peter Maydell <[email protected]>; Steven Lee <[email protected]>; Troy Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew Jeffery <[email protected]>; Joel Stanley <[email protected]>; open list:ASPEED BMCs <[email protected]>; open list:All patches CC here <[email protected]>
Cc: Troy Lee <[email protected]>
Subject: Re: [SPAM] [PATCH v4 0/5] ASPEED OTP QEMU model: block backend, machine alias, SoC integrationQuoted 17 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch series extends the QEMU model for the ASPEED OTP (One-Time Programmable) memory device with block backend support and tighter integration with the SoC and machine configuration.
The OTP model simulates a simple fuse array, used in ASPEED SoCs for secure boot and configuration purposes. The updated model now supports loading initial OTP content from a file via the QEMU CLI.
Example usage:
./qemu-system-arm \ -machine ast2600-evb,otpmem=otp \ -blockdev driver=file,filename=otpmem.img,node-name=otp \ -global aspeed-otp.drive=otp \ ...Quoted 6 lines
ChangeLog
---------
v4:
- Add a 'drive' property to allow backing OTP data with a block device
- Expose a machine parameter (-machine otpmem=XXX) for convenient aliasing of the OTP drive via QOM pathPatch 1-4 are fine. Patch 5 is too complex to address and its value is limited as explained.
Could you please send a documentation update :
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/system/arm/asp
eed.rst?An extra section after "Other booting options" explaining the OTP backend for the AST2600 SoC would be welcome.
Please make sure --enable-docs is configured.
Thanks,
C.
Quoted 27 lines
v3:
- Switched toobject_property_set_int()for setting "size"
- Simplifiedqdev_realize()error handling by passing errp directly
- Added "drive" property to OTP model for future extensibilityv2:
- Rename device from 'aspeed_otpmem' to 'aspeed_otp' and move it to hw/nvram/
- Move OTP device realization frominstance_initto the realize function
- Improve error logging withqemu_log_mask()and remove unused error propagationv1:
- Initial version---
Kane-Chen-AS (5):
hw/misc/aspeed_otp: Add ASPEED OTP memory device model hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs hw/misc/aspeed_otp: Add 'drive' property to support block backend hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive
propertyQuoted 5 lines
include/hw/misc/aspeed_sbc.h | 5 ++ include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/arm/aspeed.c | 20 ++++++ hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 121++++++++++++++++++++++++++++++++++
Quoted 1 line
hw/nvram/aspeed_otp.c | 113+++++++++++++++++++++++++++++++
Quoted 6 lines
hw/misc/trace-events | 5 ++ hw/nvram/meson.build | 4 ++ 8 files changed, 302 insertions(+), 1 deletion(-)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.c