gpicview: enable gtk3 PACKAGECONFIG only when gtk+3 is available
PATCH 1/2 gpicview: enable gtk3 PACKAGECONFIG only when gtk+3 is available
From: Martin Jansa <[email protected]>
--- meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +1 -1
@@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" inherit autotools mime-xdg pkgconfig -PACKAGECONFIG ?= "gtk3" +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}" PACKAGECONFIG[gtk2] = ",,gtk+" PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3"
PATCH 2/2 xmlsec1: fix build with gnutls or openssl PACKAGECONFIG not enabled
From: Martin Jansa <[email protected]>
the .pc files might not be installed based on the PACKAGECONFIG value
fixes:
https://git.openembedded.org/meta-openembedded/commit/?id=cce20b5124e28ee55adf03fe062084f38d065580
--- meta-oe/recipes-support/xmlsec1/xmlsec1_1.3.7.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-support/xmlsec1/xmlsec1_1.3.7.bb +1 -1
@@ -59,7 +59,7 @@ do_install:append() { ${libdir}/xmlsec1Conf.sh \ ${libdir}/pkgconfig/xmlsec1-openssl.pc \ ${libdir}/pkgconfig/xmlsec1-gnutls.pc; do - sed -i -e "s@${RECIPE_SYSROOT}@@g" ${D}$i + [ -f ${D}$i ] && sed -i -e "s@${RECIPE_SYSROOT}@@g" ${D}$i || true done }
Hi Martin,
Quoted 12 lines · Martin Jansa via lists.openembedded.org
From: Martin Jansa <[email protected]>
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +0
-0
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" · line 18
Quoted 5 lines
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +1
-1@@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" inherit autotools mime-xdg pkgconfig -PACKAGECONFIG ?= "gtk3" +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}"
Thanks for the patch. In this case, shouldn't we add gtk+ if gtk3 is not set? If PACKAGECONFIG is empty, then the compilation will fail:
| configure: WARNING: using cross tools not prefixed with host triplet | checking pkg-config is at least version 0.9.0... yes | checking for gtk+-2.0 >= 2.12.0... no | configure: error: Package requirements (gtk+-2.0 >= 2.12.0) were not met: | | No package 'gtk+-2.0' found
Or maybe add gtk+ as dependency and keep the gtk+3 only on the PACKAGECONFIG?
Best Regards,
Hiago.
Quoted 12 lines
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +0
-1PACKAGECONFIG[gtk2] = ",,gtk+" PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3" -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#118307): https://lists.openembedded.org/g/openembedded-devel/message/118307
Mute This Topic: https://lists.openembedded.org/mt/114043964/9076898
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 17 lines · Hiago De Franco via lists.openembedded.org
Hi Martin,
Quoted 13 lines · Martin Jansa via lists.openembedded.org
From: Martin Jansa <[email protected]>
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +0
-0@@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630"
Quoted 8 lines
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" · line 18
Quoted 4 lines
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +1
-1inherit autotools mime-xdg pkgconfig -PACKAGECONFIG ?= "gtk3" +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}"Thanks for the patch. In this case, shouldn't we add gtk+ if gtk3 is not set? If PACKAGECONFIG is empty, then the compilation will fail:
seems that way.
Quoted 29 lines
| configure: WARNING: using cross tools not prefixed with host triplet | checking pkg-config is at least version 0.9.0... yes | checking for gtk+-2.0 >= 2.12.0... no | configure: error: Package requirements (gtk+-2.0 >= 2.12.0) were not met: | | No package 'gtk+-2.0' foundOr maybe add gtk+ as dependency and keep the gtk+3 only on the PACKAGECONFIG?
Best Regards,
Hiago.meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" · line 21
Quoted 6 lines
meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +0
-0PACKAGECONFIG[gtk2] = ",,gtk+" PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3"-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#118321): https://lists.openembedded.org/g/openembedded-devel/message/118321
Mute This Topic: https://lists.openembedded.org/mt/114043964/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-