Skip to contentSkip to conversation

s390/con3270: Use macros for hardcoded values

PATCH New Xose Vazquez Perez 1 participant 1 message Jul 9, 2025 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/con3270: Use macros for hardcoded values

Similar as in sclp_vt220

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)

---
Trivial, but uncompiled!!

---
 drivers/s390/char/con3270.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/s390/char/con3270.c +7 -3
index b78b86e8f281..c99d7822b176 100644
@@ -33,6 +33,10 @@
 #include "raw3270.h"
 #include "keyboard.h"
 
+#define TTY3270_DRIVER_NAME	"tty3270"
+#define TTY3270_DEVICE_NAME	"3270/tty"
+#define TTY3270_CONSOLE_NAME	"tty3270"
+
 #define TTY3270_CHAR_BUF_SIZE 256
 #define TTY3270_OUTPUT_BUFFER_SIZE 4096
 #define TTY3270_SCREEN_PAGES 8 /* has to be power-of-two */
@@ -2020,8 +2024,8 @@ static int __init tty3270_init(void)
 	 * Entries in tty3270_driver that are NOT initialized:
 	 * proc_entry, set_termios, flush_buffer, set_ldisc, write_proc
 	 */
-	driver->driver_name = "tty3270";
-	driver->name = "3270/tty";
+	driver->driver_name = TTY3270_DRIVER_NAME;
+	driver->name = TTY3270_DEVICE_NAME;
 	driver->major = IBM_TTY3270_MAJOR;
 	driver->minor_start = RAW3270_FIRSTMINOR;
 	driver->name_base = RAW3270_FIRSTMINOR;
@@ -2145,7 +2149,7 @@ static struct notifier_block on_reboot_nb = {
 };
 
 static struct console con3270 = {
-	.name	 = "tty3270",
+	.name	 = TTY3270_CONSOLE_NAME,
 	.write	 = con3270_write,
 	.device	 = con3270_device,
 	.flags	 = CON_PRINTBUFFER,
Signature · 1 line
2.50.0