rculist: move list_for_each_rcu() to where it belongs
Subsystems (3)
PATCH 1/1 rculist: move list_for_each_rcu() to where it belongs
The list_for_each_rcu() relies on the rcu_dereference() API which is not provided by the list.h. At the same time list.h is a low-level basic header that must not have dependencies like RCU, besides the fact of the potential circular dependencies in some cases. With all that said, move RCU related API to the rculist.h where it belongs.
--- include/linux/list.h | 10 ---------- include/linux/rculist.h | 10 ++++++++++ kernel/cgroup/dmem.c | 1 + 3 files changed, 11 insertions(+), 10 deletions(-)
include/linux/list.h +0 -10
@@ -686,16 +686,6 @@ static inline void list_splice_tail_init(struct list_head *list,#define list_for_each (pos, head) \ for (pos = (head)->next; !list_is_head(pos, (head)); pos = pos->next) -/** -* list_for_each_rcu - Iterate over a list in an RCU-safe fashion -* @pos: the &struct list_head to use as a loop cursor. -* @head: the head for your list. -*/ -#define list_for_each_rcu (pos, head) \ - for (pos = rcu_dereference((head)->next); \ - !list_is_head(pos, (head)); \ - pos = rcu_dereference(pos->next)) -/** * list_for_each_continue - continue iteration over a list * @pos: the &struct list_head to use as a loop cursor.
include/linux/rculist.h +10 -0
@@ -42,6 +42,16 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)*/ #define list_bidir_prev_rcu (list) (*((struct list_head __rcu **)(&(list)->prev))) +/** +* list_for_each_rcu - Iterate over a list in an RCU-safe fashion +* @pos: the &struct list_head to use as a loop cursor. +* @head: the head for your list. +*/ +#define list_for_each_rcu (pos, head) \ + for (pos = rcu_dereference((head)->next); \ + !list_is_head(pos, (head)); \ + pos = rcu_dereference(pos->next)) +/** * list_tail_rcu - returns the prev pointer of the head of the list * @head: the head of the list
kernel/cgroup/dmem.c +1 -0
@@ -14,6 +14,7 @@#include <linux/mutex.h> #include <linux/page_counter.h> #include <linux/parser.h> +#include <linux/rculist.h> #include <linux/slab.h> struct dmem_cgroup_region {
Signature · 1 line
2.47.2
Quoted 7 lines · Andy Shevchenko
The
list_for_each_rcu()relies on thercu_dereference()API which is not provided by thelist.h. At the same timelist.his a low-level basic header that must not have dependencies like RCU, besides the fact of the potential circular dependencies in some cases. With all that said, move RCU related API to therculist.hwhere it belongs.Signed-off-by Andy Shevchenko <[email protected]>
Also ack for the dmem part for merging through your tree. -Sima
Quoted 63 lines
--- include/linux/list.h | 10 ---------- include/linux/rculist.h | 10 ++++++++++ kernel/cgroup/dmem.c | 1 + 3 files changed, 11 insertions(+), 10 deletions(-)include/linux/list.h +0
-10@@ -686,16 +686,6 @@ static inline void list_splice_tail_init(struct list_head *list,#define list_for_each (pos, head) \ for (pos = (head)->next; !list_is_head(pos, (head)); pos = pos->next) -/** -* list_for_each_rcu - Iterate over a list in an RCU-safe fashion -* @pos: the &struct list_head to use as a loop cursor. -* @head: the head for your list. -*/ -#define list_for_each_rcu (pos, head) \ - for (pos = rcu_dereference((head)->next); \ - !list_is_head(pos, (head)); \ - pos = rcu_dereference(pos->next)) -/** * list_for_each_continue - continue iteration over a list * @pos: the &struct list_head to use as a loop cursor. include/linux/rculist.h +10
-0@@ -42,6 +42,16 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)*/ #define list_bidir_prev_rcu (list) (*((struct list_head __rcu **)(&(list)->prev))) +/** +* list_for_each_rcu - Iterate over a list in an RCU-safe fashion +* @pos: the &struct list_head to use as a loop cursor. +* @head: the head for your list. +*/ +#define list_for_each_rcu (pos, head) \ + for (pos = rcu_dereference((head)->next); \ + !list_is_head(pos, (head)); \ + pos = rcu_dereference(pos->next)) +/** * list_tail_rcu - returns the prev pointer of the head of the list * @head: the head of the list kernel/cgroup/dmem.c +1
-0@@ -14,6 +14,7 @@#include <linux/mutex.h> #include <linux/page_counter.h> #include <linux/parser.h> +#include <linux/rculist.h> #include <linux/slab.h> struct dmem_cgroup_region {Signature · 1 line
2.47.2
Signature · 3 lines
Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 7 lines · Andy Shevchenko
The
list_for_each_rcu()relies on thercu_dereference()API which is not provided by thelist.h. At the same timelist.his a low-level basic header that must not have dependencies like RCU, besides the fact of the potential circular dependencies in some cases. With all that said, move RCU related API to therculist.hwhere it belongs.Signed-off-by Andy Shevchenko <[email protected]>
I cannot see why this would not work, and it does pass testing, but I am adding David Howells in case there is some subtle reason why this must remain in include/linux/list.h.
ad25f5cb3987 ("rxrpc: Fix locking issue")
In the absence of such a reason, from an RCU viewpoint:
Quoted 63 lines
--- include/linux/list.h | 10 ---------- include/linux/rculist.h | 10 ++++++++++ kernel/cgroup/dmem.c | 1 + 3 files changed, 11 insertions(+), 10 deletions(-)include/linux/list.h +0
-10@@ -686,16 +686,6 @@ static inline void list_splice_tail_init(struct list_head *list,#define list_for_each (pos, head) \ for (pos = (head)->next; !list_is_head(pos, (head)); pos = pos->next) -/** -* list_for_each_rcu - Iterate over a list in an RCU-safe fashion -* @pos: the &struct list_head to use as a loop cursor. -* @head: the head for your list. -*/ -#define list_for_each_rcu (pos, head) \ - for (pos = rcu_dereference((head)->next); \ - !list_is_head(pos, (head)); \ - pos = rcu_dereference(pos->next)) -/** * list_for_each_continue - continue iteration over a list * @pos: the &struct list_head to use as a loop cursor. include/linux/rculist.h +10
-0@@ -42,6 +42,16 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)*/ #define list_bidir_prev_rcu (list) (*((struct list_head __rcu **)(&(list)->prev))) +/** +* list_for_each_rcu - Iterate over a list in an RCU-safe fashion +* @pos: the &struct list_head to use as a loop cursor. +* @head: the head for your list. +*/ +#define list_for_each_rcu (pos, head) \ + for (pos = rcu_dereference((head)->next); \ + !list_is_head(pos, (head)); \ + pos = rcu_dereference(pos->next)) +/** * list_tail_rcu - returns the prev pointer of the head of the list * @head: the head of the list kernel/cgroup/dmem.c +1
-0@@ -14,6 +14,7 @@#include <linux/mutex.h> #include <linux/page_counter.h> #include <linux/parser.h> +#include <linux/rculist.h> #include <linux/slab.h> struct dmem_cgroup_region {Signature · 1 line
2.47.2