staging: media: atomisp: indentation cleanup per directory
Subsystems (4)
v9 cover staging: media: atomisp: indentation cleanup per directory
This patch series focuses on cleaning up indentation (spaces, tabs) in the AtomISP driver under drivers/staging/media/atomisp/pci/isp/kernels/.
This version continues to address only indentation-related issues, with patches split by subdirectory for clarity and easier review.
There is no functional logic change.
---
Changes in v9:
- Reformatted struct comments to follow kernel-doc format
- Reverted macro definition changes that removed alignment
- Reverted multi-line array initializations to use brace-on-own-line style
- Added trailing comma in small array initializations
- Adjusted function declarations to follow kernel-style indentation
- Removed unnecessary churn in cases where code was already style-compliant
- Link to v8: https://lore.kernel.org/r/[email protected]
Changes in v8:
- Reorganized cleanup by subdirectory (one commit per directory)
- Focused only on indentation fixes (spaces, tabs)
- Removed all clang-format involvement
- No functional changes
- Link to v7: https://lore.kernel.org/all/[email protected]/
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory
- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/[email protected]
Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Removed extra spaces between type and asterisk (e.g., *to) in function declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
- Link to v1: https://lore.kernel.org/r/[email protected]
Thanks for your previous feedback.
Best regards,
LiangCheng Wang <[email protected]>
---
LiangCheng Wang (3):
staging: media: atomisp: fix indentation in aa
staging: media: atomisp: fix indentation in anr
staging: media: atomisp: fix indentation in bh
.../pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h | 8 +++++--- .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 22 ++++++++-------------- .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h | 20 +++++++------------- .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c | 14 +++++--------- .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h | 13 +++++-------- .../pci/isp/kernels/bh/bh_2/ia_css_bh.host.c | 14 +++++--------- .../pci/isp/kernels/bh/bh_2/ia_css_bh.host.h | 14 +++++--------- 7 files changed, 40 insertions(+), 65 deletions(-)
---
base-commit: 8c2e52ebbe885c7eeaabd3b7ddcdc1246fc400d2
change-id: 20250704-new_atomisp-e73f471f3078
Best regards,
Signature · 1 line
LiangCheng Wang <[email protected]>
PATCH v9 1/3 staging: media: atomisp: fix indentation in aa
This patch fixes tab/space indentation issues in aa following kernel coding style guidelines.
No functional logic changes were made.
--- .../media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h +5 -3
@@ -28,11 +28,13 @@* ISP block: BAA2 * ISP1: BAA2 is used. * ISP2: BAA2 is used. +* +* @strength: Strength of the filter, in u0.13 fixed-point format. +* Valid range: [0, 8191]. A value of 0 means the filter is +* ineffective (default). */ struct ia_css_aa_config { -u16 strength;/** Strength of the filter. -u0.13, [0,8191], -default/ineffective 0 */ +u16 strength; };#endif /* __IA_CSS_AA2_TYPES_H */
Signature · 1 line
2.43.0
Re: [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa
Quoted 1 line · LiangCheng Wang
This patch fixes tab/space indentation issues in aa
The Submitting Patches insists to use imperative mode.
Quoted 1 line
following kernel coding style guidelines.
No, currently the code does something different, you forgot to update the commit message. Something like
"""
Move a standalone kernel-doc comment of the 'strength' field of the struct ia_css_aa_config to the whole-structure one. """
...
Quoted 2 lines
Unneeded Link tags. It actually doesn't matter when and how it was suggested, the relevant people are automatically added to Cc list.
The rule of thumb is that the person who suggested the change (in terms of Suggested-by tag) should also provide at least Acked-by (or Reviewed-by). It can be optional if that person is the same as the committer of the changes (depends on them and respective maintainers).
Quoted 1 line
---
Code wise LGTM.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v9 2/3 staging: media: atomisp: fix indentation in anr
In reply to LiangCheng WangThis patch fixes tab/space indentation issues in anr following kernel coding style guidelines.
No functional logic changes were made.
--- .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 22 ++++++++-------------- .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h | 20 +++++++------------- .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c | 14 +++++--------- .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h | 13 +++++-------- 4 files changed, 25 insertions(+), 44 deletions(-)
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c +8 -14
@@ -18,23 +18,19 @@ const struct ia_css_anr_config default_anr_config = { 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4, 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4 }, - {10, 20, 30} + { 10, 20, 30 }, }; -void -ia_css_anr_encode ( -struct sh_css_isp_anr_params *to, -const struct ia_css_anr_config *from, -unsigned int size) +void ia_css_anr_encode (struct sh_css_isp_anr_params *to, +const struct ia_css_anr_config *from, +unsigned int size) { (void )size; to->threshold = from->threshold; } -void -ia_css_anr_dump ( -const struct sh_css_isp_anr_params *anr, -unsigned int level) +void ia_css_anr_dump (const struct sh_css_isp_anr_params *anr, +unsigned int level) {if (!anr)return ;ia_css_debug_dtrace (level,"Advance Noise Reduction:\n" );
@@ -42,10 +38,8 @@ ia_css_anr_dump( "anr_threshold", anr->threshold); } -void -ia_css_anr_debug_dtrace ( -const struct ia_css_anr_config *config, -unsigned int level) +void ia_css_anr_debug_dtrace (const struct ia_css_anr_config *config, +unsigned int level) { ia_css_debug_dtrace(level, "config.threshold=%d\n",
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h +7 -13
@@ -12,20 +12,14 @@extern const struct ia_css_anr_config default_anr_config; -void -ia_css_anr_encode ( -struct sh_css_isp_anr_params *to, -const struct ia_css_anr_config *from, -unsigned int size); +void ia_css_anr_encode (struct sh_css_isp_anr_params *to, +const struct ia_css_anr_config *from, +unsigned int size); -void -ia_css_anr_dump ( -const struct sh_css_isp_anr_params *anr, -unsigned int level); +void ia_css_anr_dump (const struct sh_css_isp_anr_params *anr, +unsigned int level); -void -ia_css_anr_debug_dtrace ( -const struct ia_css_anr_config *config,unsigned int level) -; +void ia_css_anr_debug_dtrace (const struct ia_css_anr_config *config, +unsigned int level);#endif /* __IA_CSS_ANR_HOST_H */
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c +5 -9
@@ -10,11 +10,9 @@#include "ia_css_anr2.host.h" -void -ia_css_anr2_vmem_encode ( -struct ia_css_isp_anr2_params *to, -const struct ia_css_anr_thres *from, -size_t size) +void ia_css_anr2_vmem_encode (struct ia_css_isp_anr2_params *to, +const struct ia_css_anr_thres *from, +size_t size) {unsigned int i;
@@ -28,10 +26,8 @@ ia_css_anr2_vmem_encode( } } -void -ia_css_anr2_debug_dtrace ( -const struct ia_css_anr_thres *config, -unsigned int level) +void ia_css_anr2_debug_dtrace (const struct ia_css_anr_thres *config, +unsigned int level) { (void )config; (void )level;
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h +5 -8
@@ -13,15 +13,12 @@#include "ia_css_anr2_param.h" #include "ia_css_anr2_table.host.h" -void -ia_css_anr2_vmem_encode ( -struct ia_css_isp_anr2_params *to, -const struct ia_css_anr_thres *from, -size_t size); +void ia_css_anr2_vmem_encode (struct ia_css_isp_anr2_params *to, +const struct ia_css_anr_thres *from, +size_t size); -void -ia_css_anr2_debug_dtrace ( -const struct ia_css_anr_thres *config,unsigned int level) +void ia_css_anr2_debug_dtrace (const struct ia_css_anr_thres *config, +unsigned int level) ;#endif /* __IA_CSS_ANR2_HOST_H */
Signature · 1 line
2.43.0
Re: [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr
Quoted 4 lines · LiangCheng Wang
This patch fixes tab/space indentation issues in anr following kernel coding style guidelines.
No functional logic changes were made.
Same comments about Link tags and suggestions in general.
...
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c const struct ia_css_anr_config default_anr_config = { · line 19
Quoted 2 lines
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c +0
-00 ,3 ,1 ,2 ,3 ,6 ,4 ,5 ,1 ,4 ,2 ,3 ,2 ,5 ,3 ,4 ,0 ,3 ,1 ,2 ,3 ,6 ,4 ,5 ,1 ,4 ,2 ,3 ,2 ,5 ,3 ,4
Side note, would be nice to add a trailing comma here. I think it's okay to do in this patch as this is not enough for a separate change and the driver in staging, the rules are slightly relaxed on it.
Quoted 4 lines
drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c +1
-1}, - {10, 20, 30} + { 10, 20, 30 }, };
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v9 3/3 staging: media: atomisp: fix indentation in bh
In reply to LiangCheng WangThis patch fixes tab/space indentation issues in bh following kernel coding style guidelines.
No functional logic changes were made.
--- .../media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c | 14 +++++--------- .../media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h | 14 +++++--------- 2 files changed, 10 insertions(+), 18 deletions(-)
drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c +5 -9
@@ -12,10 +12,8 @@#include "ia_css_bh.host.h" -void -ia_css_bh_hmem_decode ( -struct ia_css_3a_rgby_output *out_ptr, -const struct ia_css_bh_table *hmem_buf) +void ia_css_bh_hmem_decode (struct ia_css_3a_rgby_output *out_ptr, +const struct ia_css_bh_table *hmem_buf) {int i;
@@ -37,11 +35,9 @@ ia_css_bh_hmem_decode( } } -void -ia_css_bh_encode ( -struct sh_css_isp_bh_params *to, -const struct ia_css_3a_config *from, -unsigned int size) +void ia_css_bh_encode (struct sh_css_isp_bh_params *to, +const struct ia_css_3a_config *from, +unsigned int size) { (void )size;/* coefficients to calculate Y */
drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h +5 -9
@@ -10,15 +10,11 @@#include "ia_css_bh_param.h" #include "s3a/s3a_1.0/ia_css_s3a_types.h" -void -ia_css_bh_hmem_decode ( -struct ia_css_3a_rgby_output *out_ptr, -const struct ia_css_bh_table *hmem_buf); +void ia_css_bh_hmem_decode (struct ia_css_3a_rgby_output *out_ptr, +const struct ia_css_bh_table *hmem_buf); -void -ia_css_bh_encode ( -struct sh_css_isp_bh_params *to, -const struct ia_css_3a_config *from, -unsigned int size); +void ia_css_bh_encode (struct sh_css_isp_bh_params *to, +const struct ia_css_3a_config *from, +unsigned int size);#endif /* __IA_CSS_BH_HOST_H */
Signature · 1 line
2.43.0
Re: [PATCH v9 3/3] staging: media: atomisp: fix indentation in bh
Quoted 4 lines · LiangCheng Wang
This patch fixes tab/space indentation issues in bh following kernel coding style guidelines.
No functional logic changes were made.
Since the changes are all similar, I suggest to squash all three to one patch. I hope Hnas won't object this. The code looks good to me in all three with the small nit-picks and Link tag usage.
Signature · 2 lines
With Best Regards, Andy Shevchenko