Skip to contentSkip to conversation

scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions

PATCH In review Khaled Elnaggar 3 participants 5 messages Jul 12, 2025 – Jul 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions

Replace scnprintf() with sysfs_emit() in several sysfs show() callbacks in hisi_sas_v3_hw.c. This is recommended in Documentation/filesystems/sysfs.rst for formatting values returned to userspace.

---
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +4 -7
index bc5d5356dd00..84bc02f7da27 100644
@@ -2849,7 +2849,7 @@ static void wait_cmds_complete_timeout_v3_hw(struct hisi_hba *hisi_hba,
 static ssize_t intr_conv_v3_hw_show(struct device *dev,
 				    struct device_attribute *attr, char *buf)
 {
-	return scnprintf(buf, PAGE_SIZE, "%u\n", hisi_sas_intr_conv);
+	return sysfs_emit(buf, "%u\n", hisi_sas_intr_conv);
 }
 static DEVICE_ATTR_RO(intr_conv_v3_hw);
 
@@ -2881,8 +2881,7 @@ static ssize_t intr_coal_ticks_v3_hw_show(struct device *dev,
 	struct Scsi_Host *shost = class_to_shost(dev);
 	struct hisi_hba *hisi_hba = shost_priv(shost);
 
-	return scnprintf(buf, PAGE_SIZE, "%u\n",
-			 hisi_hba->intr_coal_ticks);
+	return sysfs_emit(buf, "%u\n", hisi_hba->intr_coal_ticks);
 }
 
 static ssize_t intr_coal_ticks_v3_hw_store(struct device *dev,
@@ -2920,8 +2919,7 @@ static ssize_t intr_coal_count_v3_hw_show(struct device *dev,
 	struct Scsi_Host *shost = class_to_shost(dev);
 	struct hisi_hba *hisi_hba = shost_priv(shost);
 
-	return scnprintf(buf, PAGE_SIZE, "%u\n",
-			 hisi_hba->intr_coal_count);
+	return sysfs_emit(buf, "%u\n", hisi_hba->intr_coal_count);
 }
 
 static ssize_t intr_coal_count_v3_hw_store(struct device *dev,
@@ -2959,8 +2957,7 @@ static ssize_t iopoll_q_cnt_v3_hw_show(struct device *dev,
 	struct Scsi_Host *shost = class_to_shost(dev);
 	struct hisi_hba *hisi_hba = shost_priv(shost);
 
-	return scnprintf(buf, PAGE_SIZE, "%u\n",
-			 hisi_hba->iopoll_q_cnt);
+	return sysfs_emit(buf, "%u\n", hisi_hba->iopoll_q_cnt);
 }
 static DEVICE_ATTR_RO(iopoll_q_cnt_v3_hw);
 
Signature · 1 line
2.47.2
#1 lore raw
Quoted 4 lines · Khaled Elnaggar

Replace scnprintf() with sysfs_emit() in several sysfs show() callbacks in hisi_sas_v3_hw.c. This is recommended in Documentation/filesystems/sysfs.rst for formatting values returned to userspace.

For new users, yes, but what's wrong with these existing calls? They still work properly, so why change them?

thanks,

greg k-h

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 4 lines · Khaled Elnaggar

Replace scnprintf() with sysfs_emit() in several sysfs show() callbacks in hisi_sas_v3_hw.c. This is recommended in Documentation/filesystems/sysfs.rst for formatting values returned to userspace.

Quoted 6 lines

For new users, yes, but what's wrong with these existing calls? They still work properly, so why change them?

thanks,

greg k-h

Oh okay, got it. I was under the impression that older scnprintf() calls should be actively replaced with sysfs_emit(). But no need if they just work, unless there is a bug or something.

Thanks for the clarification.

#3 lore raw
In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 4 lines · Khaled Elnaggar

Replace scnprintf() with sysfs_emit() in several sysfs show() callbacks in hisi_sas_v3_hw.c. This is recommended in Documentation/filesystems/sysfs.rst for formatting values returned to userspace.

For new users, yes, but what's wrong with these existing calls? They still work properly, so why change them?

How about making this explicit in Documentation/filesystems/sysfs.rst? I think that would help to stop the steady stream of patches for converting existing sysfs show callbacks to sysfs_emit()/sysfs_emit_at().

Thanks,

Bart.

#4 lore raw
Quoted 7 lines · Bart Van Assche
Quoted 6 lines · Greg KH
Quoted 4 lines · Khaled Elnaggar

Replace scnprintf() with sysfs_emit() in several sysfs show() callbacks in hisi_sas_v3_hw.c. This is recommended in Documentation/filesystems/sysfs.rst for formatting values returned to userspace.

Quoted 6 lines
Quoted 2 lines

For new users, yes, but what's wrong with these existing calls? They still work properly, so why change them?

How about making this explicit in Documentation/filesystems/sysfs.rst? I think that would help to stop the steady stream of patches for converting existing sysfs show callbacks to sysfs_emit()/sysfs_emit_at().

Patches gladly accepted :)