Skip to contentSkip to conversation

mm-hugetlb-remove-prepare_hugepage_range.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jul 13, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/hugetlb: remove prepare_hugepage_range()
has been removed from the -mm tree. Its filename was
mm-hugetlb-remove-prepare_hugepage_range.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Peter Xu <[email protected]>
Subject: mm/hugetlb: remove prepare_hugepage_range()
Date: Fri, 27 Jun 2025 12:07:07 -0400

Only mips and loongarch implemented this API, however what it does was checking against stack overflow for either len or addr. That's already done in arch's arch_get_unmapped_area*() functions, even though it may not be 100% identical checks.

For example, for both of the architectures, there will be a trivial difference on how stack top was defined. The old code uses STACK_TOP which may be slightly smaller than TASK_SIZE on either of them, but the hope is that shouldn't be a problem.

It means the whole API is pretty much obsolete at least now, remove it completely.

---

 arch/loongarch/include/asm/hugetlb.h |   14 --------------
 arch/mips/include/asm/hugetlb.h      |   14 --------------
 fs/hugetlbfs/inode.c                 |    8 ++------
 include/asm-generic/hugetlb.h        |    8 --------
 include/linux/hugetlb.h              |    6 ------
 5 files changed, 2 insertions(+), 48 deletions(-)
arch/loongarch/include/asm/hugetlb.h renamed from arch/loongarch/include/asm/hugetlb.h~mm-hugetlb-remove-prepare_hugepage_range +0 -14
@@ -10,20 +10,6 @@
 
 uint64_t pmd_to_entrylo(unsigned long pmd_val);
 
-#define __HAVE_ARCH_PREPARE_HUGEPAGE_RANGE
-static inline int prepare_hugepage_range(struct file *file,
-					 unsigned long addr,
-					 unsigned long len)
-{
-	unsigned long task_size = STACK_TOP;
-
-	if (len > task_size)
-		return -ENOMEM;
-	if (task_size - len < addr)
-		return -EINVAL;
-	return 0;
-}
-
 #define __HAVE_ARCH_HUGE_PTE_CLEAR
 static inline void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
 				  pte_t *ptep, unsigned long sz)
arch/mips/include/asm/hugetlb.h renamed from arch/mips/include/asm/hugetlb.h~mm-hugetlb-remove-prepare_hugepage_range +0 -14
@@ -11,20 +11,6 @@
 
 #include <asm/page.h>
 
-#define __HAVE_ARCH_PREPARE_HUGEPAGE_RANGE
-static inline int prepare_hugepage_range(struct file *file,
-					 unsigned long addr,
-					 unsigned long len)
-{
-	unsigned long task_size = STACK_TOP;
-
-	if (len > task_size)
-		return -ENOMEM;
-	if (task_size - len < addr)
-		return -EINVAL;
-	return 0;
-}
-
 #define __HAVE_ARCH_HUGE_PTEP_GET_AND_CLEAR
 static inline pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
 					    unsigned long addr, pte_t *ptep,
fs/hugetlbfs/inode.c renamed from fs/hugetlbfs/inode.c~mm-hugetlb-remove-prepare_hugepage_range +2 -6
@@ -179,12 +179,8 @@ hugetlb_get_unmapped_area(struct file *f
 
 	if (len & ~huge_page_mask(h))
 		return -EINVAL;
-	if (flags & MAP_FIXED) {
-		if (addr & ~huge_page_mask(h))
-			return -EINVAL;
-		if (prepare_hugepage_range(file, addr, len))
-			return -EINVAL;
-	}
+	if ((flags & MAP_FIXED) && (addr & ~huge_page_mask(h)))
+		return -EINVAL;
 	if (addr)
 		addr0 = ALIGN(addr, huge_page_size(h));
 
include/asm-generic/hugetlb.h renamed from include/asm-generic/hugetlb.h~mm-hugetlb-remove-prepare_hugepage_range +0 -8
@@ -114,14 +114,6 @@ static inline int huge_pte_none_mostly(p
 }
 #endif
 
-#ifndef __HAVE_ARCH_PREPARE_HUGEPAGE_RANGE
-static inline int prepare_hugepage_range(struct file *file,
-		unsigned long addr, unsigned long len)
-{
-	return 0;
-}
-#endif
-
 #ifndef __HAVE_ARCH_HUGE_PTEP_SET_WRPROTECT
 static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
 		unsigned long addr, pte_t *ptep)
include/linux/hugetlb.h renamed from include/linux/hugetlb.h~mm-hugetlb-remove-prepare_hugepage_range +0 -6
@@ -359,12 +359,6 @@ static inline void hugetlb_show_meminfo_
 {
 }
 
-static inline int prepare_hugepage_range(struct file *file,
-				unsigned long addr, unsigned long len)
-{
-	return -EINVAL;
-}
-
 static inline void hugetlb_vma_lock_read(struct vm_area_struct *vma)
 {
 }

_

Patches currently in -mm which might be from [email protected] are