Skip to contentSkip to conversation

iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 15, 2025 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE

From: Arnd Bergmann <[email protected]>

The newly added support for SPI offloading causes a link error when the dmaengine buffer helpers are unavailable:

arm-linux-gnueabi-ld: drivers/iio/adc/ad_sigma_delta.o: in function `devm_ad_sd_setup_buffer_and_trigger':
ad_sigma_delta.c:(.text+0x6b8): undefined reference to `devm_iio_dmaengine_buffer_setup_with_handle'

Fixes 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
index d43edc7b0c0f..e2649739a2da 100644
@@ -23,6 +23,7 @@ config AD_SIGMA_DELTA
 	tristate
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
+	select IIO_BUFFER_DMAENGINE
 
 config AD4000
 	tristate "Analog Devices AD4000 ADC Driver"
Signature · 1 line
2.39.5
reviewer
#1 lore raw
Quoted 19 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added support for SPI offloading causes a link error when the dmaengine buffer helpers are unavailable:

arm-linux-gnueabi-ld: drivers/iio/adc/ad_sigma_delta.o: in function `devm_ad_sd_setup_buffer_and_trigger':
ad_sigma_delta.c:(.text+0x6b8): undefined reference to `devm_iio_dmaengine_buffer_setup_with_handle'

Fixes 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +0 -0
index d43edc7b0c0f..e2649739a2da 100644

drivers/iio/adc/Kconfig config AD_SIGMA_DELTA · line 29

Quoted 7 lines
drivers/iio/adc/Kconfig +1 -0
@@ -23,6 +23,7 @@ config AD_SIGMA_DELTA
 	tristate
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
+	select IIO_BUFFER_DMAENGINE
 
 config AD4000
 	tristate "Analog Devices AD4000 ADC Driver"

Thanks, but I think [1] is a more complete fix.

[1]: https://lore.kernel.org/linux-iio/20250714-iio-ad_sigma_delta-fix-kconfig-selects-v1-1-32e0d6da0423@kernel.org/