DC Patches July 21, 2025
Subsystems (3)
cover DC Patches July 21, 2025
This DC patchset brings improvements in multiple areas. In summary, we highlight:
- Fix divide by zero when calculating min ODM factor
- Ensure committing streams is seamless when transitioning between topologies
- Fix condition for setting timing_adjust_pending
- Update DMUB tiled to tiled copy command
---
Aurabindo Pillai (1):
drm/amd/display: fix condition for setting timing_adjust_pending
Clay King (1):
drm/amd/display: ensure committing streams is seamless
Dillon Varone (1):
drm/amd/display: Fix divide by zero when calculating min ODM factor
Gabe Teeger (1):
drm/amd/display: Revert Add HPO encoder support to Replay
Mario Limonciello (1):
drm/amd/display: Drop unnecessary 'rc' variable in
amdgpu_dm_backlight_get_level()
Ostrowski Rafal (1):
drm/amd/display: Update tiled to tiled copy command
Taimur Hassan (4):
drm/amd/display: [FW Promotion] Release 0.1.18.0 drm/amd/display: Promote DAL to 3.2.341 drm/amd/display: [FW Promotion] Release 0.1.19.0 drm/amd/display: Promote DAL to 3.2.342
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 16 +++- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +- .../gpu/drm/amd/display/dc/dce/dmub_replay.c | 43 +---------- .../gpu/drm/amd/display/dc/dce/dmub_replay.h | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 29 +++---- .../link/protocols/link_edp_panel_control.c | 2 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 75 ++++++++++++++----- 9 files changed, 95 insertions(+), 82 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/10 drm/amd/display: [FW Promotion] Release 0.1.18.0
From: Taimur Hassan <[email protected]>
Add new mode in struct ips_residency_mode
--- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h +3 -3
@@ -882,7 +882,7 @@ enum dmub_shared_state_feature_id {/** * struct dmub_shared_state_ips_fw - Firmware signals for IPS. */ -union dmub_shared_state_ips_fw_signals { +union dmub_shared_state_ips_fw_signals {struct {uint32_t ips1_commit :1 ;/**< 1 if in IPS1 or IPS0 RCG */ uint32_t ips2_commit :1 ;/**< 1 if in IPS2 */
@@ -897,7 +897,7 @@ enum dmub_shared_state_feature_id {/** * struct dmub_shared_state_ips_signals - Firmware signals for IPS. */ -union dmub_shared_state_ips_driver_signals { +union dmub_shared_state_ips_driver_signals {struct {uint32_t allow_pg :1 ;/**< 1 if PG is allowed */ uint32_t allow_ips1 :1 ;/**< 1 is IPS1 is allowed */
@@ -4099,7 +4099,6 @@ struct dmub_cmd_replay_copy_settings_data {* Use for AUX-less ALPM LFPS wake operation */ struct dmub_alpm_auxless_data auxless_alpm_data; -/** * @pad: Align structure to 4 byte boundary. */
@@ -5914,6 +5913,7 @@ enum ips_residency_mode {IPS_RESIDENCY__IPS2 ,IPS_RESIDENCY__IPS1_RCG ,IPS_RESIDENCY__IPS1_ONO2_ON , + IPS_RESIDENCY__IPS1_Z8_RETENTION, };#define NUM_IPS_HISTOGRAM_BUCKETS 16
Signature · 1 line
2.43.0
PATCH 2/10 drm/amd/display: Promote DAL to 3.2.341
In reply to waynelinFrom: Taimur Hassan <[email protected]>
This version brings along following fixes:
- Fixes for DCN401, DCN32
- Initial support of SmartMux
- Improvements for Replay, IPS, and IPS2
- Refactor of DSC
--- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dc.h +1 -1
@@ -55,7 +55,7 @@ struct aux_payload;struct set_config_cmd_payload ;struct dmub_notification ; -#define DC_VER "3.2.340" +#define DC_VER "3.2.341"/** * MAX_SURFACES - representative of the upper bound of surfaces that can be piped to a single CRTC
Signature · 1 line
2.43.0
PATCH 3/10 drm/amd/display: Update tiled to tiled copy command
In reply to waynelinFrom: Ostrowski Rafal <[email protected]>
[Why & How]
Tiled command rect dimensions is 1 based, do rect_x/y - 1 internally
--- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c +2 -2
@@ -2072,8 +2072,8 @@ bool dmub_lsdma_send_tiled_to_tiled_copy_command( lsdma_data->u.tiled_copy_data.dst_swizzle_mode = params.swizzle_mode; lsdma_data->u.tiled_copy_data.src_element_size = params.element_size; lsdma_data->u.tiled_copy_data.dst_element_size = params.element_size; - lsdma_data->u.tiled_copy_data.rect_x = params.rect_x; - lsdma_data->u.tiled_copy_data.rect_y = params.rect_y; + lsdma_data->u.tiled_copy_data.rect_x = params.rect_x -1 ; + lsdma_data->u.tiled_copy_data.rect_y = params.rect_y -1 ; lsdma_data->u.tiled_copy_data.dcc = params.dcc; lsdma_data->u.tiled_copy_data.tmz = params.tmz; lsdma_data->u.tiled_copy_data.read_compress = params.read_compress;
Signature · 1 line
2.43.0
PATCH 4/10 drm/amd/display: fix condition for setting timing_adjust_pending
In reply to waynelinFrom: Aurabindo Pillai <[email protected]>
timing_adjust_pending is used to defer certain programming sequences when OTG timing is about to be changed, like with VRR. Insufficient checking for timing change in this case caused a regression which reduces PSR Replay residency.
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc.c +3 -1
@@ -446,7 +446,9 @@ bool dc_stream_adjust_vmin_vmax(struct dc *dc,* avoid conflicting with firmware updates. */ if (dc->ctx->dce_version >DCE_VERSION_MAX ) { -if (dc->optimized_required || dc->wm_optimized_required) { +if ((dc->optimized_required || dc->wm_optimized_required) && + (stream->adjust.v_total_max != adjust->v_total_max || + stream->adjust.v_total_min != adjust->v_total_min)) { stream->adjust.timing_adjust_pending = true;return false; }
Signature · 1 line
2.43.0
PATCH 5/10 drm/amd/display: Revert Add HPO encoder support to Replay
In reply to waynelinFrom: Gabe Teeger <[email protected]>
This reverts commits:
commit e6bd65ba7323 ("drm/amd/display: Add HPO encoder support to Replay") commit 2595b2de3005 ("drm/amd/display: Add support for Panel Replay on DP1 eDP (panel_inst=1)") due to visual confirm issue.
--- .../gpu/drm/amd/display/dc/dce/dmub_replay.c | 43 ++----------------- .../gpu/drm/amd/display/dc/dce/dmub_replay.h | 2 +- .../link/protocols/link_edp_panel_control.c | 2 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 20 --------- 4 files changed, 5 insertions(+), 62 deletions(-)
drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c +3 -40
@@ -4,7 +4,6 @@#include "dc.h" #include "dc_dmub_srv.h" -#include "dc_dp_types.h" #include "dmub/dmub_srv.h" #include "core_types.h" #include "dmub_replay.h"
@@ -44,45 +43,21 @@ static void dmub_replay_get_state(struct dmub_replay *dmub, enum replay_state *s/* * Enable/Disable Replay. */ -static void dmub_replay_enable (struct dmub_replay *dmub,bool enable,bool wait,uint8_t panel_inst, -struct dc_link *link) +static void dmub_replay_enable (struct dmub_replay *dmub,bool enable,bool wait,uint8_t panel_inst) {union dmub_rb_cmd cmd;struct dc_context *dc = dmub->ctx;uint32_t retry_count;enum replay_state state =REPLAY_STATE_0 ; -struct pipe_ctx *pipe_ctx =NULL ; -struct resource_context *res_ctx = &link->ctx->dc->current_state->res_ctx; -uint8_t i;memset (&cmd,0 ,sizeof (cmd)); cmd.replay_enable.header.type =DMUB_CMD__REPLAY ; cmd.replay_enable.data.panel_inst = panel_inst; cmd.replay_enable.header.sub_type =DMUB_CMD__REPLAY_ENABLE ; -if (enable) { +if (enable) cmd.replay_enable.data.enable =REPLAY_ENABLE ; -// hpo stream/link encoder assignments are not static, need to update everytime we try to enable replay -if (link->cur_link_settings.link_rate >=LINK_RATE_UHBR10 ) { -for (i =0 ; i <MAX_PIPES ; i++) { -if (res_ctx && - res_ctx->pipe_ctx[i].stream && - res_ctx->pipe_ctx[i].stream->link && - res_ctx->pipe_ctx[i].stream->link == link && - res_ctx->pipe_ctx[i].stream->link->connector_signal ==SIGNAL_TYPE_EDP ) { - pipe_ctx = &res_ctx->pipe_ctx[i]; -//TODO: refactor for multi edp support -break ; - } - } - -if (!pipe_ctx) -return ; - - cmd.replay_enable.data.hpo_stream_enc_inst = pipe_ctx->stream_res.hpo_dp_stream_enc->inst; - cmd.replay_enable.data.hpo_link_enc_inst = pipe_ctx->link_res.hpo_dp_link_enc->inst; - } - }else +else cmd.replay_enable.data.enable =REPLAY_DISABLE ; cmd.replay_enable.header.payload_bytes =sizeof (struct dmub_rb_cmd_replay_enable_data );
@@ -174,17 +149,6 @@ static bool dmub_replay_copy_settings(struct dmub_replay *dmub, copy_settings_data->digbe_inst = replay_context->digbe_inst; copy_settings_data->digfe_inst = replay_context->digfe_inst; -if (link->cur_link_settings.link_rate >=LINK_RATE_UHBR10 ) { -if (pipe_ctx->stream_res.hpo_dp_stream_enc) - copy_settings_data->hpo_stream_enc_inst = pipe_ctx->stream_res.hpo_dp_stream_enc->inst; -else - copy_settings_data->hpo_stream_enc_inst =0 ; -if (pipe_ctx->link_res.hpo_dp_link_enc) - copy_settings_data->hpo_link_enc_inst = pipe_ctx->link_res.hpo_dp_link_enc->inst; -else - copy_settings_data->hpo_link_enc_inst =0 ; - } -if (pipe_ctx->plane_res.dpp) copy_settings_data->dpp_inst = pipe_ctx->plane_res.dpp->inst;else
@@ -247,7 +211,6 @@ static void dmub_replay_set_coasting_vtotal(struct dmub_replay *dmub, pCmd->header.type =DMUB_CMD__REPLAY ; pCmd->header.sub_type =DMUB_CMD__REPLAY_SET_COASTING_VTOTAL ; pCmd->header.payload_bytes =sizeof (struct dmub_cmd_replay_set_coasting_vtotal_data ); - pCmd->replay_set_coasting_vtotal_data.panel_inst = panel_inst; pCmd->replay_set_coasting_vtotal_data.coasting_vtotal = (coasting_vtotal &0xFFFF ); pCmd->replay_set_coasting_vtotal_data.coasting_vtotal_high = (coasting_vtotal &0xFFFF0000 ) >>16 ;
drivers/gpu/drm/amd/display/dc/dce/dmub_replay.h +1 -1
@@ -19,7 +19,7 @@ struct dmub_replay_funcs {void (*replay_get_state)(struct dmub_replay *dmub,enum replay_state *state,uint8_t panel_inst);void (*replay_enable)(struct dmub_replay *dmub,bool enable,bool wait, -uint8_t panel_inst,struct dc_link *link); +uint8_t panel_inst);bool (*replay_copy_settings)(struct dmub_replay *dmub,struct dc_link *link,struct replay_context *replay_context,uint8_t panel_inst); void (*replay_set_power_opt)(struct dmub_replay *dmub, unsigned int power_opt,
drivers/gpu/drm/amd/display/dc/link/protocols/link_edp_panel_control.c +1 -1
@@ -944,7 +944,7 @@ bool edp_set_replay_allow_active(struct dc_link *link, const bool *allow_active,// TODO: Handle mux change case if force_static is set // If force_static is set, just change the replay_allow_active state directly if (replay !=NULL && link->replay_settings.replay_feature_enabled) - replay->funcs->replay_enable (replay, *allow_active, wait, panel_inst, link); + replay->funcs->replay_enable (replay, *allow_active, wait, panel_inst); link->replay_settings.replay_allow_active = *allow_active; }
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h +0 -20
@@ -4047,14 +4047,6 @@ struct dmub_cmd_replay_copy_settings_data {* DIG BE HW instance. */ uint8_t digbe_inst; -/** -* @hpo_stream_enc_inst: HPO stream encoder instance -*/ -uint8_t hpo_stream_enc_inst; -/** -* @hpo_link_enc_inst: HPO link encoder instance -*/ -uint8_t hpo_link_enc_inst;/** * AUX HW instance. */
@@ -4158,18 +4150,6 @@ struct dmub_rb_cmd_replay_enable_data {* This does not support HDMI/DP2 for now. */ uint8_t phy_rate; -/** -* @hpo_stream_enc_inst: HPO stream encoder instance -*/ -uint8_t hpo_stream_enc_inst; -/** -* @hpo_link_enc_inst: HPO link encoder instance -*/ -uint8_t hpo_link_enc_inst; -/** -* @pad: Align structure to 4 byte boundary. -*/ -uint8_t pad[2 ]; };/**
Signature · 1 line
2.43.0
PATCH 6/10 drm/amd/display: ensure committing streams is seamless
In reply to waynelinFrom: Clay King <[email protected]>
[Why]
When transitioning between topologies such as multi-display to single display ODM 2:1, pipes might not be freed before use.
[How]
In dc_commit_streams, commit an additional, minimal transition if original transition is not seamless to ensure pipes are freed.
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc.c +12 -0
@@ -2399,6 +2399,18 @@ enum dc_status dc_commit_streams(struct dc *dc, struct dc_commit_streams_params goto fail; } +/* +* If not already seamless, make transition seamless by inserting intermediate minimal transition +*/ +if (dc->hwss.is_pipe_topology_transition_seamless && + !dc->hwss.is_pipe_topology_transition_seamless (dc, dc->current_state, context)) { + res =commit_minimal_transition_state (dc, context); +if (res !=DC_OK ) { +BREAK_TO_DEBUGGER (); + goto fail; + } + } + res =dc_commit_state_no_check (dc, context);for (i =0 ; i < params->stream_count; i++) {
Signature · 1 line
2.43.0
PATCH 7/10 drm/amd/display: Drop unnecessary 'rc' variable in amdgpu_dm_backlight_get_level()
In reply to waynelinFrom: Mario Limonciello <[email protected]>
[Why]amdgpu_dm_backlight_get_level() returns a boolean value but is assigned to a variable named 'rc' which is generally used for return codes.
This can be confusing while looking at the code for other issues.
[How]
Drop the variable and just look directly at the return value of amdgpu_dm_backlight_get_level() in the if statement.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -3
@@ -4924,10 +4924,8 @@ static u32 amdgpu_dm_backlight_get_level(struct amdgpu_display_manager *dm,if (caps.aux_support) {u32 avg, peak; -bool rc; - rc =dc_link_get_backlight_level_nits (link, &avg, &peak); -if (!rc) +if (!dc_link_get_backlight_level_nits (link, &avg, &peak))return dm->brightness[bl_idx];return convert_brightness_to_user (&caps, avg); }
Signature · 1 line
2.43.0
PATCH 8/10 drm/amd/display: Fix divide by zero when calculating min ODM factor
In reply to waynelinFrom: Dillon Varone <[email protected]>
[WHY&HOW]
If the debug option is set to disable_dsc the max slice width and/or dispclk can be zero. This causes a divide by zero when calculating the min ODM combine factor. Add a check to ensure they are valid first.
--- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 29 +++++++++++---------- 1 file changed, 15 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c +15 -14
@@ -152,7 +152,7 @@ uint32_t dc_bandwidth_in_kbps_from_timing( }/* Forward Declerations */ -static unsigned int get_min_slice_count_for_odm ( +static unsigned int get_min_dsc_slice_count_for_odm (const struct display_stream_compressor *dsc,const struct dsc_enc_caps *dsc_enc_caps,const struct dc_crtc_timing *timing);
@@ -466,7 +466,7 @@ bool dc_dsc_compute_bandwidth_range( struct dc_dsc_bw_range *range) {bool is_dsc_possible = false; -unsigned int min_slice_count; +unsigned int min_dsc_slice_count;struct dsc_enc_caps dsc_enc_caps;struct dsc_enc_caps dsc_common_caps;struct dc_dsc_config config = {0 };
@@ -478,14 +478,14 @@ bool dc_dsc_compute_bandwidth_range(get_dsc_enc_caps (dsc, &dsc_enc_caps, timing->pix_clk_100hz); - min_slice_count =get_min_slice_count_for_odm (dsc, &dsc_enc_caps, timing); + min_dsc_slice_count =get_min_dsc_slice_count_for_odm (dsc, &dsc_enc_caps, timing); is_dsc_possible =intersect_dsc_caps (dsc_sink_caps, &dsc_enc_caps, timing->pixel_encoding, &dsc_common_caps);if (is_dsc_possible) is_dsc_possible =setup_dsc_config (dsc_sink_caps, &dsc_enc_caps,0 , timing, - &options, link_encoding, min_slice_count, &config); + &options, link_encoding, min_dsc_slice_count, &config);if (is_dsc_possible) is_dsc_possible = decide_dsc_bandwidth_range(min_bpp_x16, max_bpp_x16,
@@ -593,14 +593,12 @@ static void build_dsc_enc_caps(struct dc *dc; -memset (&single_dsc_enc_caps,0 ,sizeof (struct dsc_enc_caps )); -if (!dsc || !dsc->ctx || !dsc->ctx->dc || !dsc->funcs->dsc_get_single_enc_caps)return ; dc = dsc->ctx->dc; -if (!dc->clk_mgr || !dc->clk_mgr->funcs->get_max_clock_khz || !dc->res_pool) +if (!dc->clk_mgr || !dc->clk_mgr->funcs->get_max_clock_khz || !dc->res_pool || dc->debug.disable_dsc)return ;/* get max DSCCLK from clk_mgr */
@@ -634,7 +632,7 @@ static inline uint32_t dsc_div_by_10_round_up(uint32_t value)return (value +9 ) /10 ; } -static unsigned int get_min_slice_count_for_odm ( +static unsigned int get_min_dsc_slice_count_for_odm (const struct display_stream_compressor *dsc,const struct dsc_enc_caps *dsc_enc_caps,const struct dc_crtc_timing *timing)
@@ -651,6 +649,10 @@ static unsigned int get_min_slice_count_for_odm( } } +/* validate parameters */ +if (max_dispclk_khz ==0 || dsc_enc_caps->max_slice_width ==0 ) +return 1 ; +/* consider minimum odm slices required due to * 1) display pipe throughput (dispclk) * 2) max image width per slice
@@ -669,13 +671,12 @@ static void get_dsc_enc_caps( {memset (dsc_enc_caps,0 ,sizeof (struct dsc_enc_caps )); -if (!dsc) +if (!dsc || !dsc->ctx || !dsc->ctx->dc || dsc->ctx->dc->debug.disable_dsc)return ;/* check if reported cap global or only for a single DCN DSC enc */ if (dsc->funcs->dsc_get_enc_caps) { -if (!dsc->ctx->dc->debug.disable_dsc) - dsc->funcs->dsc_get_enc_caps (dsc_enc_caps, pixel_clock_100Hz); + dsc->funcs->dsc_get_enc_caps (dsc_enc_caps, pixel_clock_100Hz); }else {build_dsc_enc_caps (dsc, dsc_enc_caps); }
@@ -1295,10 +1296,10 @@ bool dc_dsc_compute_config( {bool is_dsc_possible = false;struct dsc_enc_caps dsc_enc_caps; -unsigned int min_slice_count; +unsigned int min_dsc_slice_count;get_dsc_enc_caps (dsc, &dsc_enc_caps, timing->pix_clk_100hz); - min_slice_count =get_min_slice_count_for_odm (dsc, &dsc_enc_caps, timing); + min_dsc_slice_count =get_min_dsc_slice_count_for_odm (dsc, &dsc_enc_caps, timing); is_dsc_possible = setup_dsc_config(dsc_sink_caps, &dsc_enc_caps,
@@ -1306,7 +1307,7 @@ bool dc_dsc_compute_config( timing, options, link_encoding, - min_slice_count, + min_dsc_slice_count, dsc_cfg);return is_dsc_possible; }
Signature · 1 line
2.43.0
PATCH 9/10 drm/amd/display: [FW Promotion] Release 0.1.19.0
In reply to waynelinFrom: Taimur Hassan <[email protected]>
Update DMUB related command structure.
--- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 89 +++++++++++++++---- 1 file changed, 73 insertions(+), 16 deletions(-)
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h +73 -16
@@ -1990,18 +1990,19 @@ struct dmub_cmd_lsdma_data {struct lsdma_tiled_copy_data {uint32_t src_addr_lo;uint32_t src_addr_hi; +uint32_t dst_addr_lo;uint32_t dst_addr_hi;uint32_t src_x :16 ;uint32_t src_y :16 ; -uint32_t src_width :16 ; -uint32_t src_height :16 ; -uint32_t dst_x :16 ;uint32_t dst_y :16 ; +uint32_t src_width :16 ; +uint32_t src_height :16 ; +uint32_t dst_width :16 ;uint32_t dst_height :16 ;
@@ -2034,23 +2035,58 @@ struct dmub_cmd_lsdma_data { uint32_t padding : 30; } tiled_copy_data;struct lsdma_linear_copy_data { +uint32_t src_lo; +uint32_t src_hi; + +uint32_t dst_lo; +uint32_t dst_hi; +uint32_t count :30 ;uint32_t cache_policy_dst :2 ;uint32_t tmz :1 ;uint32_t cache_policy_src :2 ;uint32_t padding :29 ; - + } linear_copy_data; +struct lsdma_linear_sub_window_copy_data {uint32_t src_lo;uint32_t src_hi; +uint32_t dst_lo;uint32_t dst_hi; - } linear_copy_data; + +uint32_t src_x :16 ; +uint32_t src_y :16 ; + +uint32_t dst_x :16 ; +uint32_t dst_y :16 ; + +uint32_t rect_x :16 ; +uint32_t rect_y :16 ; + +uint32_t src_pitch :16 ; +uint32_t dst_pitch :16 ; + +uint32_t src_slice_pitch; +uint32_t dst_slice_pitch; + +uint32_t tmz :1 ; +uint32_t element_size :3 ; +uint32_t src_cache_policy :3 ; +uint32_t dst_cache_policy :3 ; +uint32_t reserved0 :22 ; + } linear_sub_window_copy_data;struct lsdma_reg_write_data {uint32_t reg_addr;uint32_t reg_data; } reg_write_data; struct lsdma_pio_copy_data { + uint32_t src_lo; + uint32_t src_hi; + + uint32_t dst_lo; + uint32_t dst_hi; + union { struct { uint32_t byte_count : 26;
@@ -2063,12 +2099,11 @@ struct dmub_cmd_lsdma_data { } fields;uint32_t raw; } packet; -uint32_t src_lo; -uint32_t src_hi; -uint32_t dst_lo; -uint32_t dst_hi; } pio_copy_data; struct lsdma_pio_constfill_data { + uint32_t dst_lo; + uint32_t dst_hi; + union { struct { uint32_t byte_count : 26;
@@ -2081,14 +2116,12 @@ struct dmub_cmd_lsdma_data { } fields;uint32_t raw; } packet; -uint32_t dst_lo; -uint32_t dst_hi; +uint32_t data; } pio_constfill_data;uint32_t all[14 ]; } u; - };struct dmub_rb_cmd_lsdma {
@@ -4047,6 +4080,14 @@ struct dmub_cmd_replay_copy_settings_data {* DIG BE HW instance. */ uint8_t digbe_inst; +/** +* @hpo_stream_enc_inst: HPO stream encoder instance +*/ +uint8_t hpo_stream_enc_inst; +/** +* @hpo_link_enc_inst: HPO link encoder instance +*/ +uint8_t hpo_link_enc_inst;/** * AUX HW instance. */
@@ -4150,6 +4191,18 @@ struct dmub_rb_cmd_replay_enable_data {* This does not support HDMI/DP2 for now. */ uint8_t phy_rate; +/** +* @hpo_stream_enc_inst: HPO stream encoder instance +*/ +uint8_t hpo_stream_enc_inst; +/** +* @hpo_link_enc_inst: HPO link encoder instance +*/ +uint8_t hpo_link_enc_inst; +/** +* @pad: Align structure to 4 byte boundary. +*/ +uint8_t pad[2 ]; };/**
@@ -4663,22 +4716,26 @@ enum dmub_cmd_lsdma_type {* LSDMA copies data from source to destination linearly */ DMUB_CMD__LSDMA_LINEAR_COPY =1 , +/** +* LSDMA copies data from source to destination linearly in sub window +*/ +DMUB_CMD__LSDMA_LINEAR_SUB_WINDOW_COPY =2 ,/** * Send the tiled-to-tiled copy command */ -DMUB_CMD__LSDMA_TILED_TO_TILED_COPY =2 , +DMUB_CMD__LSDMA_TILED_TO_TILED_COPY =3 ,/** * Send the poll reg write command */ -DMUB_CMD__LSDMA_POLL_REG_WRITE =3 , +DMUB_CMD__LSDMA_POLL_REG_WRITE =4 ,/** * Send the pio copy command */ -DMUB_CMD__LSDMA_PIO_COPY =4 , +DMUB_CMD__LSDMA_PIO_COPY =5 ,/** * Send the pio constfill command */ - DMUB_CMD__LSDMA_PIO_CONSTFILL = 5, + DMUB_CMD__LSDMA_PIO_CONSTFILL = 6, }; struct abm_ace_curve {
Signature · 1 line
2.43.0
PATCH 10/10 drm/amd/display: Promote DAL to 3.2.342
In reply to waynelinFrom: Taimur Hassan <[email protected]>
This version brings along following fixes:
- Fix divide by zero when calculating min ODM factor
- Ensure committing streams is seamless when transitioning between topologies
- Fix condition for setting timing_adjust_pending
- Update DMUB tiled to tiled copy command
--- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dc.h +1 -1
@@ -55,7 +55,7 @@ struct aux_payload;struct set_config_cmd_payload ;struct dmub_notification ; -#define DC_VER "3.2.341" +#define DC_VER "3.2.342"/** * MAX_SURFACES - representative of the upper bound of surfaces that can be piped to a single CRTC
Signature · 1 line
2.43.0
[Public]
Hi all,
This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types.
APU
* Single Display eDP -> 1080p 60hz, 1920x1200 165hz
* Single Display DP (SST DSC) -> 4k144hz, 4k240hz
* Multi display -> eDP + DP/HDMI/USB-C -> 1080p 60hz eDP + 4k 144hz, 4k 240hz (Includes USB-C to DP/HDMI adapters)
* Thunderbolt -> LG Ultrafine 5k
* MST DSC -> Cable Matters 101075 (DP to 3x DP) with 3x 4k60hz displays, HP Hook G2 with 2x 4k60hz displays
* USB 4 -> HP Hook G4, Lenovo Thunderbolt Dock, both with 2x 4k60hz DP and 1x 4k60hz HDMI displays
* SST PCON -> Club3D CAC-1085 + 1x 4k 144hz, FRL3, at a max resolution supported by the dongle of 4k 120hz YUV420 12bpc.
* MST PCON -> 1x 4k 144hz, FRL3, at a max resolution supported by the adapter of 4k 120hz RGB 8bpc.
DGPU
* Single Display DP (SST DSC) -> 4k144hz, 4k240hz
* Multiple Display DP -> 4k240hz + 4k144hz
* MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60hz displays)
* MST DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60hz displays)
The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to)
* Changing display configurations and settings
* Video/Audio playback
* Benchmark testing
* Suspend/Resume testing
* Feature testing (Freesync, HDCP, etc.)
Automated testing includes (but is not limited to)
* Script testing (scripts to automate some of the manual checks)
* IGT testing
The testing is mainly tested on the following displays, but occasionally there are tests with other displays
* Samsung G8 Neo 4k240hz
* Samsung QN55QN95B 4k 120hz
* Acer XV322QKKV 4k144hz
* HP U27 4k Wireless 4k60hz
* LG 27UD58B 4k60hz
* LG 32UN650WA 4k60hz
* LG Ultrafine 5k 5k60hz
* AU Optronics B140HAN01.1 1080p 60hz eDP
* AU Optronics B160UAN01.J 1920x1200 165hz eDP
The patchset consists of the amd-staging-drm-next branch (Head commit - bf696978aa0c9c601b38dd48e37b34dc1c2edcfa -> drm/amd/display: Disable CRTC degamma LUT for DCN401) with new patches added on top of it.
Tested on Ubuntu 24.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook | Twitter | amd.com
-----Original Message-----
From: waynelin <[email protected]>
Sent: Tuesday, July 15, 2025 2:49 AM
To: [email protected]
Cc: Wentland, Harry <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Pillai, Aurabindo <[email protected]>; Li, Roman <[email protected]>; Lin, Wayne <[email protected]>; Chung, ChiaHsuan (Tom) <[email protected]>; Zuo, Jerry <[email protected]>; Wheeler, Daniel <[email protected]>; Wu, Ray <[email protected]>; Hung, Alex <[email protected]>; Lin, Wayne <[email protected]>
Subject: [PATCH 00/10] DC Patches July 21, 2025
This DC patchset brings improvements in multiple areas. In summary, we highlight:
- Fix divide by zero when calculating min ODM factor
- Ensure committing streams is seamless when transitioning between topologies
- Fix condition for setting timing_adjust_pending
- Update DMUB tiled to tiled copy command
---
Aurabindo Pillai (1):
drm/amd/display: fix condition for setting timing_adjust_pending
Clay King (1):
drm/amd/display: ensure committing streams is seamless
Dillon Varone (1):
drm/amd/display: Fix divide by zero when calculating min ODM factor
Gabe Teeger (1):
drm/amd/display: Revert Add HPO encoder support to Replay
Mario Limonciello (1):
drm/amd/display: Drop unnecessary 'rc' variable in
amdgpu_dm_backlight_get_level()
Ostrowski Rafal (1):
drm/amd/display: Update tiled to tiled copy command
Taimur Hassan (4):
drm/amd/display: [FW Promotion] Release 0.1.18.0 drm/amd/display: Promote DAL to 3.2.341 drm/amd/display: [FW Promotion] Release 0.1.19.0 drm/amd/display: Promote DAL to 3.2.342
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 16 +++- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +- .../gpu/drm/amd/display/dc/dce/dmub_replay.c | 43 +---------- .../gpu/drm/amd/display/dc/dce/dmub_replay.h | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 29 +++---- .../link/protocols/link_edp_panel_control.c | 2 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 75 ++++++++++++++----- 9 files changed, 95 insertions(+), 82 deletions(-)
--
2.43.0