spi: intel: Allow writeable MTD partition with module param
PATCH 1/1 spi: intel: Allow writeable MTD partition with module param
The MTD device is blocked from writing to the SPI-NOR chip if any region of it is write-protected, even if "writeable=1" module parameter is set.
Add ability to bypass this behaviour by introducing new module parameter "ignore_protestion_status" which allows to rely on the write protection mechanism of SPI-NOR chip itself, which most modern chips (since the 1990'+) have already implemented.
Any erase/write operations performed on the write-protected section will be rejected by the chip.
--- drivers/spi/spi-intel.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/spi/spi-intel.c +10 -3
@@ -189,6 +189,11 @@ struct intel_spi_mem_op {static bool writeable;module_param (writeable, bool,0 );MODULE_PARM_DESC (writeable,"Enable write access to SPI flash chip (default=0)" ); +static bool ignore_protection_status; +module_param (ignore_protection_status, bool,0 ); +MODULE_PARAM_DESC ( + ignore_protection_status, +"Do not block SPI flash chip write access even if it is write-protected (default=0)" );static void intel_spi_dump_regs (struct intel_spi *ispi) {
@@ -1248,13 +1253,15 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,continue ;/* -* If any of the regions have protection bits set, make the -* whole partition read-only to be on the safe side. +* If any of the regions have protection bits set and +* the ignore protection status parameter is not set, +* make the whole partition read-only to be on the safe side. * * Also if the user did not ask the chip to be writeable * mask the bit too. */ -if (!writeable ||intel_spi_is_protected (ispi, base, limit)) { +if (!writeable || (!ignore_protection_status && +intel_spi_is_protected (ispi, base, limit))) { part->mask_flags |=MTD_WRITEABLE ; ispi->protected = true; }
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Jakub,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on broonie-sound/for-next westeri-thunderbolt/next linus/master v6.16-rc6 next-20250715] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Czapiga/spi-intel-Allow-writeable-MTD-partition-with-module-param/20250715-175230 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next patch link: https://lore.kernel.org/r/20250715095007.896620-1-czapiga%40google.com patch subject: [PATCH] spi: intel: Allow writeable MTD partition with module param config: arc-randconfig-001-20250716 (https://download.01.org/0day-ci/archive/20250716/[email protected]/config) compiler: arc-linux-gcc (GCC) 13.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250716/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/spi/spi-intel.c:195:34: error: expected ')' before string constant
195 | ignore_protection_status,
| ^
| )
196 | "Do not block SPI flash chip write access even if it is write-protected (default=0)");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~vim +195 drivers/spi/spi-intel.c
188
189 static bool writeable;
190 module_param(writeable, bool, 0);
191 MODULE_PARM_DESC(writeable, "Enable write access to SPI flash chip (default=0)");
192 static bool ignore_protection_status;
193 module_param(ignore_protection_status, bool, 0);
194 MODULE_PARAM_DESC(
> 195 ignore_protection_status,
196 "Do not block SPI flash chip write access even if it is write-protected (default=0)");
197
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki