Skip to contentSkip to conversation

mm/damon: kernel-doc comments fixup for damon_callback removal

PATCH New SeongJae Park 1 participant 3 messages Jul 15, 2025

Subsystems (2)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

cover mm/damon: kernel-doc comments fixup for damon_callback removal

Patch series "mm/damon: remove damon_callback"[1] causes two kernel-doc comments build warnings[2]. Fix those.

[1] https://lore.kernel.org/[email protected]
[2] https://lore.kernel.rog/[email protected]

SeongJae Park (2):
mm/damon: add kernel-doc comment for damon_operations->cleanup_target mm/damon: remove damon_ctx->callback kernel-doc comment

 include/linux/damon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: c6255edeab2199ffde2dafae3c9df042ef4c9ef3

Signature · 1 line
2.39.5
author maintainer
#1 lore raw

PATCH 1/2 mm/damon: add kernel-doc comment for damon_operations->cleanup_target

Commit 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") on mm-unstable added cleanup_target field to damon_operations, but forgot adding the kernel-doc description. This causes a build warning. Fix it by adding the description.

Fixes 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") # mm-unstable
---
 include/linux/damon.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/damon.h +1 -0
index 34fc5407f98e..efabc3ba52ee 100644
@@ -576,6 +576,7 @@ enum damon_ops_id {
  * @get_scheme_score:		Get the score of a region for a scheme.
  * @apply_scheme:		Apply a DAMON-based operation scheme.
  * @target_valid:		Determine if the target is valid.
+ * @cleanup_target:		Clean up each target before deallocation.
  * @cleanup:			Clean up the context.
  *
  * DAMON can be extended for various address spaces and usages.  For this,
Signature · 1 line
2.39.5
author maintainer
#2 lore raw

PATCH 2/2 mm/damon: remove damon_ctx->callback kernel-doc comment

In reply to SeongJae Park

Commit 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") on mm-unstable tree removed callback field of damon_ctx, but not erased the kernel-doc comment for the field. This results in build warning. Fix it by removing the obsolete comment.

Fixes 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback")
Fixes 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") # mm-unstable
---
 include/linux/damon.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/damon.h +0 -1
index efabc3ba52ee..f13664c62ddd 100644
@@ -746,7 +746,6 @@ struct damon_attrs {
  * Accesses to other fields must be protected by themselves.
  *
  * @ops:	Set of monitoring operations for given use cases.
- * @callback:	Set of callbacks for monitoring events notifications.
  *
  * @adaptive_targets:	Head of monitoring targets (&damon_target) list.
  * @schemes:		Head of schemes (&damos) list.
Signature · 1 line
2.39.5