nfsd: don't set the ctime on delegated atime updates
Subsystems (2)
Jeff Layton
maintainerPATCH v2 1/1 nfsd: don't set the ctime on delegated atime updates
Clients will typically precede a DELEGRETURN for a delegation with delegated timestamp with a SETATTR to set the timestamps on the server to match what the client has.
knfsd implements this by using the nfsd_setattr() infrastructure, which will set ATTR_CTIME on any update that goes to notify_change(). This is problematic as it means that the client will get a spurious ctime updates when updating the atime.
POSIX unfortunately doesn't phrase it succinctly, but updating the atime due to reads should not update the ctime. In this case, the client is sending a SETATTR to update the atime on the server to match its latest value. The ctime should not be advanced in this case as that would incorrectly indicate a change to the inode.
Fix this by not implicitly setting ATTR_CTIME when ATTR_DELEG is set in __nfsd_setattr(). The decoder for FATTR4_WORD2_TIME_DELEG_MODIFY already sets ATTR_CTIME, so this is sufficient to make it skip setting the ctime on atime-only updates.
---
I had missed a place where ATTR_CTIME needed to be set in the previous patch. I think this might be a better approach.
Note that I do still see the occasional test failure due to a client bug with delegated timestamps, so this isn't enough on its own to enable them by default. Stay tuned!
---
Changes in v2:
- only implicitly set ATTR_CTIME if ATTR_DELEG isn't set
- Link to v1: https://lore.kernel.org/r/[email protected]
--- fs/nfsd/vfs.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
fs/nfsd/vfs.c +9 -1
@@ -470,7 +470,15 @@ static int __nfsd_setattr(struct dentry *dentry, struct iattr *iap)if (!iap->ia_valid)return 0 ; - iap->ia_valid |=ATTR_CTIME ; +/* +* If ATTR_DELEG is set, then this an update from a client that holds +* a delegation. If this is only an update for the atime, the ctime should +* not be changed. If the update contains the mtime too, then ATTR_CTIME +* should already be set. +*/ +if (!(iap->ia_valid &ATTR_DELEG )) + iap->ia_valid |=ATTR_CTIME ; +return notify_change (&nop_mnt_idmap, dentry, iap,NULL ); }
---
base-commit: 7351f1092b3cde79f654dc49a82d51c7ada0a1f2
change-id: 20250715-tsfix-780246904a01
Best regards,
Signature · 1 line
Jeff Layton <[email protected]>
Chuck Lever
maintainerFrom: Chuck Lever <[email protected]>
Quoted 10 lines · Jeff Layton
Clients will typically precede a DELEGRETURN for a delegation with delegated timestamp with a SETATTR to set the timestamps on the server to match what the client has.
knfsd implements this by using the
nfsd_setattr()infrastructure, which will setATTR_CTIMEon any update that goes tonotify_change(). This is problematic as it means that the client will get a spurious ctime updates when updating the atime.[...]
Applied v2 to nfsd-testing, thanks!
[1/1] nfsd: don't set the ctime on delegated atime updates
commit: c82fd6eaa88b8b0922ee2c77ec1b644418e0768a
--
Chuck Lever