Skip to contentSkip to conversation

drop unused declarations

PATCH Applied Antony Pavlov 2 participants 6 messages Jul 21, 2025 – Aug 5, 2025

lore
Share & tools
lore

Antony Pavlov

author
#0 lore raw

cover drop unused declarations

Antony Pavlov (4):
include/stdio.h: drop serial_printf() declaration include/scsi.h: drop unused declarations include/of.h: drop of_parse_dtb() declaration include/driver.h: drop unused declarations

 include/driver.h |  9 ---------
 include/of.h     |  1 -
 include/scsi.h   | 14 --------------
 include/stdio.h  |  4 ----
 4 files changed, 28 deletions(-)
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH 1/4 include/stdio.h: drop serial_printf() declaration

The serial_printf() function was removed
in the commit af347d05abb8b69f ("svn_rev_380").

Signed-off-by Antony Pavlov <[email protected]>
---
 include/stdio.h | 4 ----
 1 file changed, 4 deletions(-)
include/stdio.h +0 -4
index 50688feff4e..b4acc01bc39 100644
@@ -10,10 +10,6 @@
 /*
  * STDIO based functions (can always be used)
  */
-
-/* serial stuff */
-void serial_printf(const char *fmt, ...) __printf(1, 2);
-
 int sprintf(char *buf, const char *fmt, ...) __printf(2, 3);
 int snprintf(char *buf, size_t size, const char *fmt, ...) __printf(3, 4);
 int scnprintf(char *buf, size_t size, const char *fmt, ...) __printf(3, 4);
Signature · 1 line
2.45.2
author
#2 lore raw

PATCH 2/4 include/scsi.h: drop unused declarations

In reply to Antony Pavlov

Several U-Boot function declarations were introduced in the commit 637b3aa727b5b4710b753563ccc3ee8128d0a71b ("USB mass storage device driver initial implementation"). At the moment these declarations are unused, so drop them.

Signed-off-by Antony Pavlov <[email protected]>
---
 include/scsi.h | 14 --------------
 1 file changed, 14 deletions(-)
include/scsi.h +0 -14
index 23fc7abbaf4..cb8c95dc5ba 100644
@@ -144,20 +144,6 @@
 /* values for service action in */
 #define	SAI_READ_CAPACITY_16	0x10
 
-/****************************************************************************
- * decleration of functions which have to reside in the LowLevel Part Driver
- */
-
-void scsi_bus_reset(void);
-void scsi_low_level_init(int busdevfunc);
-
-
-/***************************************************************************
- * functions residing inside cmd_scsi.c
- */
-void scsi_init(void);
-
-
 #define SCSI_IDENTIFY				0xC0  /* not used */
 
 /* Hardware errors  */
Signature · 1 line
2.45.2
author
#3 lore raw

PATCH 3/4 include/of.h: drop of_parse_dtb() declaration

In reply to Antony Pavlov

The of_parse_dtb() function was renamed in the commit 86e787e84565e6c08696450e9d14d066f3f76056 ("of: rename of_parse_dtb to of_unflatten_dtb").

Signed-off-by Antony Pavlov <[email protected]>
---
 include/of.h | 1 -
 1 file changed, 1 deletion(-)
include/of.h +0 -1
index 2258cd501b7..f99f7763251 100644
@@ -116,7 +116,6 @@ void of_print_nodes(struct device_node *node, int indent, unsigned maxpropsize);
 void of_print_properties(struct device_node *node, unsigned maxpropsize);
 int of_diff(struct device_node *a, struct device_node *b, int indent);
 int of_probe(void);
-int of_parse_dtb(struct fdt_header *fdt);
 struct device_node *of_unflatten_dtb(const void *fdt, int size);
 struct device_node *of_unflatten_dtb_const(const void *infdt, int size);
Signature · 1 line
2.45.2
author
#4 lore raw

PATCH 4/4 include/driver.h: drop unused declarations

In reply to Antony Pavlov
Signed-off-by Antony Pavlov <[email protected]>
---
 include/driver.h | 9 ---------
 1 file changed, 9 deletions(-)
include/driver.h +0 -9
index dd50a7aa3cc..5169b959f92 100644
@@ -117,13 +117,6 @@ static inline void device_rescan(struct device *dev)
 #define device_for_each_child_safe(dev, tmpdev, child) \
 	list_for_each_entry_safe(child, tmpdev, &(dev)->children, sibling)
 
-/* Iterate through the devices of a given type. if last is NULL, the
- * first device of this type is returned. Put this pointer in as
- * 'last' to get the next device. This functions returns NULL if no
- * more devices are found.
- */
-struct device *get_device_by_type(ulong type, struct device *last);
-struct device *get_device_by_id(const char *id);
 struct device *get_device_by_name(const char *name);
 
 /* Find a device by name and if not found look up by device tree path

@@ -137,8 +130,6 @@ struct device *find_device(const char *str);
  */
 int get_free_deviceid(const char *name_template);
 
-char *deviceid_from_spec_str(const char *str, char **endp);
-
 static inline const char *dev_id(const struct device *dev)
 {
 	if (!dev)
Signature · 1 line
2.45.2
Applied
#5 lore raw
In reply to Antony Pavlov
Quoted 6 lines · Antony Pavlov

Antony Pavlov (4):
include/stdio.h: drop serial_printf() declaration include/scsi.h: drop unused declarations include/of.h: drop of_parse_dtb() declaration include/driver.h: drop unused declarations

Quoted 7 lines

include/driver.h | 9 ---------

 include/of.h     |  1 -
 include/scsi.h   | 14 --------------
 include/stdio.h  |  4 ----
 4 files changed, 28 deletions(-)

[...]

Applied, thanks!

[1/4] include/stdio.h: drop serial_printf() declaration
https://git.pengutronix.de/cgit/barebox/commit/?id=be8c8f03aa49 (link may not be stable)
[2/4] include/scsi.h: drop unused declarations
https://git.pengutronix.de/cgit/barebox/commit/?id=7f58b924f64b (link may not be stable)
[3/4] include/of.h: drop of_parse_dtb() declaration
https://git.pengutronix.de/cgit/barebox/commit/?id=03e3d2b050e4 (link may not be stable)
[4/4] include/driver.h: drop unused declarations
https://git.pengutronix.de/cgit/barebox/commit/?id=d4d15c91e32e (link may not be stable)

Best regards,

Signature · 1 line
Sascha Hauer <[email protected]>