Skip to contentSkip to conversation

arm64/xen: Set correctly bootargs property for modules

PATCH In review Frediano Ziglio via Grub-devel 2 participants 3 messages Jul 21, 2025 – Jul 25, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64/xen: Set correctly bootargs property for modules

"cmdline_size" already account for NUL terminator, you can see this in "xen_boot_binary_load".
The same property is set correctly for Xen command line.

---
 grub-core/loader/arm64/xen_boot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/loader/arm64/xen_boot.c +1 -1
index 14afec143..ed22b49e0 100644
@@ -174,7 +174,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, void *xen_boot_fdt)
 		    module->cmdline, module->cmdline, module->cmdline_size);
 
       retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "bootargs",
-				  module->cmdline, module->cmdline_size + 1);
+				  module->cmdline, module->cmdline_size);
       if (retval)
 	return grub_error (GRUB_ERR_IO, "failed to update FDT");
     }
Signature · 7 lines
2.43.0


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw

Next time when you post Xen patches please CC Xen-devel too.

Quoted 1 line · Frediano Ziglio via Grub-devel

"cmdline_size" already account for NUL terminator, you can see

You can drop quotes from here.

Quoted 1 line

this in "xen_boot_binary_load".

xen_boot_binary_load() without quotes instead...

Quoted 3 lines

The same property is set correctly for Xen command line.

I will fix these two minor issues for you.

So, Reviewed-by: Daniel Kiper <[email protected]>...

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw
Quoted 10 lines · Daniel Kiper

Next time when you post Xen patches please CC Xen-devel too.

Quoted 1 line · Frediano Ziglio via Grub-devel

"cmdline_size" already account for NUL terminator, you can see

You can drop quotes from here.

Quoted 1 line

this in "xen_boot_binary_load".

Quoted 8 lines

xen_boot_binary_load() without quotes instead...

Quoted 3 lines

The same property is set correctly for Xen command line.

I will fix these two minor issues for you.

Thanks, I'll try to remember for next time

Quoted 3 lines

So, Reviewed-by: Daniel Kiper <[email protected]>...

Daniel

Frediano

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel