Skip to contentSkip to conversation

Patch "netfs: Fix copy-to-cache so that it performs collection with ceph+fscache" has been added to the 6.15-stable tree

PATCH [email protected] 1 participant 1 message Jul 21, 2025 Filesystems netfs library

lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

netfs: Fix copy-to-cache so that it performs collection with ceph+fscache

to the 6.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
netfs-fix-copy-to-cache-so-that-it-performs-collection-with-ceph-fscache.patch
and it can be found in the queue-6.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From 4c238e30774e3022a505fa54311273add7570f13 Mon Sep 17 00:00:00 2001
From: David Howells <[email protected]>
Date: Fri, 11 Jul 2025 16:10:00 +0100
Subject: netfs: Fix copy-to-cache so that it performs collection with ceph+fscache

From: David Howells <[email protected]>

commit 4c238e30774e3022a505fa54311273add7570f13 upstream.

The netfs copy-to-cache that is used by Ceph with local caching sets up a new request to write data just read to the cache. The request is started and then left to look after itself whilst the app continues. The request gets notified by the backing fs upon completion of the async DIO write, but then tries to wake up the app because NETFS_RREQ_OFFLOAD_COLLECTION isn't set - but the app isn't waiting there, and so the request just hangs.

Fix this by setting NETFS_RREQ_OFFLOAD_COLLECTION which causes the notification from the backing filesystem to put the collection onto a work queue instead.

---
 fs/netfs/read_pgpriv2.c | 1 +
 1 file changed, 1 insertion(+)
fs/netfs/read_pgpriv2.c +1 -0
index 5bbe906a551d..080d2a6a51d9 100644
@@ -110,6 +110,7 @@ static struct netfs_io_request *netfs_pgpriv2_begin_copy_to_cache(
 	if (!creq->io_streams[1].avail)
 		goto cancel_put;
 
+	__set_bit(NETFS_RREQ_OFFLOAD_COLLECTION, &creq->flags);
 	trace_netfs_write(creq, netfs_write_trace_copy_to_cache);
 	netfs_stat(&netfs_n_wh_copy_to_cache);
 	rreq->copy_to_cache = creq;
Signature · 8 lines
2.50.1



Patches currently in stable-queue which might be from [email protected] are

queue-6.15/netfs-fix-copy-to-cache-so-that-it-performs-collection-with-ceph-fscache.patch
queue-6.15/netfs-fix-race-between-cache-write-completion-and-all_queued-being-set.patch