Skip to contentSkip to conversation

kdevops: extra scsi disk uses

PATCH New Luis Chamberlain 1 participant 3 messages Jul 22, 2025

lore
Share & tools
lore
#0 lore raw

cover kdevops: extra scsi disk uses

As suggested by Chuck, let's add scsi disk where we forgot. I just told Claude AI what to do.

Luis Chamberlain (2):
volume_group: add scsi disk support
fstests: use the scsi disk drive when available

 playbooks/roles/volume_group/tasks/guestfs.yml | 7 +++++++
 workflows/fstests/Kconfig                      | 1 +
 2 files changed, 8 insertions(+)
Signature · 1 line
2.47.2
#1 lore raw

PATCH 1/2 volume_group: add scsi disk support

Add support to use a scsi disk for the volume disk group.

Generated-by Claude AI
---
 playbooks/roles/volume_group/tasks/guestfs.yml | 7 +++++++
 1 file changed, 7 insertions(+)
playbooks/roles/volume_group/tasks/guestfs.yml +7 -0
index a5536159..0a285f16 100644
@@ -31,6 +31,13 @@
     - libvirt_extra_storage_drive_ide is defined
     - libvirt_extra_storage_drive_ide|bool
 
+- name: Set the SCSI device search pattern
+  ansible.builtin.set_fact:
+    by_id_pattern: "scsi-0QEMU_QEMU_HARDDISK_kdevops*"
+  when:
+    - libvirt_extra_storage_drive_scsi is defined
+    - libvirt_extra_storage_drive_scsi|bool
+
 - name: Verify there are block devices to search
   ansible.builtin.fail:
     msg: No supported block devices are available for NFSD.
Signature · 1 line
2.47.2
#2 lore raw

PATCH 2/2 fstests: use the scsi disk drive when available

In reply to Luis Chamberlain

As with previous small patches which forgot to add scsi disk support, also enable its use on fstests.

Generated-by Claude AI
---
 workflows/fstests/Kconfig | 1 +
 1 file changed, 1 insertion(+)
workflows/fstests/Kconfig +1 -0
index 78fafbcc..fa441c3c 100644
@@ -540,6 +540,7 @@ config FSTESTS_SPARSE_DEV
 	default "/dev/disk/by-id/nvme-QEMU_NVMe_Ctrl_kdevops1" if LIBVIRT && LIBVIRT_EXTRA_STORAGE_DRIVE_NVME
 	default "/dev/disk/by-id/virtio-kdevops1" if LIBVIRT && LIBVIRT_EXTRA_STORAGE_DRIVE_VIRTIO
 	default "/dev/disk/by-id/ata-QEMU_HARDDISK_kdevops1" if LIBVIRT && LIBVIRT_EXTRA_STORAGE_DRIVE_IDE
+	default "/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_kdevops1" if LIBVIRT && LIBVIRT_EXTRA_STORAGE_DRIVE_SCSI
 	default "/dev/nvme2n1" if TERRAFORM_AWS_INSTANCE_M5AD_4XLARGE
 	default "/dev/nvme1n1" if TERRAFORM_GCE
 	default "/dev/sdd" if TERRAFORM_AZURE
Signature · 1 line
2.47.2