Skip to contentSkip to conversation

usb: gadget: udc: renesas_usb3: drop unused module alias

PATCH In review Johan Hovold 2 participants 4 messages Jul 24, 2025 – Jul 29, 2025 USB

lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 usb: gadget: udc: renesas_usb3: drop unused module alias

Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car H3 ES1.* handling") the driver only supports OF probe so drop the unused platform module alias.

Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/gadget/udc/renesas_usb3.c +0 -1
index d23b1762e0e4..bdb88ab0ff73 100644
@@ -3024,4 +3024,3 @@ module_platform_driver(renesas_usb3_driver);
 MODULE_DESCRIPTION("Renesas USB3.0 Peripheral driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Yoshihiro Shimoda <[email protected]>");
-MODULE_ALIAS("platform:renesas_usb3");
Signature · 1 line
2.49.1
#1 lore raw

Hi Johan,

Thanks for your patch, which is now commit 7b4b5591d4551efe ("usb: gadget: udc: renesas_usb3: drop unused module alias") in usb/usb-next.

Quoted 5 lines · Johan Hovold

Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car H3 ES1.* handling") the driver only supports OF probe so drop the unused platform module alias.

Signed-off-by Johan Hovold <[email protected]>

While I don't debate the actual change, I would like to comment on the patch description. The driver only ever supported OF probe. The call to soc_device_match() was just used to override the match data for quirk handling.

drivers/usb/gadget/udc/renesas_usb3.c module_platform_driver(renesas_usb3_driver); · line 3027

Quoted 7 lines
drivers/usb/gadget/udc/renesas_usb3.c +0 -1
@@ -3024,4 +3024,3 @@ module_platform_driver(renesas_usb3_driver);
 MODULE_DESCRIPTION("Renesas USB3.0 Peripheral driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Yoshihiro Shimoda <[email protected]>");
-MODULE_ALIAS("platform:renesas_usb3");

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author
#2 lore raw

Hi Geert,

Quoted 11 lines · Geert Uytterhoeven
Quoted 5 lines · Johan Hovold

Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car H3 ES1.* handling") the driver only supports OF probe so drop the unused platform module alias.

Signed-off-by Johan Hovold <[email protected]>

While I don't debate the actual change, I would like to comment on the patch description. The driver only ever supported OF probe. The call to soc_device_match() was just used to override the match data for quirk handling.

The driver initially indeed only supported OF probe, but that changed with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use of_device_get_match_data() helper") after which the driver could at least theoretically also bind based on the platform device name.

Johan

#3 lore raw

Hi Johan,

Quoted 13 lines · Johan Hovold
Quoted 11 lines · Geert Uytterhoeven
Quoted 5 lines · Johan Hovold

Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car H3 ES1.* handling") the driver only supports OF probe so drop the unused platform module alias.

Signed-off-by Johan Hovold <[email protected]>

While I don't debate the actual change, I would like to comment on the patch description. The driver only ever supported OF probe. The call to soc_device_match() was just used to override the match data for quirk handling.

Quoted 4 lines

The driver initially indeed only supported OF probe, but that changed with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use of_device_get_match_data() helper") after which the driver could at least theoretically also bind based on the platform device name.

Oh right, now I see what you meant.
Yes, in theory the driver could bind before on a legacy platform device, but it would crash on a NULL-pointer dereference when running on anything but R-Car H3 ES1.0x ;-)

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds