bpf: Show precise rejected function when attaching to __noreturn and deny list functions
Subsystems (4)
v4 cover bpf: Show precise rejected function when attaching to __noreturn and deny list functions
Show precise rejected function when attaching fexit/fmod_ret to __noreturn functions.
Add log for attaching tracing programs to functions in deny list. Add selftest for attaching tracing programs to functions in deny list. Migrate fexit_noreturns case into tracing_failure test suite.
changes:
v4:
- change tracing_deny case attaching function (Yonghong Song)
- add Acked-by: Yafang Shao and Yonghong Song
v3:
- add tracing_deny case into existing files (Alexei)
- migrate fexit_noreturns into tracing_failure
- change SOB
https://lore.kernel.org/bpf/[email protected]/
v2:
- change verifier log message (Alexei)
- add missing Suggested-by
https://lore.kernel.org/bpf/[email protected]/
v1:
https://lore.kernel.org/all/[email protected]/
---
KaFai Wan (4):
bpf: Show precise rejected function when attaching fexit/fmod_ret to
__noreturn functions
bpf: Add log for attaching tracing programs to functions in deny list selftests/bpf: Add selftest for attaching tracing programs to
functions in deny list
selftests/bpf: Migrate fexit_noreturns case into tracing_failure test
suite
kernel/bpf/verifier.c | 5 +- .../bpf/prog_tests/fexit_noreturns.c | 9 ---- .../bpf/prog_tests/tracing_failure.c | 52 +++++++++++++++++++ .../selftests/bpf/progs/fexit_noreturns.c | 15 ------ .../selftests/bpf/progs/tracing_failure.c | 12 +++++ 5 files changed, 68 insertions(+), 25 deletions(-) delete mode 100644 tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c delete mode 100644 tools/testing/selftests/bpf/progs/fexit_noreturns.c
Signature · 1 line
2.43.0
PATCH v4 1/4 bpf: Show precise rejected function when attaching fexit/fmod_ret to __noreturn functions
With this change, we know the precise rejected function name when attaching fexit/fmod_ret to __noreturn functions from log.
$ ./fexit libbpf: prog 'fexit': BPF program load failed: -EINVAL libbpf: prog 'fexit': -- BEGIN PROG LOAD LOG -- Attaching fexit/fmod_ret to __noreturn function 'do_exit' is rejected.
--- kernel/bpf/verifier.c | 3 ++- tools/testing/selftests/bpf/progs/fexit_noreturns.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
kernel/bpf/verifier.c +2 -1
@@ -23946,7 +23946,8 @@ static int check_attach_btf_id(struct bpf_verifier_env *env) }else if ((prog->expected_attach_type ==BPF_TRACE_FEXIT || prog->expected_attach_type ==BPF_MODIFY_RETURN ) &&btf_id_set_contains (&noreturn_deny, btf_id)) { -verbose (env,"Attaching fexit/fmod_ret to __noreturn functions is rejected.\n" ); +verbose (env,"Attaching fexit/fmod_ret to __noreturn function '%s' is rejected.\n" , + tgt_info.tgt_name);return -EINVAL ; }
tools/testing/selftests/bpf/progs/fexit_noreturns.c +1 -1
@@ -8,7 +8,7 @@ char _license[] SEC("license") = "GPL"; SEC("fexit/do_exit") -__failure __msg("Attaching fexit/fmod_ret to __noreturn functions is rejected.") +__failure __msg("Attaching fexit/fmod_ret to __noreturn function 'do_exit' is rejected.") int BPF_PROG(noreturns) {return 0 ;
Signature · 1 line
2.43.0
PATCH v4 2/4 bpf: Add log for attaching tracing programs to functions in deny list
In reply to KaFai WanShow the rejected function name when attaching tracing programs to functions in deny list.
With this change, we know why tracing programs can't attach to functions like __rcu_read_lock() from log.
$ ./fentry libbpf: prog '__rcu_read_lock': BPF program load failed: -EINVAL libbpf: prog '__rcu_read_lock': -- BEGIN PROG LOAD LOG -- Attaching tracing programs to function '__rcu_read_lock' is rejected.
--- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/bpf/verifier.c +2 -0
@@ -23942,6 +23942,8 @@ static int check_attach_btf_id(struct bpf_verifier_env *env)return ret; }else if (prog->type ==BPF_PROG_TYPE_TRACING &&btf_id_set_contains (&btf_id_deny, btf_id)) { +verbose (env,"Attaching tracing programs to function '%s' is rejected.\n" , + tgt_info.tgt_name);return -EINVAL ; } else if ((prog->expected_attach_type == BPF_TRACE_FEXIT || prog->expected_attach_type == BPF_MODIFY_RETURN) &&
Signature · 1 line
2.43.0
PATCH v4 3/4 selftests/bpf: Add selftest for attaching tracing programs to functions in deny list
In reply to KaFai WanThe result:
$ tools/testing/selftests/bpf/test_progs -t tracing_failure/tracing_deny #468/3 tracing_failure/tracing_deny:OK #468 tracing_failure:OK Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
--- .../bpf/prog_tests/tracing_failure.c | 33 +++++++++++++++++++ .../selftests/bpf/progs/tracing_failure.c | 6 ++++ 2 files changed, 39 insertions(+)
tools/testing/selftests/bpf/prog_tests/tracing_failure.c +33 -0
@@ -28,10 +28,43 @@ static void test_bpf_spin_lock(bool is_spin_lock)tracing_failure__destroy (skel); } +static void test_tracing_deny (void ) +{ +struct tracing_failure *skel; +char log_buf[256 ]; +int btf_id, err; + +/* __rcu_read_lock depends on CONFIG_PREEMPT_RCU */ + btf_id =libbpf_find_vmlinux_btf_id ("__rcu_read_lock" ,BPF_TRACE_FENTRY ); +if (btf_id <=0 ) { +test__skip (); +return ; + } + + skel =tracing_failure__open (); +if (!ASSERT_OK_PTR (skel,"tracing_failure__open" )) +return ; + +bpf_program__set_autoload (skel->progs.tracing_deny, true); +bpf_program__set_log_buf (skel->progs.tracing_deny, log_buf,sizeof (log_buf)); + + err =tracing_failure__load (skel); +if (!ASSERT_ERR (err,"tracing_failure__load" )) + goto out; + +ASSERT_HAS_SUBSTR (log_buf, +"Attaching tracing programs to function '__rcu_read_lock' is rejected." , +"log_buf" ); +out: +tracing_failure__destroy (skel); +} +void test_tracing_failure (void ) {if (test__start_subtest ("bpf_spin_lock" ))test_bpf_spin_lock (true);if (test__start_subtest ("bpf_spin_unlock" ))test_bpf_spin_lock (false); +if (test__start_subtest ("tracing_deny" )) +test_tracing_deny (); }
tools/testing/selftests/bpf/progs/tracing_failure.c +6 -0
@@ -18,3 +18,9 @@ int BPF_PROG(test_spin_unlock, struct bpf_spin_lock *lock) {return 0 ; } + +SEC("?fentry/__rcu_read_lock") +int BPF_PROG (tracing_deny ) +{ +return 0 ; +}
Signature · 1 line
2.43.0
PATCH v4 4/4 selftests/bpf: Migrate fexit_noreturns case into tracing_failure test suite
In reply to KaFai WanDelete fexit_noreturns.c files and migrate the cases into tracing_failure.c files.
The result:
$ tools/testing/selftests/bpf/test_progs -t tracing_failure/fexit_noreturns #467/4 tracing_failure/fexit_noreturns:OK #467 tracing_failure:OK Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
--- .../bpf/prog_tests/fexit_noreturns.c | 9 ---- .../bpf/prog_tests/tracing_failure.c | 47 +++++++++++++------ .../selftests/bpf/progs/fexit_noreturns.c | 15 ------ .../selftests/bpf/progs/tracing_failure.c | 6 +++ 4 files changed, 39 insertions(+), 38 deletions(-) delete mode 100644 tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c delete mode 100644 tools/testing/selftests/bpf/progs/fexit_noreturns.c
tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c deleted +0 -9
@@ -1,9 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -#include <test_progs.h> -#include "fexit_noreturns.skel.h" - -void test_fexit_noreturns (void ) -{ -RUN_TESTS (fexit_noreturns); -}
tools/testing/selftests/bpf/prog_tests/tracing_failure.c +33 -14
74 lines not on this page · raw message
tools/testing/selftests/bpf/progs/fexit_noreturns.c deleted +0 -15
@@ -1,15 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -#include <linux/bpf.h> -#include <bpf/bpf_helpers.h> -#include <bpf/bpf_tracing.h> -#include "bpf_misc.h" - -char _license[] SEC("license") = "GPL"; - -SEC("fexit/do_exit") -__failure __msg("Attaching fexit/fmod_ret to __noreturn function 'do_exit' is rejected.") -int BPF_PROG(noreturns) -{ -return 0 ; -}
tools/testing/selftests/bpf/progs/tracing_failure.c +6 -0
@@ -24,3 +24,9 @@ int BPF_PROG(tracing_deny) {return 0 ; } + +SEC("?fexit/do_exit") +int BPF_PROG (fexit_noreturns ) +{ +return 0 ; +}
Signature · 1 line
2.43.0
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 6 lines · On Thu, 24 Jul 2025 23:14:50 +0800 you wrote:
Show precise rejected function when attaching fexit/fmod_ret to
__noreturnfunctions.
Add log for attaching tracing programs to functions in deny list. Add selftest for attaching tracing programs to functions in deny list. Migratefexit_noreturnscase intotracing_failuretest suite.
Quoted 6 lines
changes:
v4:
- changetracing_denycase attaching function (Yonghong Song)
- add Acked-by: Yafang Shao and Yonghong Song[...]
Here is the summary with links:
- [bpf-next,v4,1/4] bpf: Show precise rejected function when attaching fexit/fmod_ret to __noreturn functions
https://git.kernel.org/bpf/bpf-next/c/a5a6b29a700f - [bpf-next,v4,2/4] bpf: Add log for attaching tracing programs to functions in deny list https://git.kernel.org/bpf/bpf-next/c/863aab3d4dcd - [bpf-next,v4,3/4] selftests/bpf: Add selftest for attaching tracing programs to functions in deny list https://git.kernel.org/bpf/bpf-next/c/a32f6f17a74d - [bpf-next,v4,4/4] selftests/bpf: Migrate fexit_noreturns case into tracing_failure test suite https://git.kernel.org/bpf/bpf-next/c/51d3750aba79
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html