sched/task_stack: Add missing const qualifier to end_of_stack()
PATCH 1/1 sched/task_stack: Add missing const qualifier to end_of_stack()
Add missing const qualifier to the non-CONFIG_THREAD_INFO_IN_TASK version of end_of_stack() to match the CONFIG_THREAD_INFO_IN_TASK version. Fixes a warning with CONFIG_KSTACK_ERASE=y on archs that don't select THREAD_INFO_IN_TASK (such as LoongArch):
error: passing 'const struct task_struct *' to parameter of type 'struct task_struct *' discards qualifiers
The stackleak_task_low_bound() function correctly uses a const task parameter, but the legacy end_of_stack() prototype didn't like that.
Build tested on loongarch (with CONFIG_KSTACK_ERASE=y) and m68k (with CONFIG_DEBUG_STACK_USAGE=y).
--- include/linux/sched/task_stack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sched/task_stack.h +1 -1
@@ -53,7 +53,7 @@ static inline void setup_thread_stack(struct task_struct *p, struct task_struct* When the stack grows up, this is the highest address. * Beyond that position, we corrupt data on the next page. */ -static inline unsigned long *end_of_stack (struct task_struct *p) +static inline unsigned long *end_of_stack (const struct task_struct *p) {#ifdef CONFIG_STACK_GROWSUP return (unsigned long *)((unsigned long )task_thread_info (p) +THREAD_SIZE ) -1 ;
Signature · 1 line
2.34.1
Quoted 13 lines · Kees Cook
Add missing const qualifier to the non-CONFIG_THREAD_INFO_IN_TASK version of
end_of_stack()to match theCONFIG_THREAD_INFO_IN_TASKversion. Fixes a warning withCONFIG_KSTACK_ERASE=yon archs that don't selectTHREAD_INFO_IN_TASK(such as LoongArch):error: passing 'const struct
task_struct*' to parameter of type 'structtask_struct*' discards qualifiersThe
stackleak_task_low_bound()function correctly uses a const task parameter, but the legacyend_of_stack()prototype didn't like that.Build tested on loongarch (with
CONFIG_KSTACK_ERASE=y) and m68k (withCONFIG_DEBUG_STACK_USAGE=y).
Quoted 6 lines
Fixes a45728fd4120 ("LoongArch: Enable HAVE_ARCH_STACKLEAK")Reported-by Nathan Chancellor <[email protected]>Cc Youling Tang <[email protected]>Cc Huacai Chen <[email protected]>Signed-off-by Kees Cook <[email protected]>
Quoted 20 lines
--- include/linux/sched/task_stack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/sched/task_stack.h +1
-1@@ -53,7 +53,7 @@ static inline void setup_thread_stack(struct task_struct *p, struct task_struct* When the stack grows up, this is the highest address. * Beyond that position, we corrupt data on the next page. */ -static inline unsigned long *end_of_stack (struct task_struct *p) +static inline unsigned long *end_of_stack (const struct task_struct *p) {#ifdef CONFIG_STACK_GROWSUP return (unsigned long *)((unsigned long )task_thread_info (p) +THREAD_SIZE ) -1 ;Signature · 1 line
2.34.1