Skip to contentSkip to conversation

MIPS: alchemy: gpio: use new GPIO line value setter callbacks for the remaining chips

PATCH Applied Bartosz Golaszewski 2 participants 3 messages Jul 27, 2025 – Jul 28, 2025 MIPS

lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 MIPS: alchemy: gpio: use new GPIO line value setter callbacks for the remaining chips

From: Bartosz Golaszewski <[email protected]>

Previous commit missed two other places that need converting, it only came out in tests on autobuilders now. Convert the rest of the driver.

Fixes 68bdc4dc1130 ("MIPS: alchemy: gpio: use new line value setter callbacks")
Signed-off-by Bartosz Golaszewski <[email protected]>

---
Thomas: this flew under my radar until it came out in autobuilder tests now. Thomas: if it's too late for you to take it through the MIPS tree for v6.17, can you Ack it and let me take it directly through the GPIO tree? This change is needed for us to complete the rework of GPIO callbacks during the next cycle.

 arch/mips/alchemy/common/gpiolib.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
arch/mips/alchemy/common/gpiolib.c +8 -4
index 411f70ceb762..194034eba75f 100644
@@ -40,9 +40,11 @@ static int gpio2_get(struct gpio_chip *chip, unsigned offset)
 	return !!alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE);
 }
 
-static void gpio2_set(struct gpio_chip *chip, unsigned offset, int value)
+static int gpio2_set(struct gpio_chip *chip, unsigned offset, int value)
 {
 	alchemy_gpio2_set_value(offset + ALCHEMY_GPIO2_BASE, value);
+
+	return 0;
 }
 
 static int gpio2_direction_input(struct gpio_chip *chip, unsigned offset)

@@ -68,10 +70,12 @@ static int gpio1_get(struct gpio_chip *chip, unsigned offset)
 	return !!alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE);
 }
 
-static void gpio1_set(struct gpio_chip *chip,
+static int gpio1_set(struct gpio_chip *chip,
 				unsigned offset, int value)
 {
 	alchemy_gpio1_set_value(offset + ALCHEMY_GPIO1_BASE, value);
+
+	return 0;
 }
 
 static int gpio1_direction_input(struct gpio_chip *chip, unsigned offset)

@@ -97,7 +101,7 @@ struct gpio_chip alchemy_gpio_chip[] = {
 		.direction_input	= gpio1_direction_input,
 		.direction_output	= gpio1_direction_output,
 		.get			= gpio1_get,
-		.set			= gpio1_set,
+		.set_rv			= gpio1_set,
 		.to_irq			= gpio1_to_irq,
 		.base			= ALCHEMY_GPIO1_BASE,
 		.ngpio			= ALCHEMY_GPIO1_NUM,

@@ -107,7 +111,7 @@ struct gpio_chip alchemy_gpio_chip[] = {
 		.direction_input	= gpio2_direction_input,
 		.direction_output	= gpio2_direction_output,
 		.get			= gpio2_get,
-		.set			= gpio2_set,
+		.set_rv			= gpio2_set,
 		.to_irq			= gpio2_to_irq,
 		.base			= ALCHEMY_GPIO2_BASE,
 		.ngpio			= ALCHEMY_GPIO2_NUM,
Signature · 1 line
2.48.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Previous commit missed two other places that need converting, it only came out in tests on autobuilders now. Convert the rest of the driver.

Fixes 68bdc4dc1130 ("MIPS: alchemy: gpio: use new line value setter callbacks")
Signed-off-by Bartosz Golaszewski <[email protected]>

---
Thomas: this flew under my radar until it came out in autobuilder tests now. Thomas: if it's too late for you to take it through the MIPS tree for v6.17, can you Ack it and let me take it directly through the GPIO tree? This change is needed for us to complete the rework of GPIO callbacks during the next cycle.

Quoted 2 lines
 arch/mips/alchemy/common/gpiolib.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Acked-by Thomas Bogendoerfer <[email protected]>
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
author Applied
#2 lore raw
In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Quoted 4 lines · Bartosz Golaszewski

Previous commit missed two other places that need converting, it only came out in tests on autobuilders now. Convert the rest of the driver.

Applied, thanks!

[1/1] MIPS: alchemy: gpio: use new GPIO line value setter callbacks for the remaining chips

      https://git.kernel.org/brgl/linux/c/6b94bf976f9f9e6d4a6bf3218968a506c049702e

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>