iio: adc: Add Intel Dollar Cove TI PMIC ADC driver
v3 cover iio: adc: Add Intel Dollar Cove TI PMIC ADC driver
Hi,
Here is v3 of my patch to add an IIO driver for the Intel Dollar Cove TI PMIC ADC.
Changes in v3:
- "iio: Improve iio_read_channel_processed_scale() precision"
- Use div_s64() instead of div_u64() to fix -1.0 - 0.0 range
- Directly return IIO_VAL_INT from valid cases and drop the final return ret after the switch-case
- "iio: adc: Add Intel Dollar Cove TI PMIC ADC driver"
- Use new more compact DC_TI_ADC_DATA_REG_CH(x) macro
- Use regmap_set_bits() regmap_clear_bits() where applicable
- Use regmap_bulk_read() + be16_to_cpu() to read ADC value
- Use sign_extend32() for vbat_zse and vbat_ge reading in probe()
Changes in v2:
- Add new "iio: Improve iio_read_channel_processed_scale() precision" patch to the series
- Add IIO_CHAN_INFO_SCALE and provide ADC scale info for Vbat
- Add IIO_CHAN_INFO_PROCESSED which applies calibration and scaling for the VBat channel
- Address some other small review remarks
Regards,
Hans
Hans de Goede (2):
iio: Improve iio_read_channel_processed_scale() precision
iio: adc: Add Intel Dollar Cove TI PMIC ADC driver
drivers/iio/adc/Kconfig | 11 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/intel_dc_ti_adc.c | 327 ++++++++++++++++++++++++++++++ drivers/iio/inkern.c | 24 ++- 4 files changed, 359 insertions(+), 4 deletions(-) create mode 100644 drivers/iio/adc/intel_dc_ti_adc.c
Signature · 1 line
2.49.0
PATCH v3 1/2 iio: Improve iio_read_channel_processed_scale() precision
Before this change iio_read_channel_processed_scale() always assumes that channels which advertise IIO_CHAN_INFO_PROCESSED capability return IIO_VAL_INT on success.
Ignoring any fractional values from drivers which return IIO_VAL_INT_PLUS_MICRO / IIO_VAL_INT_PLUS_NANO. These fractional values might become non fractional after scaling so these should be taken into account.
While at it also error out for IIO_VAL_* values which iio_read_channel_processed_scale() does not know how to handle.
---
Changes in v3:
- Use div_s64() instead of div_u64() to fix -1.0 - 0.0 range
- Directly return IIO_VAL_INT from valid cases and drop the final return ret after the switch-case
Changes in v2:
- New patch in v2 of this patch-series
--- drivers/iio/inkern.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)
drivers/iio/inkern.c +20 -4
@@ -714,20 +714,36 @@ int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, unsigned int scale) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (chan->indio_dev); -int ret; +int ret, val2;guard (mutex)(&iio_dev_opaque->info_exist_lock);if (!chan->indio_dev->info)return -ENODEV ;if (iio_channel_has_info (chan->channel,IIO_CHAN_INFO_PROCESSED )) { - ret =iio_channel_read (chan, val,NULL , + ret =iio_channel_read (chan, val, &val2,IIO_CHAN_INFO_PROCESSED );if (ret <0 )return ret; - *val *= scale; -return ret; +switch (ret) { +case IIO_VAL_INT : + *val *= scale; +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_MICRO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000LL ); +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_NANO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000000LL ); +return IIO_VAL_INT ; +default : +dev_err_once (&chan->indio_dev->dev, +"unsupported processed IIO-val-type: %d\n" , + ret); +return -EINVAL ; + } }else { ret =iio_channel_read (chan, val,NULL ,IIO_CHAN_INFO_RAW );if (ret <0 )
Signature · 1 line
2.49.0
David Lechner
reviewerRe: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Quoted 51 lines · Hans de Goede
Before this change
iio_read_channel_processed_scale()always assumes that channels which advertiseIIO_CHAN_INFO_PROCESSEDcapability returnIIO_VAL_INTon success.Ignoring any fractional values from drivers which return
IIO_VAL_INT_PLUS_MICRO/IIO_VAL_INT_PLUS_NANO. These fractional values might become non fractional after scaling so these should be taken into account.While at it also error out for IIO_VAL_* values which
iio_read_channel_processed_scale()does not know how to handle.Signed-off-by Hans de Goede <[email protected]>---
Changes in v3:
- Usediv_s64()instead ofdiv_u64()to fix -1.0 - 0.0 range
- Directly returnIIO_VAL_INTfrom valid cases and drop the final return ret after the switch-caseChanges in v2:
- New patch in v2 of this patch-series--- drivers/iio/inkern.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)drivers/iio/inkern.c +4
-4@@ -714,20 +714,36 @@ int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, unsigned int scale) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (chan->indio_dev); -int ret; +int ret, val2;guard (mutex)(&iio_dev_opaque->info_exist_lock);if (!chan->indio_dev->info)return -ENODEV ;if (iio_channel_has_info (chan->channel,IIO_CHAN_INFO_PROCESSED )) { - ret =iio_channel_read (chan, val,NULL , + ret =iio_channel_read (chan, val, &val2,IIO_CHAN_INFO_PROCESSED );if (ret <0 )return ret; - *val *= scale; -return ret; +switch (ret) { +case IIO_VAL_INT :
drivers/iio/inkern.c int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, · line 740
Quoted 10 lines
drivers/iio/inkern.c +10
-0+ *val *= scale; +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_MICRO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000LL ); +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_NANO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000000LL ); +return IIO_VAL_INT ;
I would feel better if we had some kunit tests on this function since the negative values can be tricky. I.e. something similar to iio_test_iio_format_value_fixedpoint() that tests the 4 possible interesting cases for val and val2.
I think that would find a bug here. For example, if the processed value is -1.5 with IIO_VAL_INT_PLUS_MICRO, then *val would be -1 and *val2 would be 500_000 (before applying scale). And suppose scale is 2. The expected result would be -1.5 * 2 = -3. But the math here is:
-1 * 2 + 500_000 * 2 / 1_000_000 = -1 != -3
Quoted 9 lines
drivers/iio/inkern.c +6
-0+default : +dev_err_once (&chan->indio_dev->dev, +"unsupported processed IIO-val-type: %d\n" , + ret); +return -EINVAL ; + } }else { ret =iio_channel_read (chan, val,NULL ,IIO_CHAN_INFO_RAW );if (ret <0 )
Re: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Hi David,
Quoted 68 lines · David Lechner
Quoted 51 lines · Hans de Goede
Before this change
iio_read_channel_processed_scale()always assumes that channels which advertiseIIO_CHAN_INFO_PROCESSEDcapability returnIIO_VAL_INTon success.Ignoring any fractional values from drivers which return
IIO_VAL_INT_PLUS_MICRO/IIO_VAL_INT_PLUS_NANO. These fractional values might become non fractional after scaling so these should be taken into account.While at it also error out for IIO_VAL_* values which
iio_read_channel_processed_scale()does not know how to handle.Signed-off-by Hans de Goede <[email protected]>---
Changes in v3:
- Usediv_s64()instead ofdiv_u64()to fix -1.0 - 0.0 range
- Directly returnIIO_VAL_INTfrom valid cases and drop the final return ret after the switch-caseChanges in v2:
- New patch in v2 of this patch-series--- drivers/iio/inkern.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)drivers/iio/inkern.c +4
-4@@ -714,20 +714,36 @@ int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, unsigned int scale) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (chan->indio_dev); -int ret; +int ret, val2;guard (mutex)(&iio_dev_opaque->info_exist_lock);if (!chan->indio_dev->info)return -ENODEV ;if (iio_channel_has_info (chan->channel,IIO_CHAN_INFO_PROCESSED )) { - ret =iio_channel_read (chan, val,NULL , + ret =iio_channel_read (chan, val, &val2,IIO_CHAN_INFO_PROCESSED );if (ret <0 )return ret; - *val *= scale; -return ret; +switch (ret) { +case IIO_VAL_INT :drivers/iio/inkern.c int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, · line 740
Quoted 10 lines
drivers/iio/inkern.c +10
-0+ *val *= scale; +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_MICRO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000LL ); +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_NANO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000000LL ); +return IIO_VAL_INT ;I would feel better if we had some kunit tests on this function since the negative values can be tricky. I.e. something similar to
iio_test_iio_format_value_fixedpoint()that tests the 4 possible interesting cases for val and val2.
Quoted 7 lines
I think that would find a bug here. For example, if the processed value is -1.5 with
IIO_VAL_INT_PLUS_MICRO, then *val would be -1 and *val2 would be 500_000 (before applying scale). And suppose scale is 2. The expected result would be -1.5 * 2 = -3. But the math here is:-1 * 2 + 500_000 * 2 / 1_000_000 = -1 != -3
Ack, after looking at iio_format_value and the kunit test for this I believe I know how this is supposed to work now.
Note that it seems that iio_convert_raw_to_processed_unlocked() also seems to get this wrong when the channel scale attribute is smaller then -1, e.g. your -1.5. Actually it seems that the code in iio_convert_raw_to_processed_unlocked() is making the exact same mistake you are highlighting in my code :)
I'll prepare a patch series to try and deal with this.
Regards,
Hans
Re: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Hi,
Quoted 82 lines · Hans de Goede
Hi David,
Quoted 68 lines · David Lechner
Quoted 51 lines · Hans de Goede
Before this change
iio_read_channel_processed_scale()always assumes that channels which advertiseIIO_CHAN_INFO_PROCESSEDcapability returnIIO_VAL_INTon success.Ignoring any fractional values from drivers which return
IIO_VAL_INT_PLUS_MICRO/IIO_VAL_INT_PLUS_NANO. These fractional values might become non fractional after scaling so these should be taken into account.While at it also error out for IIO_VAL_* values which
iio_read_channel_processed_scale()does not know how to handle.Signed-off-by Hans de Goede <[email protected]>---
Changes in v3:
- Usediv_s64()instead ofdiv_u64()to fix -1.0 - 0.0 range
- Directly returnIIO_VAL_INTfrom valid cases and drop the final return ret after the switch-caseChanges in v2:
- New patch in v2 of this patch-series--- drivers/iio/inkern.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)drivers/iio/inkern.c +4
-4@@ -714,20 +714,36 @@ int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, unsigned int scale) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (chan->indio_dev); -int ret; +int ret, val2;guard (mutex)(&iio_dev_opaque->info_exist_lock);if (!chan->indio_dev->info)return -ENODEV ;if (iio_channel_has_info (chan->channel,IIO_CHAN_INFO_PROCESSED )) { - ret =iio_channel_read (chan, val,NULL , + ret =iio_channel_read (chan, val, &val2,IIO_CHAN_INFO_PROCESSED );if (ret <0 )return ret; - *val *= scale; -return ret; +switch (ret) { +case IIO_VAL_INT :drivers/iio/inkern.c int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, · line 740
Quoted 10 lines
drivers/iio/inkern.c +10
-0+ *val *= scale; +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_MICRO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000LL ); +return IIO_VAL_INT ; +case IIO_VAL_INT_PLUS_NANO : + *val *= scale; + *val +=div_s64 ((s64 )val2 * scale,1000000000LL ); +return IIO_VAL_INT ;I would feel better if we had some kunit tests on this function since the negative values can be tricky. I.e. something similar to
iio_test_iio_format_value_fixedpoint()that tests the 4 possible interesting cases for val and val2.Quoted 7 lines
I think that would find a bug here. For example, if the processed value is -1.5 with
IIO_VAL_INT_PLUS_MICRO, then *val would be -1 and *val2 would be 500_000 (before applying scale). And suppose scale is 2. The expected result would be -1.5 * 2 = -3. But the math here is:-1 * 2 + 500_000 * 2 / 1_000_000 = -1 != -3
Ack, after looking at
iio_format_valueand the kunit test for this I believe I know how this is supposed to work now.
Quoted 7 lines
Note that it seems that
iio_convert_raw_to_processed_unlocked()also seems to get this wrong when the channel scale attribute is smaller then -1, e.g. your -1.5. Actually it seems that the code iniio_convert_raw_to_processed_unlocked()is making the exact same mistake you are highlighting in my code :)I'll prepare a patch series to try and deal with this.
Ok, attached is a teaser of the patch-series I'm working on.
The first 2 patches fix 2 bugs in iio_convert_raw_to_processed() which I noticed while working on this.
The third patch factors multiplication of a type, val, val2 integer triplet by some integer number and storing the result in an integer out into a new iio_mutiply_value() helper. For re-use and so that a kunit-test can be written.
Patch 4 is a new version of the patch improving iio_read_channel_processed_scale() precision using this helper.
What is missing for posting a new version is a kunit test for the new helper. I hope to be able to work on that tomorrow.
Regards,
Hans
From 841797bc90e32f366a1ee4eaa5f3a26747546f7c Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Sun, 10 Aug 2025 21:49:35 +0200
Subject: [PATCH 1/4] iio: consumers: Fix handling of negative channel scale in
iio_convert_raw_to_processed()
There is an issue with the handling of negative channel scales in iio_convert_raw_to_processed_unlocked() when the channel-scale is of the IIO_VAL_INT_PLUS_[MICRO|NANO] type:
Things work for channel-scale values > -1.0 and < 0.0 because of the use of signed values in:
*processed += div_s64(raw64 * (s64)scale_val2 * scale, 1000000LL);
Things will break however for scale values < -1.0. Lets for example say that raw = 2, (caller-provided)scale = 10 and (channel)scale_val = -1.5.
The result should then be 2 * 10 * -1.5 = -30.
channel-scale = -1.5 means scale_val = -1 and scale_val2 = 500000, now lets see what gets stored in processed:
1. *processed = raw64 * scale_val * scale;
2. *processed += raw64 * scale_val2 * scale / 1000000LL;
1. Sets processed to 2 * -1 * 10 = -20
2. Adds 2 * 500000 * 10 / 1000000 = 10 to processed
And the end result is processed = -20 + 10 = -10, which is not correct.
Fix this by always using the abs value of both scale_val and scale_val2 and if either is negative multiply the end-result by -1.
Note there seems to be an unwritten rule about negative IIO_VAL_INT_PLUS_[MICRO|NANO] values that:
i. values > -1.0 and < 0.0 are written as val=0 val2=-xxx
ii. values <= -1.0 are written as val=-xxx val2=xxx
But iio_format_value() will also correctly display a third option:
iii. values <= -1.0 written as val=-xxx val2=-xxx
Since iio_format_value() uses abs(val) when val2 < 0.
This fix also makes iio_convert_raw_to_processed() properly handle channel-scales using this third option.
---
Changes in v4:
- New patch in v4 of this patch-set
--- drivers/iio/inkern.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-)
drivers/iio/inkern.c +9 -14
@@ -604,7 +604,7 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, {int scale_type, scale_val, scale_val2;int offset_type, offset_val, offset_val2; -s64 raw64 = raw; +s64 denominator, raw64 = raw; offset_type =iio_channel_read (chan, &offset_val, &offset_val2,IIO_CHAN_INFO_OFFSET );
@@ -648,20 +648,15 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, *processed = raw64 * scale_val * scale;break ;case IIO_VAL_INT_PLUS_MICRO : -if (scale_val2 <0 ) - *processed = -raw64 * scale_val * scale; -else - *processed = raw64 * scale_val * scale; - *processed +=div_s64 (raw64 * (s64 )scale_val2 * scale, -1000000LL ); -break ;case IIO_VAL_INT_PLUS_NANO : -if (scale_val2 <0 ) - *processed = -raw64 * scale_val * scale; -else - *processed = raw64 * scale_val * scale; - *processed +=div_s64 (raw64 * (s64 )scale_val2 * scale, -1000000000LL ); +switch (scale_type) { +case IIO_VAL_INT_PLUS_MICRO : denominator =1000000LL ;break ; +case IIO_VAL_INT_PLUS_NANO : denominator =1000000000LL ;break ; + } + *processed = raw64 * scale *abs (scale_val); + *processed +=div_s64 (raw64 * scale *abs (scale_val2), denominator); +if (scale_val <0 || scale_val2 <0 ) + *processed *=-1 ;break ;case IIO_VAL_FRACTIONAL : *processed = div_s64(raw64 * (s64)scale_val * scale,
Signature · 1 line
2.49.0
From 62e1c0dd18648ecf262bb2b5b7460c339e7521c6 Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Sun, 10 Aug 2025 22:48:01 +0200
Subject: [PATCH 2/4] iio: consumers: Fix offset handling in
iio_convert_raw_to_processed()
Fix iio_convert_raw_to_processed() offset handling for channels without a scale attribute.
The offset has been applied to the raw64 value not to the original raw value. Use the raw64 value so that the offset is taken into account.
---
Changes in v4:
- New patch in v4 of this patch-set
--- drivers/iio/inkern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/inkern.c +1 -1
@@ -639,7 +639,7 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,* If no channel scaling is available apply consumer scale to * raw value and return. */ - *processed = raw * scale; + *processed = raw64 * scale;return 0 ; }
Signature · 1 line
2.49.0
From 3ecd9534379532b69fdb905807a56f231aa19135 Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Sun, 10 Aug 2025 22:40:45 +0200
Subject: [PATCH 3/4] iio: consumers: Add an iio_multiply_value() helper
function
The channel-scale handling in iio_convert_raw_to_processed() in essence does the following:
processed = raw * caller-provided-scale * channel-scale
Which can also be written as:
multiplier = raw * caller-provided-scale
iio-val = channel-scale
processed = multiplier * iio-val
Where iioval is a set of IIO_VAL_* type + val + val2 integers, being able to handle multiplication of iio-values like this is something which is useful to have in general and as previous bugfixes to iio_convert_raw_to_processed() have shown also tricky to implement.
Split the iio-value multiplication code from iio_convert_raw_to_processed() out into a new iio_multiply_value() helper. This serves multiple purposes:
1. Having this split out allows writing a kunit test for this.
2. Having this split out allows re-use to get better precision when scaling values in iio_read_channel_processed_scale().
---
Changes in v4:
- New patch in v4 of this patch-set
--- drivers/iio/inkern.c | 64 +++++++++++++++++++++--------------- include/linux/iio/consumer.h | 18 ++++++++++ 2 files changed, 56 insertions(+), 26 deletions(-)
drivers/iio/inkern.c +38 -26
82 lines not on this page · raw message
include/linux/iio/consumer.h +18 -0
@@ -381,6 +381,24 @@ int iio_read_channel_offset(struct iio_channel *chan, int *val,int iio_read_channel_scale (struct iio_channel *chan,int *val,int *val2); +/** +* iio_multiply_value() - Multiply an iio value +* @result: Destination pointer for the multiplication result +* @multiplier: Multiplier. +* @type: One of the IIO_VAL_* constants. This decides how the val +* and val2 parameters are interpreted. +* @val: Value being multiplied. +* @val2: Value being multiplied. val2 use depends on type. +* +* Multiply an iio value with a s64 multiplier storing the result as +* IIO_VAL_INT. This is typically used for scaling. +* +* Returns: +* IIO_VAL_INT on success or a negative error-number on failure. +*/ +int iio_multiply_value (int *result,s64 multiplier, +unsigned int type,int val,int val2); +/** * iio_convert_raw_to_processed() - Converts a raw value to a processed value * @chan: The channel being queried
Signature · 1 line
2.49.0
From f8372957c6b51ae30e95015e151d42aec709c179 Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Sun, 10 Aug 2025 23:03:41 +0200
Subject: [PATCH 4/4] iio: Improve iio_read_channel_processed_scale() precision
Before this change iio_read_channel_processed_scale() always assumes that channels which advertise IIO_CHAN_INFO_PROCESSED capability return IIO_VAL_INT on success.
Ignoring any fractional values from drivers which return IIO_VAL_INT_PLUS_MICRO / IIO_VAL_INT_PLUS_NANO. These fractional values might become non fractional after scaling so these should be taken into account for better precision.
Use the new iio_multiply_value() helper to do proper scaling taking the fractionional values into account.
---
Changes in v4
- Use the new iio_multiply_value() helper instead of DYI code
--- drivers/iio/inkern.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/iio/inkern.c +3 -4
@@ -721,20 +721,19 @@ int iio_read_channel_processed_scale(struct iio_channel *chan, int *val, unsigned int scale) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (chan->indio_dev); -int ret; +int ret, val2;guard (mutex)(&iio_dev_opaque->info_exist_lock);if (!chan->indio_dev->info)return -ENODEV ;if (iio_channel_has_info (chan->channel,IIO_CHAN_INFO_PROCESSED )) { - ret =iio_channel_read (chan, val,NULL , + ret =iio_channel_read (chan, val, &val2,IIO_CHAN_INFO_PROCESSED );if (ret <0 )return ret; - *val *= scale; -return ret; +return iio_multiply_value (val, scale, ret, *val, val2); }else { ret =iio_channel_read (chan, val,NULL ,IIO_CHAN_INFO_RAW );if (ret <0 )
Signature · 1 line
2.49.0
Re: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Quoted 3 lines · Hans de Goede
Quoted 2 lines · Hans de Goede
Quoted 1 line · David Lechner
On 7/27/25 4:06 PM, Hans de Goede wrote:
...
drivers/iio/inkern.c static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, · line 654
Quoted 3 lines
drivers/iio/inkern.c +3
-0+switch (scale_type) { +case IIO_VAL_INT_PLUS_MICRO : denominator =1000000LL ;break ; +case IIO_VAL_INT_PLUS_NANO : denominator =1000000000LL ;break ;
(s64)MICRO
(s64)NANO
?
Quoted 1 line
(quoted diff) +1
-0+ }
...
drivers/iio/inkern.c static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, · line 684
Quoted 6 lines
drivers/iio/inkern.c +4
-0+ ret =iio_multiply_value (processed, raw64 * scale, + scale_type, scale_val, scale_val2); +if (ret <0 ) +return ret;return 0 ;
Simply return iio_...(...); ?
...
include/linux/iio/consumer.h int iio_read_channel_offset(struct iio_channel *chan, int *val, · line 400
Quoted 2 lines
include/linux/iio/consumer.h +2
-0+int iio_multiply_value (int *result,s64 multiplier, +unsigned int type,int val,int val2);
There is room for type in the previous line.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Hi,
Quoted 7 lines · Andy Shevchenko
Quoted 3 lines · Hans de Goede
Quoted 2 lines · Hans de Goede
Quoted 1 line · David Lechner
On 7/27/25 4:06 PM, Hans de Goede wrote:
...
Quoted 7 lines
drivers/iio/inkern.c static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, · line 654
Quoted 3 lines
drivers/iio/inkern.c +3
-0+switch (scale_type) { +case IIO_VAL_INT_PLUS_MICRO : denominator =1000000LL ;break ; +case IIO_VAL_INT_PLUS_NANO : denominator =1000000000LL ;break ;(s64)MICRO
(s64)NANO
?
Ack.
Quoted 10 lines
...
drivers/iio/inkern.c static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, · line 684
Quoted 6 lines
drivers/iio/inkern.c +4
-0+ ret =iio_multiply_value (processed, raw64 * scale, + scale_type, scale_val, scale_val2); +if (ret <0 ) +return ret;return 0 ;Simply return iio_...(...); ?
That will change the return value on success from 0 to IIO_VAL_INT, which is 1 not 0.
Quoted 6 lines
...
include/linux/iio/consumer.h int iio_read_channel_offset(struct iio_channel *chan, int *val, · line 400
Quoted 2 lines
include/linux/iio/consumer.h +2
-0+int iio_multiply_value (int *result,s64 multiplier, +unsigned int type,int val,int val2);There is room for type in the previous line.
type, val and val2 is a triplet which belongs together, since it does not matter for the number of lines this takes it seems better to keep the 3 together.
Regards,
Hans
Re: [PATCH v3 1/2] iio: Improve iio_read_channel_processed_scale() precision
Quoted 5 lines · Hans de Goede
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Hans de Goede
Quoted 2 lines · Hans de Goede
Quoted 1 line · David Lechner
On 7/27/25 4:06 PM, Hans de Goede wrote:
...
Quoted 11 lines
Quoted 8 lines
drivers/iio/inkern.c static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, · line 684
Quoted 6 lines
drivers/iio/inkern.c +4
-0+ ret =iio_multiply_value (processed, raw64 * scale, + scale_type, scale_val, scale_val2); +if (ret <0 ) +return ret;return 0 ;Simply return iio_...(...); ?
That will change the return value on success from 0 to
IIO_VAL_INT, which is 1 not 0.
Indeed, thanks for elaboration.
...
Quoted 8 lines
Quoted 4 lines
include/linux/iio/consumer.h int iio_read_channel_offset(struct iio_channel *chan, int *val, · line 400
Quoted 2 lines
include/linux/iio/consumer.h +2
-0+int iio_multiply_value (int *result,s64 multiplier, +unsigned int type,int val,int val2);There is room for type in the previous line.
type, val and val2 is a triplet which belongs together, since it does not matter for the number of lines this takes it seems better to keep the 3 together.
I was thinking about the same, but I can't surely deduce this from the names of parameters. I agree with your initial split.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v3 2/2 iio: adc: Add Intel Dollar Cove TI PMIC ADC driver
In reply to Hans de GoedeIntel has 2 completely different "Dollar Cove" PMICs for its Bay Trail / Cherry Trail SoCs. One is made by X-Powers and is called the AXP288. The AXP288's GPADC is already supported by the X-Powers AXP288 ADC driver.
The other "Dollar Cove" PMIC is made by TI and does not have any clear TI denomination, its MFD driver calls it the "Intel Dollar Cove TI PMIC".
Add a driver for the Intel Dollar Cove TI PMIC's general purpose ADC, binding to the "chtdc_ti_adc" MFD cell of the MFD driver.
The "cht" in the cell name comes from Cherry Trail, but it turns out that just like the AXP288 the Intel Dollar Cove TI PMIC is also used with both Intel Bay Trail and Intel Cherry Trail SoCs, so this new ADC driver does not include the cht part in its name.
This is loosely based on kernel/drivers/iio/adc/iio_dc_ti_gpadc.c from the Acer A1-840 Android kernel source-code archive named:
"App. Guide_Acer_20151221_A_A.zip"
which is distributed by Acer from the Acer A1-840 support page:
https://www.acer.com/us-en/support/product-support/A1-840/downloads
---
Changes in v3:
- Use new more compact DC_TI_ADC_DATA_REG_CH(x) macro
- Use regmap_set_bits() regmap_clear_bits() where applicable
- Use regmap_bulk_read() + be16_to_cpu() to read ADC value
- Use sign_extend32() for vbat_zse and vbat_ge reading in probe()
Changes in v2:
- Add IIO_CHAN_INFO_SCALE and provide ADC scale info for Vbat
- Add IIO_CHAN_INFO_PROCESSED which applies calibration and scaling for the VBat channel
- Address some other small review remarks
--- drivers/iio/adc/Kconfig | 11 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/intel_dc_ti_adc.c | 327 ++++++++++++++++++++++++++++++ 3 files changed, 339 insertions(+) create mode 100644 drivers/iio/adc/intel_dc_ti_adc.c
drivers/iio/adc/Kconfig +11 -0
@@ -723,6 +723,17 @@ config INGENIC_ADC This driver can also be built as a module. If so, the module will be called ingenic_adc. +config INTEL_DC_TI_ADC + tristate "Intel Bay / Cherry Trail Dollar Cove TI ADC driver" + depends on INTEL_SOC_PMIC_CHTDC_TI + help + Say yes here to have support for the Dollar Cove TI PMIC ADC device. + Depending on platform configuration, this general purpose ADC can be + used for sensors such as battery voltage and thermal resistors. + + To compile this driver as a module, choose M here: the module will be + called intel_dc_ti_adc. + config INTEL_MRFLD_ADC tristate "Intel Merrifield Basin Cove ADC driver" depends on INTEL_SOC_PMIC_MRFLD
drivers/iio/adc/Makefile +1 -0
@@ -67,6 +67,7 @@ obj-$(CONFIG_IMX8QXP_ADC) += imx8qxp-adc.o obj-$(CONFIG_IMX93_ADC) += imx93_adc.o obj-$(CONFIG_INA2XX_ADC) += ina2xx-adc.o obj-$(CONFIG_INGENIC_ADC) += ingenic-adc.o +obj-$(CONFIG_INTEL_DC_TI_ADC) += intel_dc_ti_adc.o obj-$(CONFIG_INTEL_MRFLD_ADC) += intel_mrfld_adc.o obj-$(CONFIG_LP8788_ADC) += lp8788_adc.o obj-$(CONFIG_LPC18XX_ADC) += lpc18xx_adc.o
drivers/iio/adc/intel_dc_ti_adc.c new file +327 -0
327 lines not on this page · raw message
Signature · 1 line
2.49.0
Jonathan Cameron
maintainerQuoted 15 lines · On Sun, 27 Jul 2025 23:06:39 +0200 Hans de Goede <[email protected]> wrote:
Intel has 2 completely different "Dollar Cove" PMICs for its Bay Trail / Cherry Trail SoCs. One is made by X-Powers and is called the AXP288. The AXP288's GPADC is already supported by the X-Powers AXP288 ADC driver.
The other "Dollar Cove" PMIC is made by TI and does not have any clear TI denomination, its MFD driver calls it the "Intel Dollar Cove TI PMIC".
Add a driver for the Intel Dollar Cove TI PMIC's general purpose ADC, binding to the "
chtdc_ti_adc" MFD cell of the MFD driver.The "cht" in the cell name comes from Cherry Trail, but it turns out that just like the AXP288 the Intel Dollar Cove TI PMIC is also used with both Intel Bay Trail and Intel Cherry Trail SoCs, so this new ADC driver does not include the cht part in its name.
Quoted 7 lines
This is loosely based on
kernel/drivers/iio/adc/iio_dc_ti_gpadc.cfrom the Acer A1-840 Android kernel source-code archive named:
"App. Guide_Acer_20151221_A_A.zip"
which is distributed by Acer from the Acer A1-840 support page:
https://www.acer.com/us-en/support/product-support/A1-840/downloadsSigned-off-by Hans de Goede <[email protected]>
Looks good to me. I'll let it sit on list for a few days though to give others time to take a final look. It's holiday season for many so if I do apply it and we get follow on feedback we can deal with it as patches on top.
Thanks,
Jonathan
David Lechner
reviewerOn 7/27/25 4:06 PM, Hans de Goede wrote:
...
Quoted 23 lines
drivers/iio/adc/intel_dc_ti_adc.c new file +23
-0+static const struct iio_chan_spec dc_ti_adc_channels[] = { + { + .indexed =1 , + .type =IIO_VOLTAGE , + .channel =DC_TI_ADC_VBAT , + .address =DC_TI_ADC_DATA_REG_CH (0 ), + .datasheet_name ="CH0" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_PROCESSED ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_PMICTEMP , + .address =DC_TI_ADC_DATA_REG_CH (1 ), + .datasheet_name ="CH1" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_BATTEMP , + .address =DC_TI_ADC_DATA_REG_CH (2 ), + .datasheet_name ="CH2" ,
drivers/iio/adc/intel_dc_ti_adc.c line 93
Quoted 10 lines
drivers/iio/adc/intel_dc_ti_adc.c new file +10
-0+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + }, { + .indexed = 1, + .type = IIO_TEMP, + .channel = DC_TI_ADC_SYSTEMP0, + .address = DC_TI_ADC_DATA_REG_CH(3), + .datasheet_name = "CH3", + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + } +};
Question for Jonathan: If we don't know the scale on these temperature channels, should we implement IIO_CHAN_INFO_SCALE and just always return an error? My understanding is that by not implementing it, the scale is assumed to be 1, which likely isn't correct in in this case.
Quoted 35 lines · On Tue, 29 Jul 2025 12:50:36 -0500 David Lechner <[email protected]> wrote:
On 7/27/25 4:06 PM, Hans de Goede wrote:
...
Quoted 31 lines
drivers/iio/adc/intel_dc_ti_adc.c new file +31
-0+static const struct iio_chan_spec dc_ti_adc_channels[] = { + { + .indexed =1 , + .type =IIO_VOLTAGE , + .channel =DC_TI_ADC_VBAT , + .address =DC_TI_ADC_DATA_REG_CH (0 ), + .datasheet_name ="CH0" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_PROCESSED ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_PMICTEMP , + .address =DC_TI_ADC_DATA_REG_CH (1 ), + .datasheet_name ="CH1" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_BATTEMP , + .address =DC_TI_ADC_DATA_REG_CH (2 ), + .datasheet_name ="CH2" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_SYSTEMP0 , + .address =DC_TI_ADC_DATA_REG_CH (3 ), + .datasheet_name ="CH3" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ),
Quoted 8 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ } +};Question for Jonathan: If we don't know the scale on these temperature channels, should we implement
IIO_CHAN_INFO_SCALEand just always return an error? My understanding is that by not implementing it, the scale is assumed to be 1, which likely isn't correct in in this case.
Good question. We have quite a bit of precedence of just
not providing scale in these cases. The docs for the main block of _scale do say
"If known for a device, scale to be applied to <type>Y[_name]_raw
post addition of <type>[Y][_name]_offset in order to obtain the measured value in <type> units as specified in <type>[Y][_name]_raw documentation. "
Rather than trying to fix all those, shall we tweak the docs to say that scale is assumed to be 1 if offset is provided?
If neither is there, the channel can be _PROCESSED anyway.
Your suggestion of returning an error would have been somewhat neat long ago, but now I think it will just be too confusing for userspace.
Jonathan
Quoted 2 lines
Jonathan Cameron
maintainerQuoted 59 lines · On Thu, 31 Jul 2025 12:12:55 +0100 Jonathan Cameron…
Quoted 35 lines · On Tue, 29 Jul 2025 12:50:36 -0500 David Lechner <[email protected]> wrote:
On 7/27/25 4:06 PM, Hans de Goede wrote:
...
Quoted 31 lines
drivers/iio/adc/intel_dc_ti_adc.c new file +31
-0+static const struct iio_chan_spec dc_ti_adc_channels[] = { + { + .indexed =1 , + .type =IIO_VOLTAGE , + .channel =DC_TI_ADC_VBAT , + .address =DC_TI_ADC_DATA_REG_CH (0 ), + .datasheet_name ="CH0" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_PROCESSED ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_PMICTEMP , + .address =DC_TI_ADC_DATA_REG_CH (1 ), + .datasheet_name ="CH1" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_BATTEMP , + .address =DC_TI_ADC_DATA_REG_CH (2 ), + .datasheet_name ="CH2" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ), + }, { + .indexed =1 , + .type =IIO_TEMP , + .channel =DC_TI_ADC_SYSTEMP0 , + .address =DC_TI_ADC_DATA_REG_CH (3 ), + .datasheet_name ="CH3" , + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ),Quoted 8 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ } +};Question for Jonathan: If we don't know the scale on these temperature channels, should we implement
IIO_CHAN_INFO_SCALEand just always return an error? My understanding is that by not implementing it, the scale is assumed to be 1, which likely isn't correct in in this case.Good question. We have quite a bit of precedence of just
not providing scale in these cases. The docs for the main block of_scaledo say"If known for a device, scale to be applied to <type>Y[_name]_raw
post addition of <type>[Y][_name]_offset in order to obtain the measured value in <type> units as specified in <type>[Y][_name]_raw documentation. "Rather than trying to fix all those, shall we tweak the docs to say that scale is assumed to be 1 if offset is provided?
Quoted 7 lines
If neither is there, the channel can be
_PROCESSEDanyway.Your suggestion of returning an error would have been somewhat neat long ago, but now I think it will just be too confusing for userspace.
Jonathan
Just a quick note. I looked through the driver again the other day and other than the bug (and request for tests) that David had on patch 1 this looks good to me.
I completely missed that bug so thanks David!
Jonathan
Quoted 4 lines
Quoted 2 lines