Skip to contentSkip to conversation

wic: sdimage-2part-efi: Add rootwait kernel param

PATCH In review Andrew Davis 4 participants 12 messages Jul 28, 2025 – Jul 29, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 wic: sdimage-2part-efi: Add rootwait kernel param

This is important for many boot media such as MMC/SD as there may be a delay in mounting rootfs which can cause boot failure if kernel does not wait for the rootfs. Add this as one of the default params given to the kernel. This is already the case for most U-Boot kernel cmd lines, this adds the same when doing EFI boot.

---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -1
index ae38daa7..7252411c 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/3 wic: sdimage-2part-efi: Add console kernel param

This is already set for AM64x as that platform requires it, it is valid for all K3 platforms. Like AM64x other platforms might drop this from the DTB making it required for them also.

---
 meta-ti-bsp/conf/machine/include/am64xx.inc | 2 --
 meta-ti-bsp/conf/machine/include/k3.inc     | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
meta-ti-bsp/conf/machine/include/am64xx.inc +0 -2
index 56b56afe..49e996c8 100644
@@ -34,5 +34,3 @@ TFA_BOARD = "lite"
 OPTEEMACHINE = "k3-am64x"
 
 MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
-
-TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
meta-ti-bsp/conf/machine/include/k3.inc +1 -1
index 7ec6b51e..572eb1cc 100644
@@ -51,7 +51,7 @@ MACHINE_FEATURES += "efi"
 
 WKS_FILE ?= "${@bb.utils.contains("MACHINE_FEATURES", "efi", "sdimage-2part-efi.wks.in", "sdimage-2part.wks", d)}"
 
-TI_WKS_BOOTLOADER_APPEND ?= ""
+TI_WKS_BOOTLOADER_APPEND ?= "console=ttyS2,115200n8"
 
 do_image_wic[depends] += "virtual/bootloader:do_deploy"
 
Signature · 1 line
2.39.2
#2 lore raw

PATCH 3/3 wic: sdimage-2part-efi: Remove 3 second menu delay

In reply to Andrew Davis

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -1
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
Signature · 1 line
2.39.2
#3 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

Quoted 19 lines
---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -1
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
Signature · 1 line
2.39.2
#4 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 29 lines
Quoted 19 lines
---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--
Quoted 1 line

2.39.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18840): https://lists.yoctoproject.org/g/meta-ti/message/18840
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#5 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 10 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 6 lines
Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

#6 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 17 lines · Denys Dmytriyenko
Quoted 15 lines · Khem Raj
Quoted 12 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

Quoted 6 lines
Quoted 1 line

for development, this sounds good, for production not so much.

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

#7 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 20 lines · Khem Raj via lists.yoctoproject.org
Quoted 19 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 7 lines
Quoted 4 lines

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Is there already something in the system that we could use to drive a variable that we can stick into the file? Like EXTRA_IMAGE_FEATURES? I know there used to be a debug-tweaks that got broken out into multiple features. Maybe create a new one?

TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES", "wks-debug-timeout", "3", "0 ",d)}'

bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"

Would that work?

Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
---
  meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
  # supports EFI.  Boot files are located in the first vfat partition with extra
  # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
  part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
  part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#8 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 37 lines · Ryan Eatmon
Quoted 20 lines · Khem Raj via lists.yoctoproject.org
Quoted 19 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 7 lines
Quoted 4 lines

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Is there already something in the system that we could use to drive a variable that we can stick into the file? Like EXTRA_IMAGE_FEATURES? I know there used to be a debug-tweaks that got broken out into multiple features. Maybe create a new one?

Quoted 8 lines

TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES", "wks-debug-timeout", "3", "0 ",d)}'

bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"

Would that work?

probably, it can make it easier for sure.

Quoted 38 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
---
  meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
  # supports EFI.  Boot files are located in the first vfat partition with extra
  # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
  part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
  part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Ryan Eatmon [email protected]
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS

#9 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

In reply to Ryan Eatmon
Quoted 31 lines · Ryan Eatmon
Quoted 20 lines · Khem Raj via lists.yoctoproject.org
Quoted 19 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 7 lines
Quoted 4 lines

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Quoted 7 lines

Is there already something in the system that we could use to drive a variable that we can stick into the file? Like EXTRA_IMAGE_FEATURES? I know there used to be a debug-tweaks that got broken out into multiple features. Maybe create a new one?

TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES", "wks-debug-timeout", "3", "0 ",d)}'

Should probably make it more generic, not wks. I'd imagine it can be shared for U-boot and EFI/GRUB, so maybe bootloader-timeout or something?

Quoted 38 lines

bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"

Would that work?

Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
---
 meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
 # supports EFI.  Boot files are located in the first vfat partition with extra
 # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
 part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
 part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#10 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 37 lines · Denys Dmytriyenko
Quoted 36 lines · Ryan Eatmon
Quoted 20 lines · Khem Raj via lists.yoctoproject.org
Quoted 19 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 7 lines
Quoted 4 lines

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Is there already something in the system that we could use to drive a variable that we can stick into the file? Like EXTRA_IMAGE_FEATURES? I know there used to be a debug-tweaks that got broken out into multiple features. Maybe create a new one?

Quoted 6 lines
Quoted 2 lines

TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES", "wks-debug-timeout", "3", "0 ",d)}'

Should probably make it more generic, not wks. I'd imagine it can be shared for U-boot and EFI/GRUB, so maybe bootloader-timeout or something?

Right now we have both a 2 second delay in U-Boot, and then a 3 second delay in the loaded EFI chainloader (GRUB). Which means after all the work we do to push down our boot times, we still just sit for 5 seconds waiting in case some developer has a terminal attached and wants to modify some option.. If you are a developer then you should know how to add back the boot delay, for everyone else it should be default disabled.

Having a "bootloader-timeout" var we can set would be nice, but it should set the U-Boot timeout and the EFI timeout should still be default 0 IMHO. No reason for two different delays in boot to wait for extra dev uart input.

I've got a patchset in the works to switch us away from GRUB to uefi-kernel anyway, which means direct kernel boot through EFI. No middle-man EFI chainloader like GRUB or systemd-boot needed. Just U-Boot -> Kernel like it should be on an embedded system.

Andrew

Quoted 39 lines
Quoted 39 lines

bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"

Would that work?

Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
---
  meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +1 -2
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
  # supports EFI.  Boot files are located in the first vfat partition with extra
  # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
  part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
  part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
--

2.39.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#11 lore raw

Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

Quoted 45 lines · Andrew Davis
Quoted 37 lines · Denys Dmytriyenko
Quoted 36 lines · Ryan Eatmon
Quoted 20 lines · Khem Raj via lists.yoctoproject.org
Quoted 19 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 5 lines · Andrew Davis via lists.yoctoproject.org

For all our platforms booting with EFI there is only one option today. The timeout gives the user 3 seconds to choose a different option, but as there is only one, this just causes a needless 3 second delay in boot time. Remove this delay and boot the only option immediately. If we ever have more than one option we can always add this back.

Quoted 4 lines

Well, menu delay in grub is not only used for selecting among available predefined options, but also for interactively editing the command line on the fly before booting.

for development, this sounds good, for production not so much.

Quoted 7 lines
Quoted 4 lines

Sure. And we also disable e.g. U-boot boot prompt delay all the time for our customers during production hardening stage, among many other similar items. But it is done for the final product - I don't think it should be done in a generic BSP layer that many use for development.

Right, it could be documented somewhere in README or some such would help the consumers of the layer.

Is there already something in the system that we could use to drive a variable that we can stick into the file?  Like EXTRA_IMAGE_FEATURES?  I know there used to be a debug-tweaks that got broken out into multiple features.  Maybe create a new one?

Quoted 6 lines
Quoted 2 lines

TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES", "wks-debug-timeout", "3", "0 ",d)}'

Should probably make it more generic, not wks. I'd imagine it can be shared for U-boot and EFI/GRUB, so maybe bootloader-timeout or something?

Quoted 6 lines

Right now we have both a 2 second delay in U-Boot, and then a 3 second delay in the loaded EFI chainloader (GRUB). Which means after all the work we do to push down our boot times, we still just sit for 5 seconds waiting in case some developer has a terminal attached and wants to modify some option.. If you are a developer then you should know how to add back the boot delay, for everyone else it should be default disabled.

Agreed. It would just be nice to have some nice easy way in the local.conf to add the delay back in if you want.

Quoted 56 lines

Having a "bootloader-timeout" var we can set would be nice, but it should set the U-Boot timeout and the EFI timeout should still be default 0 IMHO. No reason for two different delays in boot to wait for extra dev uart input.

I've got a patchset in the works to switch us away from GRUB to uefi-kernel anyway, which means direct kernel boot through EFI. No middle-man EFI chainloader like GRUB or systemd-boot needed. Just U-Boot -> Kernel like it should be on an embedded system.

Andrew

Quoted 44 lines
Quoted 44 lines

bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"

Would that work?

Quoted 36 lines
Quoted 36 lines
Quoted 36 lines
Quoted 36 lines
Quoted 36 lines

---
  meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/wic/sdimage-2part-efi.wks.in +0 -1
index 7252411c..c1089762 100644
@@ -3,6 +3,6 @@
   # supports EFI.  Boot files are located in the first vfat partition with extra
   # reserved space.  We cannot use a GPT here.
 
-bootloader --timeout=3 --append="rootfstype=ext4 rootwait 

${TI_WKS_BOOTLOADER_APPEND}"
+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
  part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid

Signature · 10 lines
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS