Skip to contentSkip to conversation

rust: update error.rs documentation

PATCH Superseded Onur Özkan 2 participants 3 messages Jul 30, 2025 – Jul 31, 2025 Rust

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Onur Özkan

author reviewer
#0 lore raw

PATCH v2 1/1 rust: update error.rs documentation

Adds missing header links.

Signed-off-by Onur Özkan <[email protected]>
---
 rust/kernel/error.rs | 2 ++
 1 file changed, 2 insertions(+)
rust/kernel/error.rs +2 -0
index 3dee3139fcd4..dd3e4224218d 100644
@@ -2,6 +2,8 @@
 
 //! Kernel errors.
 //!
+//! C header: [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)
+//! C header: [`include/linux/errno.h`](srctree/include/linux/errno.h)
 //! C header: [`include/uapi/asm-generic/errno-base.h`](srctree/include/uapi/asm-generic/errno-base.h)
 
 use crate::{

--
2.50.0

reviewer
#1 lore raw

Hi Onur,

Quoted 5 lines · Onur Özkan

Adds missing header links.

Signed-off-by Onur Özkan <[email protected]>

This is a v2 but there is no changelog.

Could you let us know what changed in future iterations, if any?

rust/kernel/error.rs line 5

Quoted 13 lines

---
rust/kernel/error.rs | 2 ++

1 file changed, 2 insertions(+)
rust/kernel/error.rs +1 -0
index 3dee3139fcd4..dd3e4224218d 100644
@@ -2,6 +2,8 @@
 
 //! Kernel errors.
 //!
+//! C header: [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)

Why is this mips file being referenced here? :)

Quoted 8 lines
rust/kernel/error.rs +1 -1
+//! C header: [`include/linux/errno.h`](srctree/include/linux/errno.h)
 //! C header: [`include/uapi/asm-generic/errno-base.h`](srctree/include/uapi/asm-generic/errno-base.h)
 
 use crate::{
--

2.50.0

— Daniel

author reviewer
#2 lore raw
Quoted 11 lines · On Wed, 30 Jul 2025 10:56:35 -0300 Daniel Almeida…

Hi Onur,

Quoted 5 lines · Onur Özkan

Adds missing header links.

Signed-off-by Onur Özkan <[email protected]>

This is a v2 but there is no changelog.

Could you let us know what changed in future iterations, if any?

I thought it wasn't necessary for short/simple patches, my bad. I will make sure to do it for all patches from now on.

Quoted 10 lines
Quoted 10 lines

---
rust/kernel/error.rs | 2 ++

1 file changed, 2 insertions(+)
rust/kernel/error.rs +0 -0
index 3dee3139fcd4..dd3e4224218d 100644
@@ -2,6 +2,8 @@
Quoted 6 lines

rust/kernel/error.rs

Quoted 4 lines
rust/kernel/error.rs +1 -0
 //! Kernel errors.
 //!
+//! C header:
 [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)

Why is this mips file being referenced here? :)

I was looking for where EOVERFLOW is defined, it turns out it's defined in multiple places (didn't know that yesterday). The one that bindgen resolves to is from srctree/include/uapi/asm-generic/errno.h header, I will send a v3 with the changelog at the end of the day.

Regards,
Onur