bcachefs: Fix incorrect transaction handling
PATCH 1/1 bcachefs: Fix incorrect transaction handling
The ')' before the second '?:' is not correct, transaction restart handling should include bch2_inode_hash_init_insert.
Reported-by [email protected]
Signed-off-by Alan Huang <[email protected]>
--- fs/bcachefs/fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/bcachefs/fs.c +2 -2
@@ -511,8 +511,8 @@ struct inode *bch2_vfs_inode_get(struct bch_fs *c, subvol_inum inum)struct bch_subvolume subvol;int ret =lockrestart_do (trans,bch2_subvolume_get (trans, inum.subvol, true, &subvol) ?: -bch2_inode_find_by_inum_trans (trans, inum, &inode_u)) ?: -PTR_ERR_OR_ZERO (inode =bch2_inode_hash_init_insert (trans, inum, &inode_u, &subvol)); +bch2_inode_find_by_inum_trans (trans, inum, &inode_u) ?: +PTR_ERR_OR_ZERO (inode =bch2_inode_hash_init_insert (trans, inum, &inode_u, &subvol)));return ret ?ERR_PTR (ret) : &inode->v; }
Signature · 1 line
2.49.0
Kent Overstreet
AppliedQuoted 5 lines · Alan Huang
The ')' before the second '?:' is not correct, transaction restart handling should include
bch2_inode_hash_init_insert.Reported-by [email protected]Signed-off-by Alan Huang <[email protected]>
hah
applied
Quoted 22 lines
--- fs/bcachefs/fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/bcachefs/fs.c +2
-2@@ -511,8 +511,8 @@ struct inode *bch2_vfs_inode_get(struct bch_fs *c, subvol_inum inum)struct bch_subvolume subvol;int ret =lockrestart_do (trans,bch2_subvolume_get (trans, inum.subvol, true, &subvol) ?: -bch2_inode_find_by_inum_trans (trans, inum, &inode_u)) ?: -PTR_ERR_OR_ZERO (inode =bch2_inode_hash_init_insert (trans, inum, &inode_u, &subvol)); +bch2_inode_find_by_inum_trans (trans, inum, &inode_u) ?: +PTR_ERR_OR_ZERO (inode =bch2_inode_hash_init_insert (trans, inum, &inode_u, &subvol)));return ret ?ERR_PTR (ret) : &inode->v; }Signature · 1 line
2.49.0