sparc: Drop the "-ansi" from the asflags
PATCH 1/1 sparc: Drop the "-ansi" from the asflags
From: Thomas Huth <[email protected]>
In the very early kernel 1.x days, assembler files were pre-processed with the "-traditional" flag. With kernel 1.1.85, the sparc subsystem was changed to use "-ansi" instead while the other parts of the kernel continued to use "-traditional". That "-traditional" got removed from the other architectures in the course of time, but the sparc part kept the "-ansi" until today.
This is bad since it comes with some disadvantages nowadays: You have to make sure to not include any header that contains a "//" C++ comment by accident (there are now some in the tree that use these for SPDX identifiers for example), and with "-ansi" we also do not get the pre-defined __ASSEMBLER__ macro which we'd like to use instead of the kernel-only __ASSEMBLY__ macro in the future.
Since there does not seem to be any compelling reason anymore to use "-ansi" nowadays, let's simply drop the "-ansi" flag from the sparc subsystem now to get rid of those disadvantages.
---
Note: I've only compile-tested this patch. No runtime testing done.
arch/sparc/kernel/Makefile | 2 -- arch/sparc/lib/Makefile | 2 +- arch/sparc/mm/Makefile | 2 -- arch/sparc/prom/Makefile | 1 - 4 files changed, 1 insertion(+), 6 deletions(-)
arch/sparc/kernel/Makefile +0 -2
@@ -4,8 +4,6 @@ # Makefile for the linux kernel. # -asflags-y := -ansi - # Undefine sparc when processing vmlinux.lds - it is used # And teach CPP we are doing $(BITS) builds (for this case) CPPFLAGS_vmlinux.lds := -Usparc -m$(BITS)
arch/sparc/lib/Makefile +1 -1
@@ -2,7 +2,7 @@ # Makefile for Sparc library files.. # -asflags-y := -ansi -DST_DIV0=0x02 +asflags-y := -DST_DIV0=0x02 lib-$(CONFIG_SPARC32) += ashrdi3.o lib-$(CONFIG_SPARC32) += memcpy.o memset.o
arch/sparc/mm/Makefile +0 -2
@@ -2,8 +2,6 @@ # Makefile for the linux Sparc-specific parts of the memory manager. # -asflags-y := -ansi - obj-$(CONFIG_SPARC64) += ultra.o tlb.o tsb.o obj-y += fault_$(BITS).o obj-y += init_$(BITS).o
arch/sparc/prom/Makefile +0 -1
@@ -2,7 +2,6 @@ # Makefile for the Sun Boot PROM interface library under # Linux. # -asflags := -ansi lib-y := bootstr_$(BITS).o lib-y += init_$(BITS).o
Signature · 1 line
2.50.1
Quoted 6 lines · Thomas Huth
Since there does not seem to be any compelling reason anymore to use "-ansi" nowadays, let's simply drop the "-ansi" flag from the sparc subsystem now to get rid of those disadvantages.
Signed-off-by Thomas Huth <[email protected]>
Quoted 21 lines · Thomas Huth
From: Thomas Huth <[email protected]>
In the very early kernel 1.x days, assembler files were pre-processed with the "-traditional" flag. With kernel 1.1.85, the sparc subsystem was changed to use "-ansi" instead while the other parts of the kernel continued to use "-traditional". That "-traditional" got removed from the other architectures in the course of time, but the sparc part kept the "-ansi" until today.
This is bad since it comes with some disadvantages nowadays: You have to make sure to not include any header that contains a "//" C++ comment by accident (there are now some in the tree that use these for SPDX identifiers for example), and with "-ansi" we also do not get the pre-defined
__ASSEMBLER__macro which we'd like to use instead of the kernel-only__ASSEMBLY__macro in the future.Since there does not seem to be any compelling reason anymore to use "-ansi" nowadays, let's simply drop the "-ansi" flag from the sparc subsystem now to get rid of those disadvantages.
Signed-off-by Thomas Huth <[email protected]>
Quoted 8 lines
---
Note: I've only compile-tested this patch. No runtime testing done.arch/sparc/kernel/Makefile | 2 -- arch/sparc/lib/Makefile | 2 +- arch/sparc/mm/Makefile | 2 -- arch/sparc/prom/Makefile | 1 - 4 files changed, 1 insertion(+), 6 deletions(-)
Picking this up to my for-next.
Thanks,
Andreas