mm/damon: update expired description of damos_action
Subsystems (2)
PATCH v3 1/1 mm/damon: update expired description of damos_action
Nowadays, damos operation actions support more various operation set. But comments(also, generated documentation) doesn't updated. So, fix the comments with current support status.
---
Changes from v1 [1]:
1. change baseline from damon/next to mm/mm-new
2. Add note about DAMOS_PAGEOUT and demotion.
Changes from v2 [2]:
1. Add reference design documentation to describe support of each damos_action.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
--- include/linux/damon.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
include/linux/damon.h +5 -5
@@ -110,7 +110,7 @@ struct damon_target {* * @DAMOS_WILLNEED: Call ``madvise()`` for the region with MADV_WILLNEED. * @DAMOS_COLD: Call ``madvise()`` for the region with MADV_COLD. -* @DAMOS_PAGEOUT: Call ``madvise()`` for the region with MADV_PAGEOUT. +* @DAMOS_PAGEOUT: Reclaim the region. * @DAMOS_HUGEPAGE: Call ``madvise()`` for the region with MADV_HUGEPAGE. * @DAMOS_NOHUGEPAGE: Call ``madvise()`` for the region with MADV_NOHUGEPAGE. * @DAMOS_LRU_PRIO: Prioritize the region on its LRU lists.
@@ -121,10 +121,10 @@ struct damon_target {* @NR_DAMOS_ACTIONS: Total number of DAMOS actions * * The support of each action is up to running &struct damon_operations. -* &enum DAMON_OPS_VADDR and &enum DAMON_OPS_FVADDR supports all actions except -* &enum DAMOS_LRU_PRIO and &enum DAMOS_LRU_DEPRIO. &enum DAMON_OPS_PADDR -* supports only &enum DAMOS_PAGEOUT, &enum DAMOS_LRU_PRIO, &enum -* DAMOS_LRU_DEPRIO, and &DAMOS_STAT. +* Refer to 'Operation Action' section of Documentation/mm/damon/design.rst for +* status of the supports. +* +* Note that DAMOS_PAGEOUT doesn't trigger demotions. */ enum damos_action {DAMOS_WILLNEED ,
Signature · 1 line
2.43.0
Quoted 5 lines · On Tue, 5 Aug 2025 21:39:40 +0900 Sang-Heon Jeon <[email protected]> wrote:
Nowadays, damos operation actions support more various operation set. But
comments(also, generated documentation)doesn't updated. So, fix the comments with current support status.Signed-off-by Sang-Heon Jeon <[email protected]>
Thanks,
SJ
[...]
SeongJae Park
maintainerAndrew, could you please merge this patch into mm tree?
Quoted 10 lines · On Tue, 5 Aug 2025 10:32:05 -0700 SeongJae Park <[email protected]> wrote:
Quoted 5 lines · On Tue, 5 Aug 2025 21:39:40 +0900 Sang-Heon Jeon <[email protected]> wrote:
Nowadays, damos operation actions support more various operation set. But
comments(also, generated documentation)doesn't updated. So, fix the comments with current support status.Signed-off-by Sang-Heon Jeon <[email protected]>Reviewed-by SeongJae Park <[email protected]>
Thanks,
SJ
[...]