ALSA: hda/ca0132: Fix missing error handling in ca0132_alt_select_out()
PATCH 1/1 ALSA: hda/ca0132: Fix missing error handling in ca0132_alt_select_out()
There are a couple of cases where the error is ignored or the error code isn't propagated in ca0132_alt_select_out(). Fix those.
Fixes def3f0a5c700 ("ALSA: hda/ca0132 - Add quirk output selection structures.")
Signed-off-by Takashi Iwai <[email protected]>
--- sound/hda/codecs/ca0132.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
sound/hda/codecs/ca0132.c +4 -1
@@ -4802,7 +4802,8 @@ static int ca0132_alt_select_out(struct hda_codec *codec)if (err <0 ) goto exit; -if (ca0132_alt_select_out_quirk_set (codec) <0 ) + err =ca0132_alt_select_out_quirk_set (codec); +if (err <0 ) goto exit;switch (spec->cur_out_type) {
@@ -4892,6 +4893,8 @@ static int ca0132_alt_select_out(struct hda_codec *codec) spec->bass_redirection_val); else err =ca0132_alt_surround_set_bass_redirection (codec,0 ); +if (err <0 ) + goto exit;/* Unmute DSP now that we're done with output selection. */ err = dspio_set_uint_param(codec, 0x96,
Signature · 1 line
2.50.1