Skip to contentSkip to conversation

package/libgtk3: remove schema compile hook

PATCH Applied James Knight 2 participants 6 messages Aug 9, 2025 – Jan 19

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/libgtk3: remove schema compile hook

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

---
 package/libgtk3/libgtk3.mk | 7 -------
 1 file changed, 7 deletions(-)
package/libgtk3/libgtk3.mk +0 -7
index d6d7c64a54..2fd3a26a3c 100644
@@ -87,13 +87,6 @@ else
 LIBGTK3_CONF_OPTS += -Dtests=false -Dinstalled_tests=false
 endif
 
-define LIBGTK3_COMPILE_GLIB_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas \
-		$(TARGET_DIR)/usr/share/glib-2.0/schemas
-endef
-
-LIBGTK3_POST_INSTALL_TARGET_HOOKS += LIBGTK3_COMPILE_GLIB_SCHEMAS
-
 # gtk+ >= 3.10 can build a native version of gtk-update-icon-cache if
 # --enable-gtk2-dependency=no is set when invoking './configure'.
 #
Signature · 6 lines
2.49.0.windows.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 package/libgtk4: remove schema compile hook

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

---
 package/libgtk4/libgtk4.mk | 6 ------
 1 file changed, 6 deletions(-)
package/libgtk4/libgtk4.mk +0 -6
index b00a2facad..f63e320629 100644
@@ -79,12 +79,6 @@ else
 LIBGTK4_CONF_OPTS += -Dbuild-demos=false -Dbuild-examples=false
 endif
 
-define LIBGTK4_COMPILE_GLIB_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas \
-		$(TARGET_DIR)/usr/share/glib-2.0/schemas
-endef
-LIBGTK4_POST_INSTALL_TARGET_HOOKS += LIBGTK4_COMPILE_GLIB_SCHEMAS
-
 # here, we build a native gtk4-update-icon-cache as host-libgtk4
 
 HOST_LIBGTK4_DEPENDENCIES = \
Signature · 6 lines
2.49.0.windows.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/3] package/libgtk4: remove schema compile hook

In reply of:

Quoted 5 lines

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

Applied to 2025.02.x and 2025.11.x. Thanks

Quoted 28 lines
---
 package/libgtk4/libgtk4.mk | 6 ------
 1 file changed, 6 deletions(-)
package/libgtk4/libgtk4.mk +0 -6
index b00a2facad..f63e320629 100644
@@ -79,12 +79,6 @@ else
 LIBGTK4_CONF_OPTS += -Dbuild-demos=false -Dbuild-examples=false
 endif
 
-define LIBGTK4_COMPILE_GLIB_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas \
-		$(TARGET_DIR)/usr/share/glib-2.0/schemas
-endef
-LIBGTK4_POST_INSTALL_TARGET_HOOKS += LIBGTK4_COMPILE_GLIB_SCHEMAS
-
 # here, we build a native gtk4-update-icon-cache as host-libgtk4
 
 HOST_LIBGTK4_DEPENDENCIES = \
Signature · 6 lines
2.49.0.windows.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

PATCH 3/3 package/gvfs: remove schema compile and cleanup hook

In reply to James Knight

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

In addition, libglib2 already removes schemas from the target during target finalization so the gvfs-specific cleanup can be dropped.

---
 package/gvfs/gvfs.mk | 12 ------------
 1 file changed, 12 deletions(-)
package/gvfs/gvfs.mk +0 -12
index b46b438dc6..6eff3bd859 100644
@@ -157,16 +157,4 @@ GVFS_CONF_OPTS += \
 	-Dtmpfilesdir=no
 endif
 
-define GVFS_REMOVE_TARGET_SCHEMAS
-	rm $(TARGET_DIR)/usr/share/glib-2.0/schemas/*.xml
-endef
-
-define GVFS_COMPILE_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas --targetdir=$(TARGET_DIR)/usr/share/glib-2.0/schemas $(STAGING_DIR)/usr/share/glib-2.0/schemas
-endef
-
-GVFS_POST_INSTALL_TARGET_HOOKS += \
-	GVFS_REMOVE_TARGET_SCHEMAS \
-	GVFS_COMPILE_SCHEMAS
-
 $(eval $(meson-package))
Signature · 6 lines
2.49.0.windows.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 3/3] package/gvfs: remove schema compile and cleanup hook

In reply of:

Quoted 8 lines

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

In addition, libglib2 already removes schemas from the target during target finalization so the gvfs-specific cleanup can be dropped.

Applied to 2025.02.x and 2025.11.x. Thanks

Quoted 32 lines
---
 package/gvfs/gvfs.mk | 12 ------------
 1 file changed, 12 deletions(-)
package/gvfs/gvfs.mk +0 -12
index b46b438dc6..6eff3bd859 100644
@@ -157,16 +157,4 @@ GVFS_CONF_OPTS += \
 	-Dtmpfilesdir=no
 endif
 
-define GVFS_REMOVE_TARGET_SCHEMAS
-	rm $(TARGET_DIR)/usr/share/glib-2.0/schemas/*.xml
-endef
-
-define GVFS_COMPILE_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas --targetdir=$(TARGET_DIR)/usr/share/glib-2.0/schemas $(STAGING_DIR)/usr/share/glib-2.0/schemas
-endef
-
-GVFS_POST_INSTALL_TARGET_HOOKS += \
-	GVFS_REMOVE_TARGET_SCHEMAS \
-	GVFS_COMPILE_SCHEMAS
-
 $(eval $(meson-package))
Signature · 6 lines
2.49.0.windows.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw
In reply to James Knight
Quoted 8 lines · On Fri, 8 Aug 2025 23:37:55 -0400 James Knight <[email protected]> wrote:

Dropping the need for this package to compile any schemas as the libglib2 package (a dependency) already handles this during target finalization.

---
 package/libgtk3/libgtk3.mk | 7 -------
 1 file changed, 7 deletions(-)

Thanks, series applied. Sorry that it took so long to apply this obviously correct series.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot