Skip to contentSkip to conversation

ext4: remove branch to identical code ext4_init_new_dir()

PATCH New Sergio Perez Gonzalez 1 participant 1 message Aug 12, 2025 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: remove branch to identical code ext4_init_new_dir()

It seems unnecessary to use a branch, in the event of error, to the same target label that would execute on success.

---
 fs/ext4/namei.c | 2 --
 1 file changed, 2 deletions(-)
fs/ext4/namei.c +0 -2
index d83f91b62317..01f379f5fd04 100644
@@ -2984,8 +2984,6 @@ int ext4_init_new_dir(handle_t *handle, struct inode *dir,
 		return PTR_ERR(dir_block);
 	de = (struct ext4_dir_entry_2 *)dir_block->b_data;
 	err = ext4_init_dirblock(handle, inode, dir_block, dir->i_ino, NULL, 0);
-	if (err)
-		goto out;
 out:
 	brelse(dir_block);
 	return err;
Signature · 1 line
2.43.0