Skip to contentSkip to conversation

efi_loader: Make EFI_VARIABLES_PRESEED depend on !COMPILE_TEST

PATCH In review Tom Rini 3 participants 3 messages Aug 12, 2025 – Aug 13, 2025

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 efi_loader: Make EFI_VARIABLES_PRESEED depend on !COMPILE_TEST

When doing compile testing build we cannot rely on having a valid file for EFI_VAR_SEED_FILE to exist, so disable this option when doing compile tests.

---
This was found when working on "allyesconfig" and the issue is that the file in EFI_VAR_SEED_FILE will not exist.
Cc: Heinrich Schuchardt <[email protected]>
Cc: Ilias Apalodimas <[email protected]>

---
 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +1 -0
index c2aa88f59fbb..a7092c2e8a8a 100644
@@ -195,6 +195,7 @@ endchoice
 
 config EFI_VARIABLES_PRESEED
 	bool "Initial values for UEFI variables"
+	depends on !COMPILE_TEST
 	depends on !EFI_MM_COMM_TEE
 	help
 	  Include a file with the initial values for non-volatile UEFI variables
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw

Am 12. August 2025 20:01:32 MESZ schrieb Tom Rini <[email protected]>:

Quoted 5 lines

When doing compile testing build we cannot rely on having a valid file for EFI_VAR_SEED_FILE to exist, so disable this option when doing compile tests.

Quoted 21 lines

---
This was found when working on "allyesconfig" and the issue is that the file in EFI_VAR_SEED_FILE will not exist.
Cc: Heinrich Schuchardt <[email protected]>
Cc: Ilias Apalodimas <[email protected]>
---
lib/efi_loader/Kconfig | 1 +

1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +0 -0
index c2aa88f59fbb..a7092c2e8a8a 100644
@@ -195,6 +195,7 @@ endchoice
 

config EFI_VARIABLES_PRESEED
bool "Initial values for UEFI variables"

lib/efi_loader/Kconfig +1 -0
+	depends on !COMPILE_TEST

depends on !EFI_MM_COMM_TEE
help
Include a file with the initial values for non-volatile UEFI variables

Reviewed-by on v1 1/1
#2 lore raw
In reply to Tom Rini
Quoted 28 lines · Tom Rini

When doing compile testing build we cannot rely on having a valid file for EFI_VAR_SEED_FILE to exist, so disable this option when doing compile tests.

---
This was found when working on "allyesconfig" and the issue is that the file in EFI_VAR_SEED_FILE will not exist.
Cc: Heinrich Schuchardt <[email protected]>
Cc: Ilias Apalodimas <[email protected]>

---
 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +1 -1
index c2aa88f59fbb..a7092c2e8a8a 100644
@@ -195,6 +195,7 @@ endchoice
 
 config EFI_VARIABLES_PRESEED
        bool "Initial values for UEFI variables"
+       depends on !COMPILE_TEST
        depends on !EFI_MM_COMM_TEE
        help
          Include a file with the initial values for non-volatile UEFI variables
--
Quoted 2 lines

2.43.0