cifs-utils: Fix documentation for character remappings.
Subsystems (2)
PATCH 1/1 cifs-utils: Fix documentation for character remappings.
Current documentation swapped the relevant specs. Additionally, elaborate on SFM a bit.
Supported by fs/cifs/cifs_unicode.c:{convert_to_sfu_char, convert_to_sfm_char}.
Previously raised in:
--- mount.cifs.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
mount.cifs.rst +4 -3
@@ -307,10 +307,10 @@ rwpidforward mapchars Translate six of the seven reserved characters (not backslash, but - including the colon, question mark, pipe, asterik, greater than and + including the colon, question mark, pipe, asterisk, greater than and less than characters) to the remap range (above 0xF000), which also allows the CIFS client to recognize files created with such characters - by Windows's Services for Mac. This can also be useful when mounting to + by Windows's Services for Unix. This can also be useful when mounting to most versions of Samba (which also forbids creating and opening files whose names contain any of these seven characters). This has no effect if the server does not support Unicode on the wire. Please note that
@@ -322,7 +322,8 @@ nomapchars mapposix Translate reserved characters similarly to ``mapchars`` but use the - mapping from Microsoft "Services For Unix". + mapping from Microsoft "Services For Mac". This additionally remaps the + double quote and a trailing period or space. intr currently unimplemented.
Signature · 1 line
2.50.1
Steve French
Appliedgood catch.
merged into cifs-utils for-next
There also are some undocumented ones that would be great if someone would add (and probably some that could be made clearer as well, or rearranged so less important ones are less distracting) - looking through fs/smb/client/fs_context.c and comparing to mount.cifs.8 could find a few mount parms missing descriptions.
Quoted 47 lines · Eduard Bachmakov
Current documentation swapped the relevant specs. Additionally, elaborate on SFM a bit.
Supported by fs/cifs/cifs_unicode.c:{convert_to_sfu_char,
convert_to_sfm_char}.Previously raised in:
Signed-off-by Eduard Bachmakov <[email protected]>--- mount.cifs.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)mount.cifs.rst +4
-4@@ -307,10 +307,10 @@ rwpidforward mapchars Translate six of the seven reserved characters (not backslash, but - including the colon, question mark, pipe, asterik, greater than and + including the colon, question mark, pipe, asterisk, greater than and less than characters) to the remap range (above 0xF000), which also allows the CIFS client to recognize files created with such characters - by Windows's Services for Mac. This can also be useful when mounting to + by Windows's Services for Unix. This can also be useful when mounting to most versions of Samba (which also forbids creating and opening files whose names contain any of these seven characters). This has no effect if the server does not support Unicode on the wire. Please note that@@ -322,7 +322,8 @@ nomapchars mapposix Translate reserved characters similarly to ``mapchars`` but use the - mapping from Microsoft "Services For Unix". + mapping from Microsoft "Services For Mac". This additionally remaps the + double quote and a trailing period or space. intr currently unimplemented. --2.50.1
Signature · 3 lines
Thanks, Steve