iio: core: Cast info mask to 'unsigned long *' in bit-ops
PATCH 1/1 iio: core: Cast info mask to 'unsigned long *' in bit-ops
for_each_set_bit()/find_*_bit() expect 'const unsigned long *' (see include/linux/find.h), but industrialio-core.c passes 'const long *' in iio_device_add_info_mask_type{,_avail}(). Sparse flags a signedness mismatch.
The masks are used purely as bit arrays. Cast them to 'const unsigned long *' at the call sites to match the helpers' prototypes, without changing memory layout or behavior. Changing the field types would cause unnecessary churn across IIO.
--- drivers/iio/industrialio-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/industrialio-core.c +2 -2
@@ -1248,7 +1248,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev,struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (indio_dev);int i, ret, attrcount =0 ; -for_each_set_bit (i, infomask,sizeof (*infomask)*8 ) { +for_each_set_bit (i, (const unsigned long *)infomask,sizeof (*infomask) *8 ) {if (i >=ARRAY_SIZE (iio_chan_info_postfix))return -EINVAL ; ret = __iio_add_chan_devattr(iio_chan_info_postfix[i],
@@ -1279,7 +1279,7 @@ static int iio_device_add_info_mask_type_avail(struct iio_dev *indio_dev,int i, ret, attrcount =0 ;char *avail_postfix; -for_each_set_bit (i, infomask,sizeof (*infomask) *8 ) { +for_each_set_bit (i, (const unsigned long *)infomask,sizeof (*infomask) *8 ) {if (i >=ARRAY_SIZE (iio_chan_info_postfix))return -EINVAL ; avail_postfix = kasprintf(GFP_KERNEL,
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerQuoted 4 lines · On Fri, 15 Aug 2025 10:25:28 +0800 Junjie Cao <[email protected]> wrote:
for_each_set_bit()/find_*_bit() expect 'const unsigned long *' (see
include/linux/find.h), butindustrialio-core.cpasses 'const long *' in iio_device_add_info_mask_type{,_avail}(). Sparse flags a signedness mismatch.
How do you get that warning? I'm not seeing it.
Quoted 5 lines
The masks are used purely as bit arrays. Cast them to 'const unsigned long *' at the call sites to match the helpers' prototypes, without changing memory layout or behavior. Changing the field types would cause unnecessary churn across IIO.
Did you have a go? Superficially feels like we should fix this up and that it should be almost entirely confined to relatively few core functions and the types of the various elements of struct iio_dev.
Might just be (builds and I'm not seeing new warning but then I couldn't trigger the one you saw!)
drivers/iio/industrialio-core.c +2 -2
@@ -1243,7 +1243,7 @@ static int iio_device_add_channel_label(struct iio_dev *indio_dev,static int iio_device_add_info_mask_type (struct iio_dev *indio_dev,struct iio_chan_spec const *chan,enum iio_shared_by shared_by, -const long *infomask) +const unsigned long *infomask) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (indio_dev);int i, ret, attrcount =0 ;
@@ -1273,7 +1273,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev,static int iio_device_add_info_mask_type_avail (struct iio_dev *indio_dev,struct iio_chan_spec const *chan,enum iio_shared_by shared_by, -const long *infomask) +const unsigned long *infomask) {struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (indio_dev);int i, ret, attrcount =0 ;
include/linux/iio/iio.h +8 -8
@@ -271,14 +271,14 @@ struct iio_chan_spec {unsigned int num_ext_scan_type; }; }; -long info_mask_separate; -long info_mask_separate_available; -long info_mask_shared_by_type; -long info_mask_shared_by_type_available; -long info_mask_shared_by_dir; -long info_mask_shared_by_dir_available; -long info_mask_shared_by_all; -long info_mask_shared_by_all_available; +unsigned long info_mask_separate; +unsigned long info_mask_separate_available; +unsigned long info_mask_shared_by_type; +unsigned long info_mask_shared_by_type_available; +unsigned long info_mask_shared_by_dir; +unsigned long info_mask_shared_by_dir_available; +unsigned long info_mask_shared_by_all; +unsigned long info_mask_shared_by_all_available;const struct iio_event_spec *event_spec;unsigned int num_event_specs;const struct iio_chan_spec_ext_info *ext_info;
I don't think there are problems with how these are set as that is always BIT()
Jonathan
Quoted 28 lines
Signed-off-by Junjie Cao <[email protected]>--- drivers/iio/industrialio-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/industrialio-core.c +2
-2@@ -1248,7 +1248,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev,struct iio_dev_opaque *iio_dev_opaque =to_iio_dev_opaque (indio_dev);int i, ret, attrcount =0 ; -for_each_set_bit (i, infomask,sizeof (*infomask)*8 ) { +for_each_set_bit (i, (const unsigned long *)infomask,sizeof (*infomask) *8 ) {if (i >=ARRAY_SIZE (iio_chan_info_postfix))return -EINVAL ; ret = __iio_add_chan_devattr(iio_chan_info_postfix[i],@@ -1279,7 +1279,7 @@ static int iio_device_add_info_mask_type_avail(struct iio_dev *indio_dev,int i, ret, attrcount =0 ;char *avail_postfix; -for_each_set_bit (i, infomask,sizeof (*infomask) *8 ) { +for_each_set_bit (i, (const unsigned long *)infomask,sizeof (*infomask) *8 ) {if (i >=ARRAY_SIZE (iio_chan_info_postfix))return -EINVAL ; avail_postfix = kasprintf(GFP_KERNEL,
Quoted 9 lines · Jonathan Cameron
Quoted 4 lines · On Fri, 15 Aug 2025 10:25:28 +0800 Junjie Cao <[email protected]> wrote:
for_each_set_bit()/find_*_bit() expect 'const unsigned long *' (see
include/linux/find.h), butindustrialio-core.cpasses 'const long *' in iio_device_add_info_mask_type{,_avail}(). Sparse flags a signedness mismatch.How do you get that warning? I'm not seeing it.
With or without any warning the casting is a very bad practice for bitmaps. NAK for any patch like this to any place in the kernel. I already fixed some of such castings in the past (one may browse the Git log with my name for that). Yes, I understand that in this case it's not critical as the sizeof(long) == sizeof(unsigned long), but in general this is not a good style leading to 3 potential issues (out-of-boundary accesses or endianess).
Quoted 11 lines
Quoted 4 lines
The masks are used purely as bit arrays. Cast them to 'const unsigned long *' at the call sites to match the helpers' prototypes, without changing memory layout or behavior. Changing the field types would cause unnecessary churn across IIO.
Did you have a go? Superficially feels like we should fix this up and that it should be almost entirely confined to relatively few core functions and the types of the various elements of struct
iio_dev.Might just be (builds and I'm not seeing new warning but then I couldn't trigger the one you saw!)
Jonathan, the patch you provided LGTM as I have in mind to do something like this a long time ago. Please, proceed with it. It would be better to have unsigned long * for bitmaps to make it uniform and follow the API.
Signature · 2 lines
With Best Regards, Andy Shevchenko