Skip to contentSkip to conversation

wic: add attribute parameter to parted

PATCH In review Mohammed 3 participants 3 messages Aug 17, 2025 – Aug 18, 2025

lore
Share & tools
lore

Mohammed

author
#0 lore raw

PATCH 1/1 wic: add attribute parameter to parted

---
 scripts/lib/wic/help.py                  | 3 +++
 scripts/lib/wic/ksparser.py              | 1 +
 scripts/lib/wic/partition.py             | 1 +
 scripts/lib/wic/plugins/imager/direct.py | 5 +++++
 4 files changed, 10 insertions(+)
scripts/lib/wic/help.py +3 -0
index 2e3061f343..fef856dbbb 100644
@@ -1070,6 +1070,9 @@ DESCRIPTION
                 an MBR header. Partitions with this flag will be included in
                 this MBR header.
 
+        --attribute: This option is specific to wic. This option is used to set
+                      the partition attribute.
+
     * bootloader
 
       This command allows the user to specify various bootloader
scripts/lib/wic/ksparser.py +1 -0
index 7ef3dc83dd..af4fb91d58 100644
@@ -189,6 +189,7 @@ class KickStart():
         part.add_argument('--fsuuid')
         part.add_argument('--no-fstab-update', action='store_true')
         part.add_argument('--mbr', action='store_true')
+        part.add_argument('--attribute')
 
         bootloader = subparsers.add_parser('bootloader')
         bootloader.add_argument('--append')
scripts/lib/wic/partition.py +1 -0
index b34691d313..cf5c51f105 100644
@@ -61,6 +61,7 @@ class Partition():
         self.update_fstab_in_rootfs = False
         self.hidden = args.hidden
         self.mbr = args.mbr
+        self.attribute = args.attribute
 
         self.lineno = lineno
         self.source_file = ""
scripts/lib/wic/plugins/imager/direct.py +5 -0
index 6e1f1c8cba..877a5d2a97 100644
@@ -664,6 +664,11 @@ class PartitionedImage():
                 exec_native_cmd("sfdisk --sector-size %s --part-attrs %s %s RequiredPartition" % \
                                 (self.sector_size, self.path, part.num),
                                 self.native_sysroot)
+            
+            if part.attribute:
+                logger.debug("Set attribute:'%s' for partition '%s' on disk '%s'", part.attribute ,part.num, self.path)
+                exec_native_cmd("sgdisk -A %s:=:%s %s" % (part.num, part.attribute, self.path), \
+                self.native_sysroot)
 
         if self.ptable_format == "gpt-hybrid":
             # Write a protective GPT partition
#1 lore raw

Patchtest results for [PATCH] wic: add attribute parameter to parted

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/wic-add-attribute-parameter-to-parted.patch

FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!

#2 lore raw
In reply to Mohammed
Quoted 14 lines · Mohammed via lists.openembedded.org
---
 scripts/lib/wic/help.py                  | 3 +++
 scripts/lib/wic/ksparser.py              | 1 +
 scripts/lib/wic/partition.py             | 1 +
 scripts/lib/wic/plugins/imager/direct.py | 5 +++++
 4 files changed, 10 insertions(+)
scripts/lib/wic/help.py +0 -0
index 2e3061f343..fef856dbbb 100644

scripts/lib/wic/help.py DESCRIPTION · line 1075

Quoted 6 lines
scripts/lib/wic/help.py +3 -0
@@ -1070,6 +1070,9 @@ DESCRIPTION
                 an MBR header. Partitions with this flag will be included in
                 this MBR header.
 
+        --attribute: This option is specific to wic. This option is used to set
+                      the partition attribute.
+

There is no point of mentioning its specific to wic, the help message is coming out of wic help.

scripts/lib/wic/ksparser.py class KickStart(): · line 192

Quoted 12 lines
scripts/lib/wic/help.py +0 -0
     * bootloader
 
       This command allows the user to specify various bootloader
scripts/lib/wic/ksparser.py +1 -0
index 7ef3dc83dd..af4fb91d58 100644
@@ -189,6 +189,7 @@ class KickStart():
         part.add_argument('--fsuuid')
         part.add_argument('--no-fstab-update', action='store_true')
         part.add_argument('--mbr', action='store_true')
+        part.add_argument('--attribute')

Tabs/Spaces, use the existing formatting.

Quoted 20 lines
scripts/lib/wic/ksparser.py +0 -0
         bootloader = subparsers.add_parser('bootloader')
         bootloader.add_argument('--append')
scripts/lib/wic/partition.py +1 -0
index b34691d313..cf5c51f105 100644
@@ -61,6 +61,7 @@ class Partition():
         self.update_fstab_in_rootfs = False
         self.hidden = args.hidden
         self.mbr = args.mbr
+        self.attribute = args.attribute
 
         self.lineno = lineno
         self.source_file = ""
scripts/lib/wic/plugins/imager/direct.py +0 -0
index 6e1f1c8cba..877a5d2a97 100644

scripts/lib/wic/plugins/imager/direct.py class PartitionedImage(): · line 672

Quoted 9 lines
scripts/lib/wic/plugins/imager/direct.py +5 -0
@@ -664,6 +664,11 @@ class PartitionedImage():
                 exec_native_cmd("sfdisk --sector-size %s --part-attrs %s %s RequiredPartition" % \
                                 (self.sector_size, self.path, part.num),
                                 self.native_sysroot)
+
+            if part.attribute:
+                logger.debug("Set attribute:'%s' for partition '%s' on disk '%s'", part.attribute ,part.num, self.path)
+                exec_native_cmd("sgdisk -A %s:=:%s %s" % (part.num, part.attribute, self.path), \
+                self.native_sysroot)
 

It would be good to add a testcase for this as well.

Quoted 11 lines
scripts/lib/wic/plugins/imager/direct.py +0 -1
         if self.ptable_format == "gpt-hybrid":
             # Write a protective GPT partition
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#222005): https://lists.openembedded.org/g/openembedded-core/message/222005
Mute This Topic: https://lists.openembedded.org/mt/114750349/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-