FAILED: patch "[PATCH] xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags" failed to apply to 6.12-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x d2845519b0723c5d5a0266cbf410495f9b8fd65c
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025081858-issuing-conclude-4ff3@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From d2845519b0723c5d5a0266cbf410495f9b8fd65c Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <[email protected]>
Date: Wed, 23 Jul 2025 14:19:44 +0200
Subject: [PATCH] xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags
Fix up xfs_inumbers to now pass in the XFS_IBULK* flags into the flags argument to xfs_inobt_walk, which expects the XFS_IWALK* flags.
Currently passing the wrong flags works for non-debug builds because the only XFS_IWALK* flag has the same encoding as the corresponding XFS_IBULK* flag, but in debug builds it can trigger an assert that no incorrect flag is passed. Instead just extra the relevant flag.
fs/xfs/xfs_itable.c +5 -1
@@ -447,17 +447,21 @@ xfs_inumbers( .breq = breq, };struct xfs_trans *tp; +unsigned int iwalk_flags =0 ;int error =0 ;if (xfs_bulkstat_already_done (breq->mp, breq->startino))return 0 ; +if (breq->flags &XFS_IBULK_SAME_AG ) + iwalk_flags |=XFS_IWALK_SAME_AG ; +/* * Grab an empty transaction so that we can use its recursive buffer * locking abilities to detect cycles in the inobt without deadlocking. */ tp =xfs_trans_alloc_empty (breq->mp); - error =xfs_inobt_walk (breq->mp, tp, breq->startino, breq->flags, + error =xfs_inobt_walk (breq->mp, tp, breq->startino, iwalk_flags, xfs_inumbers_walk, breq->icount, &ic);xfs_trans_cancel (tp);
Sasha Levin
maintainerPATCH 1/1 xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags
From: Christoph Hellwig <[email protected]>
[ Upstream commit d2845519b0723c5d5a0266cbf410495f9b8fd65c ]
Fix up xfs_inumbers to now pass in the XFS_IBULK* flags into the flags argument to xfs_inobt_walk, which expects the XFS_IWALK* flags.
Currently passing the wrong flags works for non-debug builds because the only XFS_IWALK* flag has the same encoding as the corresponding XFS_IBULK* flag, but in debug builds it can trigger an assert that no incorrect flag is passed. Instead just extra the relevant flag.
--- fs/xfs/xfs_itable.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/xfs/xfs_itable.c +5 -1
@@ -430,11 +430,15 @@ xfs_inumbers( .breq = breq, };struct xfs_trans *tp; +unsigned int iwalk_flags =0 ;int error =0 ;if (xfs_bulkstat_already_done (breq->mp, breq->startino))return 0 ; +if (breq->flags &XFS_IBULK_SAME_AG ) + iwalk_flags |=XFS_IWALK_SAME_AG ; +/* * Grab an empty transaction so that we can use its recursive buffer * locking abilities to detect cycles in the inobt without deadlocking.
@@ -443,7 +447,7 @@ xfs_inumbers(if (error) goto out; - error =xfs_inobt_walk (breq->mp, tp, breq->startino, breq->flags, + error =xfs_inobt_walk (breq->mp, tp, breq->startino, iwalk_flags, xfs_inumbers_walk, breq->icount, &ic);xfs_trans_cancel (tp); out:
Signature · 1 line
2.50.1
Sasha Levin
maintainerPATCH 1/1 xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags
In reply to [email protected]From: Christoph Hellwig <[email protected]>
[ Upstream commit d2845519b0723c5d5a0266cbf410495f9b8fd65c ]
Fix up xfs_inumbers to now pass in the XFS_IBULK* flags into the flags argument to xfs_inobt_walk, which expects the XFS_IWALK* flags.
Currently passing the wrong flags works for non-debug builds because the only XFS_IWALK* flag has the same encoding as the corresponding XFS_IBULK* flag, but in debug builds it can trigger an assert that no incorrect flag is passed. Instead just extra the relevant flag.
--- fs/xfs/xfs_itable.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/xfs/xfs_itable.c +5 -1
@@ -430,11 +430,15 @@ xfs_inumbers( .breq = breq, };struct xfs_trans *tp; +unsigned int iwalk_flags =0 ;int error =0 ;if (xfs_bulkstat_already_done (breq->mp, breq->startino))return 0 ; +if (breq->flags &XFS_IBULK_SAME_AG ) + iwalk_flags |=XFS_IWALK_SAME_AG ; +/* * Grab an empty transaction so that we can use its recursive buffer * locking abilities to detect cycles in the inobt without deadlocking.
@@ -443,7 +447,7 @@ xfs_inumbers(if (error) goto out; - error =xfs_inobt_walk (breq->mp, tp, breq->startino, breq->flags, + error =xfs_inobt_walk (breq->mp, tp, breq->startino, iwalk_flags, xfs_inumbers_walk, breq->icount, &ic);xfs_trans_cancel (tp); out:
Signature · 1 line
2.50.1