MIPS: Loongson64: Replace deprecated strcpy() with strscpy_pad()
Subsystems (2)
PATCH 1/1 MIPS: Loongson64: Replace deprecated strcpy() with strscpy_pad()
strcpy() is deprecated; use strscpy_pad() instead.
strscpy_pad() already copies the source strings and zero-pads the tail of the destination buffers, making the explicit initializations to zero redundant. Remove them to ensure the buffers are only written to once.
No functional changes intended.
Signed-off-by Thorsten Blum <[email protected]>
--- arch/mips/loongson64/boardinfo.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
arch/mips/loongson64/boardinfo.c +5 -4
@@ -1,17 +1,18 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/kobject.h> +#include <linux/string.h> #include <boot_param.h> static ssize_t boardinfo_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) { -char board_manufacturer[64 ] = {0 }; +char board_manufacturer[64 ];char *tmp_board_manufacturer = board_manufacturer; -char bios_vendor[64 ] = {0 }; +char bios_vendor[64 ];char *tmp_bios_vendor = bios_vendor; -strcpy (board_manufacturer, eboard->name); -strcpy (bios_vendor, einter->description); +strscpy_pad (board_manufacturer, eboard->name); +strscpy_pad (bios_vendor, einter->description);return sprintf (buf, "Board Info\n"
Signature · 1 line
2.50.1
Quoted 43 lines · Thorsten Blum
strcpy()is deprecated; usestrscpy_pad()instead.
strscpy_pad()already copies the source strings and zero-pads the tail of the destination buffers, making the explicit initializations to zero redundant. Remove them to ensure the buffers are only written to once.No functional changes intended.
Signed-off-by Thorsten Blum <[email protected]>--- arch/mips/loongson64/boardinfo.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)arch/mips/loongson64/boardinfo.c +5
-4@@ -1,17 +1,18 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/kobject.h> +#include <linux/string.h> #include <boot_param.h> static ssize_t boardinfo_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) { -char board_manufacturer[64 ] = {0 }; +char board_manufacturer[64 ];char *tmp_board_manufacturer = board_manufacturer; -char bios_vendor[64 ] = {0 }; +char bios_vendor[64 ];char *tmp_bios_vendor = bios_vendor; -strcpy (board_manufacturer, eboard->name); -strcpy (bios_vendor, einter->description); +strscpy_pad (board_manufacturer, eboard->name); +strscpy_pad (bios_vendor, einter->description);return sprintf (buf, "Board Info\n"Signature · 1 line
2.50.1
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]