goarch.bbclass: do not leak TUNE_FEATURES into crosssdk task signatures
PATCH v3 1/2 goarch.bbclass: do not leak TUNE_FEATURES into crosssdk task signatures
From: Alexander Kanavin <[email protected]>
The default assignments look like this:TARGET_GO386 = "${@go_map_386(d.getVar('TARGET_ARCH'), d.getVar('TUNE_FEATURES'), d)}"
TUNE_FEATURES is a target-specific variable, and so should be used only for target builds. The change is similar to what is already done for native packages.
--- meta/classes-recipe/goarch.bbclass | 3 +++ 1 file changed, 3 insertions(+)
meta/classes-recipe/goarch.bbclass +3 -0
@@ -24,6 +24,9 @@ TARGET_GOMIPS = "${@go_map_mips(d.getVar('TARGET_ARCH'), d.getVar('TUNE_FEATURES TARGET_GOARM:class-native = "7" TARGET_GO386:class-native = "sse2" TARGET_GOMIPS:class-native = "hardfloat" +TARGET_GOARM:class-crosssdk = "7" +TARGET_GO386:class-crosssdk = "sse2" +TARGET_GOMIPS:class-crosssdk = "hardfloat" TARGET_GOTUPLE = "${TARGET_GOOS}_${TARGET_GOARCH}" GO_BUILD_BINDIR = "${@['bin/${HOST_GOTUPLE}','bin'][d.getVar('BUILD_GOTUPLE') == d.getVar('HOST_GOTUPLE')]}"
Signature · 1 line
2.39.5
PATCH v3 2/2 fragments/autobuilder: add go to SDK_TOOLCHAIN_LANGS
From: Alexander Kanavin <[email protected]>
For reasons unknown, only rust was listed, which means nativesdk-go was not built or tested, which lead to breakage like one fixed in
https://git.yoctoproject.org/poky/commit/?id=a669cd2e0c760da9d7e872daea9590fc9e86d766
Note that with this change only building and installing go into SDKsis tested, but no tests are performed with the toolchain itself in testsdk/testimage.
For that, a bug has been filed:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15953
Remove go from x32 and mingw targets as it will not build for them. (next to similar removals for rust)
--- meta/classes-recipe/populate_sdk_base.bbclass | 3 +++ meta/conf/fragments/yocto-autobuilder/autobuilder.conf | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)
meta/classes-recipe/populate_sdk_base.bbclass +3 -0
@@ -62,6 +62,9 @@ SDK_TOOLCHAIN_LANGS ??= "" SDK_TOOLCHAIN_LANGS:remove:sdkmingw32 = "rust" # libstd-rs doesn't build for mips n32 with compiler constraint errors SDK_TOOLCHAIN_LANGS:remove:mipsarchn32 = "rust" +# go will not build for x86-x32 or mingw +SDK_TOOLCHAIN_LANGS:remove:linux-gnux32 = "go" +SDK_TOOLCHAIN_LANGS:remove:sdkmingw32 = "go" TOOLCHAIN_HOST_TASK ?= " \ nativesdk-packagegroup-sdk-host \
meta/conf/fragments/yocto-autobuilder/autobuilder.conf +1 -1
@@ -9,5 +9,5 @@ IMAGE_CLASSES += 'testimage' SDK_EXT_TYPE = 'minimal' SDK_INCLUDE_TOOLCHAIN = '1' ESDK_LOCALCONF_REMOVE:append = 'BB_HASHSERVE' -SDK_TOOLCHAIN_LANGS += 'rust' +SDK_TOOLCHAIN_LANGS += 'go rust'
Signature · 1 line
2.39.5
Patchtest results for [PATCH v3 1/2] goarch.bbclass: do not leak TUNE_FEATURES into crosssdk task signatures
In reply to Alexander KanavinThank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/v3-1-2-goarch.bbclass-do-not-leak-TUNE_FEATURES-into-crosssdk-task-signatures.patch
FAIL: test commit message user tags: Mbox includes one or more GitHub-style username tags. Ensure that any "@" symbols are stripped out of usernames (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!